* [PATCH -next] drm/msm: Add missing OF dependency for DRM_MSM
@ 2022-05-06 2:03 YueHaibing
2022-05-06 11:36 ` Dmitry Baryshkov
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2022-05-06 2:03 UTC (permalink / raw)
To: robdclark, sean, quic_abhinavk, airlied, daniel, dmitry.baryshkov
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, YueHaibing
WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS
Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n]
Selected by [y]:
- DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n)
DRM_DP_AUX_BUS depends on OF, so DRM_MSM also should depends on it.
Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/msm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
index 4e0cbd682725..1d710a20ffdd 100644
--- a/drivers/gpu/drm/msm/Kconfig
+++ b/drivers/gpu/drm/msm/Kconfig
@@ -3,6 +3,7 @@
config DRM_MSM
tristate "MSM DRM"
depends on DRM
+ depends on OF
depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST
depends on COMMON_CLK
depends on IOMMU_SUPPORT
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] drm/msm: Add missing OF dependency for DRM_MSM
2022-05-06 2:03 [PATCH -next] drm/msm: Add missing OF dependency for DRM_MSM YueHaibing
@ 2022-05-06 11:36 ` Dmitry Baryshkov
2022-05-06 12:26 ` YueHaibing
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Baryshkov @ 2022-05-06 11:36 UTC (permalink / raw)
To: YueHaibing, robdclark, sean, quic_abhinavk, airlied, daniel
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel
On 06/05/2022 05:03, YueHaibing wrote:
> WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS
> Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n]
> Selected by [y]:
> - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n)
>
> DRM_DP_AUX_BUS depends on OF, so DRM_MSM also should depends on it.
I think the proper fix would be to make DRM_DP_AUX_BUS depend on OF ||
COMPILE_TEST rather than just OF
>
> Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/drm/msm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
> index 4e0cbd682725..1d710a20ffdd 100644
> --- a/drivers/gpu/drm/msm/Kconfig
> +++ b/drivers/gpu/drm/msm/Kconfig
> @@ -3,6 +3,7 @@
> config DRM_MSM
> tristate "MSM DRM"
> depends on DRM
> + depends on OF
> depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST
> depends on COMMON_CLK
> depends on IOMMU_SUPPORT
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] drm/msm: Add missing OF dependency for DRM_MSM
2022-05-06 11:36 ` Dmitry Baryshkov
@ 2022-05-06 12:26 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2022-05-06 12:26 UTC (permalink / raw)
To: Dmitry Baryshkov, robdclark, sean, quic_abhinavk, airlied, daniel
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel
On 2022/5/6 19:36, Dmitry Baryshkov wrote:
> On 06/05/2022 05:03, YueHaibing wrote:
>> WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS
>> Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n]
>> Selected by [y]:
>> - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n)
>>
>> DRM_DP_AUX_BUS depends on OF, so DRM_MSM also should depends on it.
>
> I think the proper fix would be to make DRM_DP_AUX_BUS depend on OF || COMPILE_TEST rather than just OF
Make sense, will do this in v2.
>
>>
>> Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/gpu/drm/msm/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
>> index 4e0cbd682725..1d710a20ffdd 100644
>> --- a/drivers/gpu/drm/msm/Kconfig
>> +++ b/drivers/gpu/drm/msm/Kconfig
>> @@ -3,6 +3,7 @@
>> config DRM_MSM
>> tristate "MSM DRM"
>> depends on DRM
>> + depends on OF
>> depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST
>> depends on COMMON_CLK
>> depends on IOMMU_SUPPORT
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-06 12:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-06 2:03 [PATCH -next] drm/msm: Add missing OF dependency for DRM_MSM YueHaibing
2022-05-06 11:36 ` Dmitry Baryshkov
2022-05-06 12:26 ` YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®