* [PATCH v1] arm64: defconfig: enable WCD937X codec driver as module
@ 2026-01-08 7:34 Ajay Kumar Nandam
2026-01-08 7:41 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Ajay Kumar Nandam @ 2026-01-08 7:34 UTC (permalink / raw)
To: Krzysztof Kozlowski, Geert Uytterhoeven, Bjorn Andersson,
Arnd Bergmann, Heiko Stuebner, Eric Biggers, Michal Simek,
Luca Weiss, Lad Prabhakar, Kuninori Morimoto
Cc: linux-kernel, mohammad.rafi.shaik, ravi.hothi
Enable the Qualcomm WCD937X SoundWire codec driver as a
loadable module in the arm64 defconfig. This is required for
audio support on platforms using the WCD937X codec over the
SoundWire interface.
Signed-off-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 3cc05d4b4df9..cc9b6bb955a7 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1141,6 +1141,7 @@ CONFIG_SND_SOC_TLV320AIC32X4_I2C=m
CONFIG_SND_SOC_TLV320AIC3X_I2C=m
CONFIG_SND_SOC_WCD9335=m
CONFIG_SND_SOC_WCD934X=m
+CONFIG_SND_SOC_WCD937X_SDW=m
CONFIG_SND_SOC_WCD939X_SDW=m
CONFIG_SND_SOC_WM8524=m
CONFIG_SND_SOC_WM8904=m
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] arm64: defconfig: enable WCD937X codec driver as module
2026-01-08 7:34 [PATCH v1] arm64: defconfig: enable WCD937X codec driver as module Ajay Kumar Nandam
@ 2026-01-08 7:41 ` Krzysztof Kozlowski
2026-01-08 7:42 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-08 7:41 UTC (permalink / raw)
To: Ajay Kumar Nandam, Geert Uytterhoeven, Bjorn Andersson,
Arnd Bergmann, Heiko Stuebner, Eric Biggers, Michal Simek,
Luca Weiss, Lad Prabhakar, Kuninori Morimoto
Cc: linux-kernel, mohammad.rafi.shaik, ravi.hothi
On 08/01/2026 08:34, Ajay Kumar Nandam wrote:
> Enable the Qualcomm WCD937X SoundWire codec driver as a
> loadable module in the arm64 defconfig. This is required for
> audio support on platforms using the WCD937X codec over the
> SoundWire interface.
Not a good reason. You wrote four lines of which all are redundant,
because you still did not prove we need to have support for WCD937x
Soundwire interface.
>
> Signed-off-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
> ---
Look incomplete.
https://lore.kernel.org/all/20240916052352.1819088-1-quic_mohs@quicinc.com/
https://lore.kernel.org/all/20241010052646.2597418-1-quic_mohs@quicinc.com/
https://lore.kernel.org/all/20241007082312.2136358-1-quic_mohs@quicinc.com/
https://lore.kernel.org/all/?q=CONFIG_SND_SOC_WCD937X_SDW
But anyway, you did the same as all patches before, so it won't be
applied. There is really no point in sending the same three four times.
Nothing will change, no one will apply it, unless you finally fix the
address list.
You also Cc-ed here completely random addresses... E.g. why is this
relevant to Xilinx?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] arm64: defconfig: enable WCD937X codec driver as module
2026-01-08 7:41 ` Krzysztof Kozlowski
@ 2026-01-08 7:42 ` Krzysztof Kozlowski
2026-01-09 7:33 ` Ajay Kumar Nandam
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-08 7:42 UTC (permalink / raw)
To: Ajay Kumar Nandam, Geert Uytterhoeven, Bjorn Andersson,
Arnd Bergmann, Heiko Stuebner, Eric Biggers, Michal Simek,
Luca Weiss, Lad Prabhakar, Kuninori Morimoto
Cc: linux-kernel, mohammad.rafi.shaik, ravi.hothi
On 08/01/2026 08:41, Krzysztof Kozlowski wrote:
> On 08/01/2026 08:34, Ajay Kumar Nandam wrote:
>> Enable the Qualcomm WCD937X SoundWire codec driver as a
>> loadable module in the arm64 defconfig. This is required for
>> audio support on platforms using the WCD937X codec over the
>> SoundWire interface.
>
> Not a good reason. You wrote four lines of which all are redundant,
> because you still did not prove we need to have support for WCD937x
> Soundwire interface.
>
>>
>> Signed-off-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
>> ---
>
>
> Look incomplete.
>
> https://lore.kernel.org/all/20240916052352.1819088-1-quic_mohs@quicinc.com/
> https://lore.kernel.org/all/20241010052646.2597418-1-quic_mohs@quicinc.com/
> https://lore.kernel.org/all/20241007082312.2136358-1-quic_mohs@quicinc.com/
>
> https://lore.kernel.org/all/?q=CONFIG_SND_SOC_WCD937X_SDW
>
> But anyway, you did the same as all patches before, so it won't be
> applied. There is really no point in sending the same three four times.
> Nothing will change, no one will apply it, unless you finally fix the
> address list.
>
> You also Cc-ed here completely random addresses... E.g. why is this
> relevant to Xilinx?
And I already said all this so you could have build on previous feedback
instead of repeating exactly same two mistakes.
https://lore.kernel.org/all/638a44fc-c693-4270-8643-7cd75a3c6ba6@linaro.org/
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] arm64: defconfig: enable WCD937X codec driver as module
2026-01-08 7:42 ` Krzysztof Kozlowski
@ 2026-01-09 7:33 ` Ajay Kumar Nandam
0 siblings, 0 replies; 4+ messages in thread
From: Ajay Kumar Nandam @ 2026-01-09 7:33 UTC (permalink / raw)
To: Krzysztof Kozlowski, Geert Uytterhoeven, Bjorn Andersson,
Arnd Bergmann, Heiko Stuebner, Eric Biggers, Michal Simek,
Luca Weiss, Lad Prabhakar, Kuninori Morimoto
Cc: linux-kernel, mohammad.rafi.shaik, ravi.hothi
On 1/8/2026 1:12 PM, Krzysztof Kozlowski wrote:
> On 08/01/2026 08:41, Krzysztof Kozlowski wrote:
>> On 08/01/2026 08:34, Ajay Kumar Nandam wrote:
>>> Enable the Qualcomm WCD937X SoundWire codec driver as a
>>> loadable module in the arm64 defconfig. This is required for
>>> audio support on platforms using the WCD937X codec over the
>>> SoundWire interface.
>>
>> Not a good reason. You wrote four lines of which all are redundant,
>> because you still did not prove we need to have support for WCD937x
>> Soundwire interface.
Ack, I will rework the commit message accordingly.
>>
>>>
>>> Signed-off-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
>>> ---
>>
>>
>> Look incomplete.
>>
>> https://lore.kernel.org/all/20240916052352.1819088-1-quic_mohs@quicinc.com/
>> https://lore.kernel.org/all/20241010052646.2597418-1-quic_mohs@quicinc.com/
>> https://lore.kernel.org/all/20241007082312.2136358-1-quic_mohs@quicinc.com/
>>
>> https://lore.kernel.org/all/?q=CONFIG_SND_SOC_WCD937X_SDW
>>
>> But anyway, you did the same as all patches before, so it won't be
>> applied. There is really no point in sending the same three four times.
>> Nothing will change, no one will apply it, unless you finally fix the
>> address list.
>>
>> You also Cc-ed here completely random addresses... E.g. why is this
>> relevant to Xilinx?
ack,
will resend an updated version with the correct maintainer and mailing
list CCs added using get_maintainer.pl for the relevant SoC.
Previously, I ran get_maintainer.pl on the arm64 defconfig instead of on
the SoC‑specific, which resulted in an incomplete and incorrect address
list. I will ensure this is done correctly going forward.
Thanks
Ajay kumar Nandam
>
>
> And I already said all this so you could have build on previous feedback
> instead of repeating exactly same two mistakes.
>
> https://lore.kernel.org/all/638a44fc-c693-4270-8643-7cd75a3c6ba6@linaro.org/
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-01-09 7:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-08 7:34 [PATCH v1] arm64: defconfig: enable WCD937X codec driver as module Ajay Kumar Nandam
2026-01-08 7:41 ` Krzysztof Kozlowski
2026-01-08 7:42 ` Krzysztof Kozlowski
2026-01-09 7:33 ` Ajay Kumar Nandam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®