ltp testcases failed due to commit cf3128a7aca

ltp testcases failed due to commit cf3128a7aca

[mengkanglai]

When I run latest ltp testcase testcases/network/stress/udp/uni-basic/udp6-uni-basic07 with latest kernel 6.5, it failed in “ltpapicmd.c:188: Failed to configure SAD/SPD on the local host”.
I found that the reason for failure was this command:
output_ipsec_conf src \
        $IPSEC_PROTO $IPSEC_MODE $SPI $lhost_addr $rhost_addr \
            |  setkey -c 2>&1 | tee $ipsec_log

This command eventually use setkey -c to add spdadd entry failed:
spdadd $src_ipaddr $dst_ipaddr any
　　-P out ipsec $protocol/tunnel/${src_ipaddr}-${dst_ipaddr}/use ; 

It returns Invalid argument.

I found this failed due to commit cf3128a7aca(af_key: Reject optional tunnel/BEET mode templates in outbound policies), is latest ltp testcases are not adapted? 

Re: ltp testcases failed due to commit cf3128a7aca

[Herbert Xu]

On Mon, Aug 28, 2023 at 02:12:12AM +0000, mengkanglai wrote:
>
> This command eventually use setkey -c to add spdadd entry failed:
> spdadd $src_ipaddr $dst_ipaddr any
> 　　-P out ipsec $protocol/tunnel/${src_ipaddr}-${dst_ipaddr}/use ; 
> 
> It returns Invalid argument.
> 
> I found this failed due to commit cf3128a7aca(af_key: Reject optional tunnel/BEET mode templates in outbound policies), is latest ltp testcases are not adapted? 

Correct.  The above specification makes no sense for an outbound
policy as the SA can only be optional for inbound (where IPComp
can be skipped for incompressible plaintext).  So change the word
"use" above to "require" and it should work.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt