* [PATCH next] drm/msm/dpu: fix error pointer dereference in msm_kms_init_aspace()
@ 2025-02-25 7:30 Dan Carpenter
2025-02-25 10:04 ` Dmitry Baryshkov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dan Carpenter @ 2025-02-25 7:30 UTC (permalink / raw)
To: Abhinav Kumar
Cc: Rob Clark, Dmitry Baryshkov, Sean Paul, Marijn Suijten,
David Airlie, Simona Vetter, Jessica Zhang, linux-arm-msm,
dri-devel, freedreno, linux-kernel, kernel-janitors
If msm_gem_address_space_create() fails, then return right away.
Otherwise it leads to a Oops when we dereference "aspace" on the next
line.
Fixes: 2d215d440faa ("drm/msm: register a fault handler for display mmu faults")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/gpu/drm/msm/msm_kms.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/msm_kms.c b/drivers/gpu/drm/msm/msm_kms.c
index b877278888e6..35d5397e73b4 100644
--- a/drivers/gpu/drm/msm/msm_kms.c
+++ b/drivers/gpu/drm/msm/msm_kms.c
@@ -209,6 +209,7 @@ struct msm_gem_address_space *msm_kms_init_aspace(struct drm_device *dev)
if (IS_ERR(aspace)) {
dev_err(mdp_dev, "aspace create, error %pe\n", aspace);
mmu->funcs->destroy(mmu);
+ return aspace;
}
msm_mmu_set_fault_handler(aspace->mmu, kms, msm_kms_fault_handler);
--
2.47.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH next] drm/msm/dpu: fix error pointer dereference in msm_kms_init_aspace()
2025-02-25 7:30 [PATCH next] drm/msm/dpu: fix error pointer dereference in msm_kms_init_aspace() Dan Carpenter
@ 2025-02-25 10:04 ` Dmitry Baryshkov
2025-02-25 23:03 ` Abhinav Kumar
2025-03-07 4:55 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-02-25 10:04 UTC (permalink / raw)
To: Dan Carpenter
Cc: Abhinav Kumar, Rob Clark, Sean Paul, Marijn Suijten,
David Airlie, Simona Vetter, Jessica Zhang, linux-arm-msm,
dri-devel, freedreno, linux-kernel, kernel-janitors
On Tue, Feb 25, 2025 at 10:30:26AM +0300, Dan Carpenter wrote:
> If msm_gem_address_space_create() fails, then return right away.
> Otherwise it leads to a Oops when we dereference "aspace" on the next
> line.
>
> Fixes: 2d215d440faa ("drm/msm: register a fault handler for display mmu faults")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/gpu/drm/msm/msm_kms.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH next] drm/msm/dpu: fix error pointer dereference in msm_kms_init_aspace()
2025-02-25 7:30 [PATCH next] drm/msm/dpu: fix error pointer dereference in msm_kms_init_aspace() Dan Carpenter
2025-02-25 10:04 ` Dmitry Baryshkov
@ 2025-02-25 23:03 ` Abhinav Kumar
2025-03-07 4:55 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Abhinav Kumar @ 2025-02-25 23:03 UTC (permalink / raw)
To: Dan Carpenter
Cc: Rob Clark, Dmitry Baryshkov, Sean Paul, Marijn Suijten,
David Airlie, Simona Vetter, Jessica Zhang, linux-arm-msm,
dri-devel, freedreno, linux-kernel, kernel-janitors
On 2/24/2025 11:30 PM, Dan Carpenter wrote:
> If msm_gem_address_space_create() fails, then return right away.
> Otherwise it leads to a Oops when we dereference "aspace" on the next
> line.
>
> Fixes: 2d215d440faa ("drm/msm: register a fault handler for display mmu faults")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/gpu/drm/msm/msm_kms.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH next] drm/msm/dpu: fix error pointer dereference in msm_kms_init_aspace()
2025-02-25 7:30 [PATCH next] drm/msm/dpu: fix error pointer dereference in msm_kms_init_aspace() Dan Carpenter
2025-02-25 10:04 ` Dmitry Baryshkov
2025-02-25 23:03 ` Abhinav Kumar
@ 2025-03-07 4:55 ` Dmitry Baryshkov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-03-07 4:55 UTC (permalink / raw)
To: Abhinav Kumar, Dan Carpenter
Cc: Dmitry Baryshkov, Rob Clark, Sean Paul, Marijn Suijten,
David Airlie, Simona Vetter, Jessica Zhang, linux-arm-msm,
dri-devel, freedreno, linux-kernel, kernel-janitors
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Tue, 25 Feb 2025 10:30:26 +0300, Dan Carpenter wrote:
> If msm_gem_address_space_create() fails, then return right away.
> Otherwise it leads to a Oops when we dereference "aspace" on the next
> line.
>
>
Applied, thanks!
[1/1] drm/msm/dpu: fix error pointer dereference in msm_kms_init_aspace()
https://gitlab.freedesktop.org/lumag/msm/-/commit/f9d1b528219b
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-07 4:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-25 7:30 [PATCH next] drm/msm/dpu: fix error pointer dereference in msm_kms_init_aspace() Dan Carpenter
2025-02-25 10:04 ` Dmitry Baryshkov
2025-02-25 23:03 ` Abhinav Kumar
2025-03-07 4:55 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®