* [PATCH 0/3] dt-bindings: arm: qcom-soc: Improve validation of expected SoC naming
@ 2026-05-19 20:03 Krzysztof Kozlowski
2026-05-19 20:03 ` [PATCH 1/3] dt-bindings: arm: qcoms-c: Include Eliza, Kaanapali and others in SoC names Krzysztof Kozlowski
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-19 20:03 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Krzysztof Kozlowski
The schema checking for expected naming patterns for SoC IP block nodes
was really incomplete and was checking only nodes with single
compatible. Improve that because questions about expected compatibles
still appear, e.g. we have
Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml with:
- qcom,pcie-x1e80100 (expected old legacy style)
- qcom,glymur-pcie (change to new style, ok fine, let's switch to new
style... but...)
I am afraid that a new SoC will revert that back to old style, e.g.:
qcom,pcie-whatever-new-soc
Best regards,
Krzysztof
---
Krzysztof Kozlowski (3):
dt-bindings: arm: qcoms-c: Include Eliza, Kaanapali and others in SoC names
dt-bindings: arm: qcom-soc: Document more of existing legacy style compatibles
dt-bindings: arm: qcom-soc: Validate nodes with fallbacks
.../devicetree/bindings/arm/qcom-soc.yaml | 173 ++++++++++++++++-----
1 file changed, 137 insertions(+), 36 deletions(-)
---
base-commit: 80dd246accce631c328ea43294e53b2b2dd2aa32
change-id: 20260519-dt-bindings-qcom-soc-naming-4f97dec54139
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/3] dt-bindings: arm: qcoms-c: Include Eliza, Kaanapali and others in SoC names
2026-05-19 20:03 [PATCH 0/3] dt-bindings: arm: qcom-soc: Improve validation of expected SoC naming Krzysztof Kozlowski
@ 2026-05-19 20:03 ` Krzysztof Kozlowski
2026-05-20 10:05 ` Konrad Dybcio
2026-05-19 20:03 ` [PATCH 2/3] dt-bindings: arm: qcom-soc: Document more of existing legacy style compatibles Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-19 20:03 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Krzysztof Kozlowski
Grow the schema checking for proper SoC compatible naming style with
recently upstreamed new Qualcomm SoCs: Eliza, Kaanapali, Hawi, Mahua and
Shikra.
Since switching from model numbers to codenames, this list with explicit
codenames will have to grow and list them all in order for the schema to
work. It feels like a churn, but the compatible naming is still mess,
for example, the schema pci/qcom,pcie-x1e80100.yaml with a legacy naming
vendor,IP-SoC (qcom,pcie-x1e80100) received a new compatible with new
style (qcom,glymur-pcie).
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
Documentation/devicetree/bindings/arm/qcom-soc.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
index 27261039d56f..b5f3a750cce8 100644
--- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
@@ -25,7 +25,7 @@ select:
compatible:
oneOf:
- pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
- - pattern: "^qcom,.*(glymur|milos).*$"
+ - pattern: "^qcom,.*(eliza|kaanapali|glymur|hawi|mahua|milos|shikra).*$"
required:
- compatible
@@ -36,7 +36,7 @@ properties:
- pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+(pro)?-.*$"
- pattern: "^qcom,sar[0-9]+[a-z]?-.*$"
- pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"
- - pattern: "^qcom,(glymur|milos)-.*$"
+ - pattern: "^qcom,(eliza|kaanapali|glymur|hawi|mahua|milos|shikra)-.*$"
# Legacy namings - variations of existing patterns/compatibles are OK,
# but do not add completely new entries to these:
--
2.51.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/3] dt-bindings: arm: qcom-soc: Document more of existing legacy style compatibles
2026-05-19 20:03 [PATCH 0/3] dt-bindings: arm: qcom-soc: Improve validation of expected SoC naming Krzysztof Kozlowski
2026-05-19 20:03 ` [PATCH 1/3] dt-bindings: arm: qcoms-c: Include Eliza, Kaanapali and others in SoC names Krzysztof Kozlowski
@ 2026-05-19 20:03 ` Krzysztof Kozlowski
2026-05-20 10:04 ` Konrad Dybcio
2026-05-19 20:03 ` [PATCH 3/3] dt-bindings: arm: qcom-soc: Validate nodes with fallbacks Krzysztof Kozlowski
2026-05-20 10:05 ` [PATCH 0/3] dt-bindings: arm: qcom-soc: Improve validation of expected SoC naming Konrad Dybcio
3 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-19 20:03 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Krzysztof Kozlowski
The schema misses several old style compatibles with SoC component
trailing in the compatible (qcom,IP-SoC):
- qcom,apss-wdt-x1e80100
- qcom,apss-wdt-xxx and qcom,scm-xxx for SoC with code names
- qcom,kpss-gcc-xxx
- qcom,rpmcc-xxx
- qcom,tcsr-xxx
- qcom,usb-hs-phy-xxx
It also missed qcom,ipq806x-ahci.
None of these were flagged by schema, because they were used with
fallbacks and the schema checks only for single compatibles.
Nevertheless document them for complete picture and for future change,
which will apply the schema to fallbacks as well.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
Documentation/devicetree/bindings/arm/qcom-soc.yaml | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
index b5f3a750cce8..d7d64e0e146b 100644
--- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
@@ -40,12 +40,20 @@ properties:
# Legacy namings - variations of existing patterns/compatibles are OK,
# but do not add completely new entries to these:
- - pattern: "^qcom,[ak]pss-wdt-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$"
+ - pattern: "^qcom,[ak]pss-wdt-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
+ # qcom,apss-wdt with codenames
+ - pattern: "^qcom,apss-wdt-[a-z]+$"
+ - pattern: "^qcom,kpss-gcc-(apq|ipq|mdm|msm)[0-9]+.*$"
- pattern: "^qcom,gcc-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$"
- pattern: "^qcom,mmcc-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$"
- pattern: "^qcom,pcie-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
- pattern: "^qcom,rpm-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$"
- - pattern: "^qcom,scm-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
+ - pattern: "^qcom,rpmcc-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$"
+ - pattern: "^qcom,scm-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sar?|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
+ # qcom,scm with codenames
+ - pattern: "^qcom,scm-[a-z]+$"
+ - pattern: "^qcom,tcsr-(apq|ipq|mdm|msm)[0-9]+.*$"
+ - pattern: "^qcom,usb-hs-phy-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
- enum:
- qcom,dsi-ctrl-6g-qcm2290
- qcom,gpucc-sdm630
@@ -61,6 +69,7 @@ properties:
# Legacy compatibles with wild-cards - list cannot grow with new bindings:
- enum:
+ - qcom,ipq806x-ahci
- qcom,ipq806x-gmac
- qcom,ipq806x-nand
- qcom,ipq806x-sata-phy
--
2.51.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/3] dt-bindings: arm: qcom-soc: Validate nodes with fallbacks
2026-05-19 20:03 [PATCH 0/3] dt-bindings: arm: qcom-soc: Improve validation of expected SoC naming Krzysztof Kozlowski
2026-05-19 20:03 ` [PATCH 1/3] dt-bindings: arm: qcoms-c: Include Eliza, Kaanapali and others in SoC names Krzysztof Kozlowski
2026-05-19 20:03 ` [PATCH 2/3] dt-bindings: arm: qcom-soc: Document more of existing legacy style compatibles Krzysztof Kozlowski
@ 2026-05-19 20:03 ` Krzysztof Kozlowski
2026-05-19 23:56 ` Rob Herring (Arm)
2026-05-20 10:05 ` [PATCH 0/3] dt-bindings: arm: qcom-soc: Improve validation of expected SoC naming Konrad Dybcio
3 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-19 20:03 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Krzysztof Kozlowski
The schema checking for expected naming patterns for SoC IP block nodes
was really incomplete and was checking only nodes with single
compatible. Fixing this and applying schema for nodes with fallbacks is
not trivial, because obvious solution like:
minItems: 1
items:
- oneOf:
- pattern: ...
- pattern: ...
- {}
- {}
is not allowed by dtschema. The binding should also skip root nodes,
which have SoC-based fallback, but completely random front compatibles.
Solve this all by:
1. Extending the select pattern to match all nodes except root node.
2. Apply schema to all items of "compatible" property, which means it
will be evaluating also all sorts of generic compatibles like
"syscon". List them all and let's hope that fallback list will not
grow too much, because generic compatible fallbacks are discouraged.
The benefit is that this schema is finally very specific and evaluates
all nodes for desired naming.
Diff is a bit obfuscated, due to indentation change so briefly
explaining:
1. None of the patterns are changed (neither in "Preferred naming style"
group nor in "Legacy namings").
2. None of the enums with "Legacy namings" and "Legacy compatibles with
wild-cards" are changed.
3. Add pattern for sound cards.
4. Add list with all used generic fallbacks.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
.../devicetree/bindings/arm/qcom-soc.yaml | 182 ++++++++++++++++-----
1 file changed, 137 insertions(+), 45 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
index d7d64e0e146b..e27701261509 100644
--- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
@@ -22,58 +22,150 @@ description: |
select:
properties:
+ # Select all nodes which have SoC-based compatibles, but not the root
+ # "/" node, because its front compatibles do not follow any SoC patterns
+ $nodename:
+ pattern: "[^/]"
compatible:
- oneOf:
- - pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
- - pattern: "^qcom,.*(eliza|kaanapali|glymur|hawi|mahua|milos|shikra).*$"
+ contains:
+ oneOf:
+ - pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
+ - pattern: "^qcom,.*(eliza|kaanapali|glymur|hawi|mahua|milos|shikra).*$"
required:
- compatible
properties:
compatible:
- oneOf:
- # Preferred naming style for compatibles of SoC components:
- - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+(pro)?-.*$"
- - pattern: "^qcom,sar[0-9]+[a-z]?-.*$"
- - pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"
- - pattern: "^qcom,(eliza|kaanapali|glymur|hawi|mahua|milos|shikra)-.*$"
+ # SoC specific compatibles can appear alone or be followed by another SoC
+ # specific compatible or generic fallbacks, therefore check for compatible
+ # should use ideally:
+ #
+ # minItems: 1
+ # items:
+ # - oneOf:
+ # - pattern: ...
+ # - pattern: ...
+ # - {}
+ # - {}
+ #
+ # but that is not allowed by dtschema ("oneOf" cannot be used as an item
+ # for a compatible). Work around this by defining schema for all items,
+ # but drawback is that we need also to list all known generic fallbacks
+ # like "syscon" etc.
+ minItems: 1
+ maxItems: 4
+ items:
+ # Use anyOf, because soundcards will match few patterns
+ anyOf:
+ # Preferred naming style for compatibles of SoC components:
+ - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+(pro)?-.*$"
+ - pattern: "^qcom,sar[0-9]+[a-z]?-.*$"
+ - pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"
+ - pattern: "^qcom,(eliza|kaanapali|glymur|hawi|mahua|milos|shikra)-.*$"
- # Legacy namings - variations of existing patterns/compatibles are OK,
- # but do not add completely new entries to these:
- - pattern: "^qcom,[ak]pss-wdt-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
- # qcom,apss-wdt with codenames
- - pattern: "^qcom,apss-wdt-[a-z]+$"
- - pattern: "^qcom,kpss-gcc-(apq|ipq|mdm|msm)[0-9]+.*$"
- - pattern: "^qcom,gcc-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$"
- - pattern: "^qcom,mmcc-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$"
- - pattern: "^qcom,pcie-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
- - pattern: "^qcom,rpm-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$"
- - pattern: "^qcom,rpmcc-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$"
- - pattern: "^qcom,scm-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sar?|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
- # qcom,scm with codenames
- - pattern: "^qcom,scm-[a-z]+$"
- - pattern: "^qcom,tcsr-(apq|ipq|mdm|msm)[0-9]+.*$"
- - pattern: "^qcom,usb-hs-phy-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
- - enum:
- - qcom,dsi-ctrl-6g-qcm2290
- - qcom,gpucc-sdm630
- - qcom,gpucc-sdm660
- - qcom,lcc-apq8064
- - qcom,lcc-ipq8064
- - qcom,lcc-mdm9615
- - qcom,lcc-msm8960
- - qcom,lpass-cpu-apq8016
- - qcom,usb-ss-ipq4019-phy
- - qcom,usb-hs-ipq4019-phy
- - qcom,vqmmc-ipq4019-regulator
+ # Legacy namings - variations of existing patterns/compatibles are OK,
+ # but do not add completely new entries to these:
+ - pattern: "^qcom,[ak]pss-wdt-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
+ # qcom,apss-wdt with codenames
+ - pattern: "^qcom,apss-wdt-[a-z]+$"
+ - pattern: "^qcom,kpss-gcc-(apq|ipq|mdm|msm)[0-9]+.*$"
+ - pattern: "^qcom,gcc-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$"
+ - pattern: "^qcom,mmcc-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$"
+ - pattern: "^qcom,pcie-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
+ - pattern: "^qcom,rpm-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$"
+ - pattern: "^qcom,rpmcc-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$"
+ - pattern: "^qcom,scm-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sar?|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
+ # qcom,scm with codenames
+ - pattern: "^qcom,scm-[a-z]+$"
+ - pattern: "^qcom,tcsr-(apq|ipq|mdm|msm)[0-9]+.*$"
+ - pattern: "^qcom,usb-hs-phy-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
- # Legacy compatibles with wild-cards - list cannot grow with new bindings:
- - enum:
- - qcom,ipq806x-ahci
- - qcom,ipq806x-gmac
- - qcom,ipq806x-nand
- - qcom,ipq806x-sata-phy
- - qcom,ipq806x-usb-phy-ss
- - qcom,ipq806x-usb-phy-hs
+ - enum:
+ - qcom,dsi-ctrl-6g-qcm2290
+ - qcom,gpucc-sdm630
+ - qcom,gpucc-sdm660
+ - qcom,lcc-apq8064
+ - qcom,lcc-ipq8064
+ - qcom,lcc-mdm9615
+ - qcom,lcc-msm8960
+ - qcom,lpass-cpu-apq8016
+ - qcom,usb-ss-ipq4019-phy
+ - qcom,usb-hs-ipq4019-phy
+ - qcom,vqmmc-ipq4019-regulator
+
+ # Legacy compatibles with wild-cards - list cannot grow with new bindings:
+ - enum:
+ - qcom,ipq806x-ahci
+ - qcom,ipq806x-gmac
+ - qcom,ipq806x-nand
+ - qcom,ipq806x-sata-phy
+ - qcom,ipq806x-usb-phy-ss
+ - qcom,ipq806x-usb-phy-hs
+
+ # Schema matches also sound card nodes and its front compatibles can be anything
+ - pattern: "^.*,.*sndcard$"
+
+ # List all used generic fallbacks. The list can grow, but in practice
+ # it is not expected, because specific compatibles are preferred for
+ # fallbacks as well.
+ - enum:
+ - arm,gic-v3
+ - arm,mmu-500
+ - generic-ahci
+ - jedec,ufs-2.0
+ - mmio-sram
+ - qcom,adreno-smmu
+ - qcom,aoss-qmp
+ - qcom,cpr
+ - qcom,cpufreq-epss
+ - qcom,cpufreq-hw
+ - qcom,dcc
+ - qcom,dwc3
+ - qcom,epss-l3
+ - qcom,eud
+ - qcom,glink-smd-rpm
+ - qcom,inline-crypto-engine
+ - qcom,ipcc
+ - qcom,kpss-gcc
+ - qcom,kpss-timer
+ - qcom,kpss-wdt
+ - qcom,mdp5
+ - qcom,mdss-dsi-ctrl
+ - qcom,msm-iommu-v1
+ - qcom,msm-iommu-v2
+ - qcom,msm-timer
+ - qcom,osm-l3
+ - qcom,pcie2-phy
+ - qcom,pdc
+ - qcom,pmic-glink
+ - qcom,qce
+ - qcom,qfprom
+ - qcom,qspi-v1
+ - qcom,qusb2-v2-phy
+ - qcom,rpm-proc
+ - qcom,rpmh-rsc
+ - qcom,rpmcc
+ - qcom,saw2
+ - qcom,scm
+ - qcom,sdhci-msm-v4
+ - qcom,sdhci-msm-v5
+ - qcom,sec-qfprom
+ - qcom,smd-rpm
+ - qcom,smmu-500
+ - qcom,smmu-v2
+ - qcom,snps-dwc3
+ - qcom,ssc-block-bus
+ - qcom,tcsr-mutex
+ - qcom,trng
+ - qcom,tsens-v0_1
+ - qcom,tsens-v1
+ - qcom,tsens-v2
+ - qcom,ufshc
+ - qcom,usb-hs-phy
+ - qcom,usb-snps-hs-5nm-phy
+ - qcom,usb-snps-hs-7nm-phy
+ - simple-mfd
+ - snps,dwmac
+ - syscon
additionalProperties: true
--
2.51.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] dt-bindings: arm: qcom-soc: Validate nodes with fallbacks
2026-05-19 20:03 ` [PATCH 3/3] dt-bindings: arm: qcom-soc: Validate nodes with fallbacks Krzysztof Kozlowski
@ 2026-05-19 23:56 ` Rob Herring (Arm)
0 siblings, 0 replies; 10+ messages in thread
From: Rob Herring (Arm) @ 2026-05-19 23:56 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, linux-arm-msm, Konrad Dybcio, linux-kernel,
devicetree, Conor Dooley, Krzysztof Kozlowski
On Tue, 19 May 2026 22:03:20 +0200, Krzysztof Kozlowski wrote:
> The schema checking for expected naming patterns for SoC IP block nodes
> was really incomplete and was checking only nodes with single
> compatible. Fixing this and applying schema for nodes with fallbacks is
> not trivial, because obvious solution like:
>
> minItems: 1
> items:
> - oneOf:
> - pattern: ...
> - pattern: ...
> - {}
> - {}
>
> is not allowed by dtschema. The binding should also skip root nodes,
> which have SoC-based fallback, but completely random front compatibles.
>
> Solve this all by:
> 1. Extending the select pattern to match all nodes except root node.
> 2. Apply schema to all items of "compatible" property, which means it
> will be evaluating also all sorts of generic compatibles like
> "syscon". List them all and let's hope that fallback list will not
> grow too much, because generic compatible fallbacks are discouraged.
>
> The benefit is that this schema is finally very specific and evaluates
> all nodes for desired naming.
>
> Diff is a bit obfuscated, due to indentation change so briefly
> explaining:
> 1. None of the patterns are changed (neither in "Preferred naming style"
> group nor in "Legacy namings").
> 2. None of the enums with "Legacy namings" and "Legacy compatibles with
> wild-cards" are changed.
> 3. Add pattern for sound cards.
> 4. Add list with all used generic fallbacks.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> .../devicetree/bindings/arm/qcom-soc.yaml | 182 ++++++++++++++++-----
> 1 file changed, 137 insertions(+), 45 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.example.dtb: phy (qcom,usb-hsic-phy-msm8974): compatible:0: 'anyOf' conditional failed, one must be fixed:
'qcom,usb-hsic-phy-msm8974' does not match '^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+(pro)?-.*$'
'qcom,usb-hsic-phy-msm8974' does not match '^qcom,sar[0-9]+[a-z]?-.*$'
'qcom,usb-hsic-phy-msm8974' does not match '^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$'
'qcom,usb-hsic-phy-msm8974' does not match '^qcom,(eliza|kaanapali|glymur|hawi|mahua|milos|shikra)-.*$'
'qcom,usb-hsic-phy-msm8974' does not match '^qcom,[ak]pss-wdt-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+.*$'
'qcom,usb-hsic-phy-msm8974' does not match '^qcom,apss-wdt-[a-z]+$'
'qcom,usb-hsic-phy-msm8974' does not match '^qcom,kpss-gcc-(apq|ipq|mdm|msm)[0-9]+.*$'
'qcom,usb-hsic-phy-msm8974' does not match '^qcom,gcc-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$'
'qcom,usb-hsic-phy-msm8974' does not match '^qcom,mmcc-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$'
'qcom,usb-hsic-phy-msm8974' does not match '^qcom,pcie-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+.*$'
'qcom,usb-hsic-phy-msm8974' does not match '^qcom,rpm-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$'
'qcom,usb-hsic-phy-msm8974' does not match '^qcom,rpmcc-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$'
'qcom,usb-hsic-phy-msm8974' does not match '^qcom,scm-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sar?|sc|sd[amx]|sm|x1[ep])[0-9]+.*$'
'qcom,usb-hsic-phy-msm8974' does not match '^qcom,scm-[a-z]+$'
'qcom,usb-hsic-phy-msm8974' does not match '^qcom,tcsr-(apq|ipq|mdm|msm)[0-9]+.*$'
'qcom,usb-hsic-phy-msm8974' does not match '^qcom,usb-hs-phy-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+.*$'
'qcom,usb-hsic-phy-msm8974' is not one of ['qcom,dsi-ctrl-6g-qcm2290', 'qcom,gpucc-sdm630', 'qcom,gpucc-sdm660', 'qcom,lcc-apq8064', 'qcom,lcc-ipq8064', 'qcom,lcc-mdm9615', 'qcom,lcc-msm8960', 'qcom,lpass-cpu-apq8016', 'qcom,usb-ss-ipq4019-phy', 'qcom,usb-hs-ipq4019-phy', 'qcom,vqmmc-ipq4019-regulator']
'qcom,usb-hsic-phy-msm8974' is not one of ['qcom,ipq806x-ahci', 'qcom,ipq806x-gmac', 'qcom,ipq806x-nand', 'qcom,ipq806x-sata-phy', 'qcom,ipq806x-usb-phy-ss', 'qcom,ipq806x-usb-phy-hs']
'qcom,usb-hsic-phy-msm8974' does not match '^.*,.*sndcard$'
'qcom,usb-hsic-phy-msm8974' is not one of ['arm,gic-v3', 'arm,mmu-500', 'generic-ahci', 'jedec,ufs-2.0', 'mmio-sram', 'qcom,adreno-smmu', 'qcom,aoss-qmp', 'qcom,cpr', 'qcom,cpufreq-epss', 'qcom,cpufreq-hw', 'qcom,dcc', 'qcom,dwc3', 'qcom,epss-l3', 'qcom,eud', 'qcom,glink-smd-rpm', 'qcom,inline-crypto-engine', 'qcom,ipcc', 'qcom,kpss-gcc', 'qcom,kpss-timer', 'qcom,kpss-wdt', 'qcom,mdp5', 'qcom,mdss-dsi-ctrl', 'qcom,msm-iommu-v1', 'qcom,msm-iommu-v2', 'qcom,msm-timer', 'qcom,osm-l3', 'qcom,pcie2-phy', 'qcom,pdc', 'qcom,pmic-glink', 'qcom,qce', 'qcom,qfprom', 'qcom,qspi-v1', 'qcom,qusb2-v2-phy', 'qcom,rpm-proc', 'qcom,rpmh-rsc', 'qcom,rpmcc', 'qcom,saw2', 'qcom,scm', 'qcom,sdhci-msm-v4', 'qcom,sdhci-msm-v5', 'qcom,sec-qfprom', 'qcom,smd-rpm', 'qcom,smmu-500', 'qcom,smmu-v2', 'qcom,snps-dwc3', 'qcom,ssc-block-bus', 'qcom,tcsr-mutex', 'qcom,trng', 'qcom,tsens-v0_1', 'qcom,tsens-v1', 'qcom,tsens-v2', 'qcom,ufshc', 'qcom,usb-hs-phy', 'qcom,usb-snps-hs-5nm-phy', 'qcom,usb-snps-hs-7nm-phy',
'simple-mfd', 'snps,dwmac', 'syscon']
from schema $id: http://devicetree.org/schemas/arm/qcom-soc.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/phy/qcom,usb-hsic-phy.example.dtb: phy (qcom,usb-hsic-phy-msm8974): compatible:1: 'anyOf' conditional failed, one must be fixed:
'qcom,usb-hsic-phy' does not match '^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+(pro)?-.*$'
'qcom,usb-hsic-phy' does not match '^qcom,sar[0-9]+[a-z]?-.*$'
'qcom,usb-hsic-phy' does not match '^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$'
'qcom,usb-hsic-phy' does not match '^qcom,(eliza|kaanapali|glymur|hawi|mahua|milos|shikra)-.*$'
'qcom,usb-hsic-phy' does not match '^qcom,[ak]pss-wdt-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+.*$'
'qcom,usb-hsic-phy' does not match '^qcom,apss-wdt-[a-z]+$'
'qcom,usb-hsic-phy' does not match '^qcom,kpss-gcc-(apq|ipq|mdm|msm)[0-9]+.*$'
'qcom,usb-hsic-phy' does not match '^qcom,gcc-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$'
'qcom,usb-hsic-phy' does not match '^qcom,mmcc-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$'
'qcom,usb-hsic-phy' does not match '^qcom,pcie-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+.*$'
'qcom,usb-hsic-phy' does not match '^qcom,rpm-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$'
'qcom,usb-hsic-phy' does not match '^qcom,rpmcc-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$'
'qcom,usb-hsic-phy' does not match '^qcom,scm-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sar?|sc|sd[amx]|sm|x1[ep])[0-9]+.*$'
'qcom,usb-hsic-phy' does not match '^qcom,scm-[a-z]+$'
'qcom,usb-hsic-phy' does not match '^qcom,tcsr-(apq|ipq|mdm|msm)[0-9]+.*$'
'qcom,usb-hsic-phy' does not match '^qcom,usb-hs-phy-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+.*$'
'qcom,usb-hsic-phy' is not one of ['qcom,dsi-ctrl-6g-qcm2290', 'qcom,gpucc-sdm630', 'qcom,gpucc-sdm660', 'qcom,lcc-apq8064', 'qcom,lcc-ipq8064', 'qcom,lcc-mdm9615', 'qcom,lcc-msm8960', 'qcom,lpass-cpu-apq8016', 'qcom,usb-ss-ipq4019-phy', 'qcom,usb-hs-ipq4019-phy', 'qcom,vqmmc-ipq4019-regulator']
'qcom,usb-hsic-phy' is not one of ['qcom,ipq806x-ahci', 'qcom,ipq806x-gmac', 'qcom,ipq806x-nand', 'qcom,ipq806x-sata-phy', 'qcom,ipq806x-usb-phy-ss', 'qcom,ipq806x-usb-phy-hs']
'qcom,usb-hsic-phy' does not match '^.*,.*sndcard$'
'qcom,usb-hsic-phy' is not one of ['arm,gic-v3', 'arm,mmu-500', 'generic-ahci', 'jedec,ufs-2.0', 'mmio-sram', 'qcom,adreno-smmu', 'qcom,aoss-qmp', 'qcom,cpr', 'qcom,cpufreq-epss', 'qcom,cpufreq-hw', 'qcom,dcc', 'qcom,dwc3', 'qcom,epss-l3', 'qcom,eud', 'qcom,glink-smd-rpm', 'qcom,inline-crypto-engine', 'qcom,ipcc', 'qcom,kpss-gcc', 'qcom,kpss-timer', 'qcom,kpss-wdt', 'qcom,mdp5', 'qcom,mdss-dsi-ctrl', 'qcom,msm-iommu-v1', 'qcom,msm-iommu-v2', 'qcom,msm-timer', 'qcom,osm-l3', 'qcom,pcie2-phy', 'qcom,pdc', 'qcom,pmic-glink', 'qcom,qce', 'qcom,qfprom', 'qcom,qspi-v1', 'qcom,qusb2-v2-phy', 'qcom,rpm-proc', 'qcom,rpmh-rsc', 'qcom,rpmcc', 'qcom,saw2', 'qcom,scm', 'qcom,sdhci-msm-v4', 'qcom,sdhci-msm-v5', 'qcom,sec-qfprom', 'qcom,smd-rpm', 'qcom,smmu-500', 'qcom,smmu-v2', 'qcom,snps-dwc3', 'qcom,ssc-block-bus', 'qcom,tcsr-mutex', 'qcom,trng', 'qcom,tsens-v0_1', 'qcom,tsens-v1', 'qcom,tsens-v2', 'qcom,ufshc', 'qcom,usb-hs-phy', 'qcom,usb-snps-hs-5nm-phy', 'qcom,usb-snps-hs-7nm-phy', 'simple-
mfd', 'snps,dwmac', 'syscon']
from schema $id: http://devicetree.org/schemas/arm/qcom-soc.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/20260519-dt-bindings-qcom-soc-naming-v1-3-005d29d261ae@oss.qualcomm.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] dt-bindings: arm: qcom-soc: Document more of existing legacy style compatibles
2026-05-19 20:03 ` [PATCH 2/3] dt-bindings: arm: qcom-soc: Document more of existing legacy style compatibles Krzysztof Kozlowski
@ 2026-05-20 10:04 ` Konrad Dybcio
2026-05-20 10:55 ` Krzysztof Kozlowski
0 siblings, 1 reply; 10+ messages in thread
From: Konrad Dybcio @ 2026-05-20 10:04 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 5/19/26 10:03 PM, Krzysztof Kozlowski wrote:
> The schema misses several old style compatibles with SoC component
> trailing in the compatible (qcom,IP-SoC):
> - qcom,apss-wdt-x1e80100
> - qcom,apss-wdt-xxx and qcom,scm-xxx for SoC with code names
> - qcom,kpss-gcc-xxx
> - qcom,rpmcc-xxx
> - qcom,tcsr-xxx
> - qcom,usb-hs-phy-xxx
>
> It also missed qcom,ipq806x-ahci.
>
> None of these were flagged by schema, because they were used with
> fallbacks and the schema checks only for single compatibles.
> Nevertheless document them for complete picture and for future change,
> which will apply the schema to fallbacks as well.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> Documentation/devicetree/bindings/arm/qcom-soc.yaml | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> index b5f3a750cce8..d7d64e0e146b 100644
> --- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> @@ -40,12 +40,20 @@ properties:
>
> # Legacy namings - variations of existing patterns/compatibles are OK,
> # but do not add completely new entries to these:
> - - pattern: "^qcom,[ak]pss-wdt-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$"
> + - pattern: "^qcom,[ak]pss-wdt-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
There's also x1(no letter)26100 and the new x2 ones, so perhaps
x[12][ep]?
Konrad
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] dt-bindings: arm: qcoms-c: Include Eliza, Kaanapali and others in SoC names
2026-05-19 20:03 ` [PATCH 1/3] dt-bindings: arm: qcoms-c: Include Eliza, Kaanapali and others in SoC names Krzysztof Kozlowski
@ 2026-05-20 10:05 ` Konrad Dybcio
2026-05-20 10:53 ` Krzysztof Kozlowski
0 siblings, 1 reply; 10+ messages in thread
From: Konrad Dybcio @ 2026-05-20 10:05 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 5/19/26 10:03 PM, Krzysztof Kozlowski wrote:
> Grow the schema checking for proper SoC compatible naming style with
> recently upstreamed new Qualcomm SoCs: Eliza, Kaanapali, Hawi, Mahua and
> Shikra.
>
> Since switching from model numbers to codenames, this list with explicit
> codenames will have to grow and list them all in order for the schema to
> work. It feels like a churn, but the compatible naming is still mess,
> for example, the schema pci/qcom,pcie-x1e80100.yaml with a legacy naming
> vendor,IP-SoC (qcom,pcie-x1e80100) received a new compatible with new
> style (qcom,glymur-pcie).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> Documentation/devicetree/bindings/arm/qcom-soc.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> index 27261039d56f..b5f3a750cce8 100644
> --- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> @@ -25,7 +25,7 @@ select:
> compatible:
> oneOf:
> - pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
> - - pattern: "^qcom,.*(glymur|milos).*$"
> + - pattern: "^qcom,.*(eliza|kaanapali|glymur|hawi|mahua|milos|shikra).*$"
+nord
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/3] dt-bindings: arm: qcom-soc: Improve validation of expected SoC naming
2026-05-19 20:03 [PATCH 0/3] dt-bindings: arm: qcom-soc: Improve validation of expected SoC naming Krzysztof Kozlowski
` (2 preceding siblings ...)
2026-05-19 20:03 ` [PATCH 3/3] dt-bindings: arm: qcom-soc: Validate nodes with fallbacks Krzysztof Kozlowski
@ 2026-05-20 10:05 ` Konrad Dybcio
3 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2026-05-20 10:05 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 5/19/26 10:03 PM, Krzysztof Kozlowski wrote:
> The schema checking for expected naming patterns for SoC IP block nodes
> was really incomplete and was checking only nodes with single
> compatible. Improve that because questions about expected compatibles
> still appear, e.g. we have
> Documentation/devicetree/bindings/pci/qcom,pcie-x1e80100.yaml with:
>
> - qcom,pcie-x1e80100 (expected old legacy style)
> - qcom,glymur-pcie (change to new style, ok fine, let's switch to new
> style... but...)
>
> I am afraid that a new SoC will revert that back to old style, e.g.:
> qcom,pcie-whatever-new-soc
>
> Best regards,
> Krzysztof
>
> ---
> Krzysztof Kozlowski (3):
> dt-bindings: arm: qcoms-c: Include Eliza, Kaanapali and others in SoC names
^^^ typo
Konrad
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] dt-bindings: arm: qcoms-c: Include Eliza, Kaanapali and others in SoC names
2026-05-20 10:05 ` Konrad Dybcio
@ 2026-05-20 10:53 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-20 10:53 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
On Wed, May 20, 2026 at 12:05:08PM +0200, Konrad Dybcio wrote:
> On 5/19/26 10:03 PM, Krzysztof Kozlowski wrote:
> > Grow the schema checking for proper SoC compatible naming style with
> > recently upstreamed new Qualcomm SoCs: Eliza, Kaanapali, Hawi, Mahua and
> > Shikra.
> >
> > Since switching from model numbers to codenames, this list with explicit
> > codenames will have to grow and list them all in order for the schema to
> > work. It feels like a churn, but the compatible naming is still mess,
> > for example, the schema pci/qcom,pcie-x1e80100.yaml with a legacy naming
> > vendor,IP-SoC (qcom,pcie-x1e80100) received a new compatible with new
> > style (qcom,glymur-pcie).
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > ---
> > Documentation/devicetree/bindings/arm/qcom-soc.yaml | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> > index 27261039d56f..b5f3a750cce8 100644
> > --- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> > +++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> > @@ -25,7 +25,7 @@ select:
> > compatible:
> > oneOf:
> > - pattern: "^qcom,.*(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sar|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
> > - - pattern: "^qcom,.*(glymur|milos).*$"
> > + - pattern: "^qcom,.*(eliza|kaanapali|glymur|hawi|mahua|milos|shikra).*$"
>
> +nord
True, ack.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] dt-bindings: arm: qcom-soc: Document more of existing legacy style compatibles
2026-05-20 10:04 ` Konrad Dybcio
@ 2026-05-20 10:55 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-20 10:55 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
On Wed, May 20, 2026 at 12:04:40PM +0200, Konrad Dybcio wrote:
> On 5/19/26 10:03 PM, Krzysztof Kozlowski wrote:
> > The schema misses several old style compatibles with SoC component
> > trailing in the compatible (qcom,IP-SoC):
> > - qcom,apss-wdt-x1e80100
> > - qcom,apss-wdt-xxx and qcom,scm-xxx for SoC with code names
> > - qcom,kpss-gcc-xxx
> > - qcom,rpmcc-xxx
> > - qcom,tcsr-xxx
> > - qcom,usb-hs-phy-xxx
> >
> > It also missed qcom,ipq806x-ahci.
> >
> > None of these were flagged by schema, because they were used with
> > fallbacks and the schema checks only for single compatibles.
> > Nevertheless document them for complete picture and for future change,
> > which will apply the schema to fallbacks as well.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > ---
> > Documentation/devicetree/bindings/arm/qcom-soc.yaml | 13 +++++++++++--
> > 1 file changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> > index b5f3a750cce8..d7d64e0e146b 100644
> > --- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> > +++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> > @@ -40,12 +40,20 @@ properties:
> >
> > # Legacy namings - variations of existing patterns/compatibles are OK,
> > # but do not add completely new entries to these:
> > - - pattern: "^qcom,[ak]pss-wdt-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$"
> > + - pattern: "^qcom,[ak]pss-wdt-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+.*$"
>
> There's also x1(no letter)26100 and the new x2 ones, so perhaps
x126100 is not yet sent to mailing lists. We document what we use.
Similar for x2.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2026-05-20 10:55 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-19 20:03 [PATCH 0/3] dt-bindings: arm: qcom-soc: Improve validation of expected SoC naming Krzysztof Kozlowski
2026-05-19 20:03 ` [PATCH 1/3] dt-bindings: arm: qcoms-c: Include Eliza, Kaanapali and others in SoC names Krzysztof Kozlowski
2026-05-20 10:05 ` Konrad Dybcio
2026-05-20 10:53 ` Krzysztof Kozlowski
2026-05-19 20:03 ` [PATCH 2/3] dt-bindings: arm: qcom-soc: Document more of existing legacy style compatibles Krzysztof Kozlowski
2026-05-20 10:04 ` Konrad Dybcio
2026-05-20 10:55 ` Krzysztof Kozlowski
2026-05-19 20:03 ` [PATCH 3/3] dt-bindings: arm: qcom-soc: Validate nodes with fallbacks Krzysztof Kozlowski
2026-05-19 23:56 ` Rob Herring (Arm)
2026-05-20 10:05 ` [PATCH 0/3] dt-bindings: arm: qcom-soc: Improve validation of expected SoC naming Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®