From: Reinette Chatre <reinette.chatre@intel.com>
To: Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghuay@nvidia.com>,
"Maciej Wieczor-Retman" <maciej.wieczor-retman@intel.com>,
Peter Newman <peternewman@google.com>,
James Morse <james.morse@arm.com>,
Babu Moger <babu.moger@amd.com>,
Drew Fustini <dfustini@baylibre.com>,
Dave Martin <Dave.Martin@arm.com>, Chen Yu <yu.c.chen@intel.com>,
David E Box <david.e.box@intel.com>, <x86@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
<linux-kernel@vger.kernel.org>, <patches@lists.linux.dev>,
"Borislav Petkov (AMD)" <bp@alien8.de>
Subject: Re: [PATCH v12 05/25] x86/resctrl: Delete resctrl_cpu_detect()
Date: Thu, 24 Sep 2026 08:21:29 -0700 [thread overview]
Message-ID: <df261239-7197-4abf-b203-1a81b345e7ab@intel.com> (raw)
In-Reply-To: <20260916231320.14502-6-tony.luck@intel.com>
Hi Tony,
On 9/16/26 4:13 PM, Tony Luck wrote:
> cpuinfo_x86::x86_cache_{max_rmid,occ_scale,mbm_width_offset} are no
> longer used.
>
> Delete resctrl_cpu_detect() and the fields from struct cpuinfo_x86.
Even though Boris already acked it I do think this can be improved to not
just describe the code in the patch, connecting it with the cleanup work,
and highlighting the benefit of removing resctrl from generic early CPU setup.
Something like:
x86/resctrl: Delete resctrl_cpu_detect()
resctrl now enumerates its monitoring properties itself, leaving
cpuinfo_x86::x86_cache_{max_rmid,occ_scale,mbm_width_offset} without any
consumers. These resctrl specific fields are populated from the vendor
CPU identification paths, unnecessarily placing resctrl details in
generic x86 CPU setup.
Delete the unused fields together with the code that populates them,
removing resctrl from early CPU identification.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> Acked-by: Borislav Petkov (AMD) <bp@alien8.de>
> ---
Patch looks good.
Reinette
next prev parent reply other threads:[~2026-09-24 15:21 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 23:12 [PATCH v12 00/25] Allow AET to use PMT as loadable module Tony Luck
2026-09-16 23:12 ` [PATCH v12 01/25] x86/cpufeatures: Add missing CQM feature dependency Tony Luck
2026-09-24 15:12 ` Reinette Chatre
2026-09-16 23:12 ` [PATCH v12 02/25] x86/resctrl: Check if monitoring features are supported Tony Luck
2026-09-24 15:13 ` Reinette Chatre
2026-09-16 23:12 ` [PATCH v12 03/25] x86/resctrl: Enumerate monitor features in rdt_get_l3_mon_config() Tony Luck
2026-09-24 15:15 ` Reinette Chatre
2026-09-16 23:12 ` [PATCH v12 04/25] x86/resctrl: Apply Intel MBM quirk from rdt_get_l3_mon_config() Tony Luck
2026-09-21 17:45 ` Babu Moger
2026-09-22 20:46 ` Luck, Tony
2026-09-24 15:23 ` Reinette Chatre
2026-09-24 15:17 ` Reinette Chatre
2026-09-16 23:13 ` [PATCH v12 05/25] x86/resctrl: Delete resctrl_cpu_detect() Tony Luck
2026-09-24 15:21 ` Reinette Chatre [this message]
2026-09-16 23:13 ` [PATCH v12 06/25] arm,x86,fs/resctrl: Replace architecture resctrl_arch_{alloc,mon}_capable() Tony Luck
2026-09-24 15:22 ` Reinette Chatre
2026-09-16 23:13 ` [PATCH v12 07/25] x86/resctrl: Update special case for Intel Haswell enumeration Tony Luck
2026-09-24 15:27 ` Reinette Chatre
2026-09-16 23:13 ` [PATCH v12 08/25] x86/resctrl: Delete rdt_alloc_capable and rdt_mon_capable Tony Luck
2026-09-24 15:28 ` Reinette Chatre
2026-09-16 23:13 ` [PATCH v12 09/25] fs/resctrl: Remove redundant calls to resctrl_{alloc,mon}_capable() Tony Luck
2026-09-21 17:45 ` Babu Moger
2026-09-22 20:33 ` Luck, Tony
2026-09-24 15:30 ` Reinette Chatre
2026-09-16 23:13 ` [PATCH v12 10/25] x86/resctrl: Honor rdt=perf option to force enable AET perf events Tony Luck
2026-09-24 15:29 ` Reinette Chatre
2026-09-16 23:13 ` [PATCH v12 11/25] fs/resctrl: Add interface to disable a monitor event Tony Luck
2026-09-24 15:31 ` Reinette Chatre
2026-09-16 23:13 ` [PATCH v12 12/25] arm,x86,fs/resctrl: Allocate maximum needed rmid_ptrs[] Tony Luck
2026-09-21 17:45 ` Babu Moger
2026-09-22 0:30 ` Reinette Chatre
2026-09-22 13:09 ` Babu Moger
2026-09-24 15:37 ` Reinette Chatre
2026-09-16 23:13 ` [PATCH v12 13/25] arm,x86,fs/resctrl: Allocate right size for L3 monitor arrays Tony Luck
2026-09-24 20:30 ` Reinette Chatre
2026-09-16 23:13 ` [PATCH v12 14/25] fs/resctrl: Rebuild free RMID list on each mount Tony Luck
2026-09-21 17:45 ` Babu Moger
2026-09-22 20:30 ` Luck, Tony
2026-09-22 22:58 ` Moger, Babu
2026-09-22 23:07 ` Luck, Tony
2026-09-23 13:21 ` Moger, Babu
2026-09-16 23:13 ` [PATCH v12 15/25] x86,fs/resctrl: Handle systems where AET is the only resource Tony Luck
2026-09-24 20:41 ` Reinette Chatre
2026-09-16 23:13 ` [PATCH v12 16/25] x86/resctrl: Add PMT registration API for AET enumeration callbacks Tony Luck
2026-09-24 20:43 ` Reinette Chatre
2026-09-16 23:13 ` [PATCH v12 17/25] platform/x86/intel/pmt: Register enumeration functions with resctrl Tony Luck
2026-09-24 20:46 ` Reinette Chatre
2026-09-16 23:13 ` [PATCH v12 18/25] x86/resctrl: Use registered function pointers for AET enumeration Tony Luck
2026-09-24 20:49 ` Reinette Chatre
2026-09-16 23:13 ` [PATCH v12 19/25] arm,x86,fs/resctrl: Enumerate AET on every resctrl mount Tony Luck
2026-09-24 20:53 ` Reinette Chatre
2026-09-16 23:13 ` [PATCH v12 20/25] x86/resctrl: Enforce system RMID limit on AET Tony Luck
2026-09-24 20:55 ` Reinette Chatre
2026-09-16 23:13 ` [PATCH v12 21/25] x86/resctrl: Export interface to report telemetry unbind/remove Tony Luck
2026-09-16 23:13 ` [PATCH v12 22/25] platform/x86/intel/pmt: Inform resctrl when MMIO maps are being removed Tony Luck
2026-09-18 16:29 ` [PATCH 12 22/25 UPDATED] " Tony Luck
2026-09-24 20:55 ` Reinette Chatre
2026-09-16 23:13 ` [PATCH v12 23/25] x86/resctrl: Require 64-bit x86 for resctrl support Tony Luck
2026-09-24 20:57 ` Reinette Chatre
2026-09-16 23:13 ` [PATCH v12 24/25] x86/resctrl: Simplify Kconfig options for resctrl Tony Luck
2026-09-24 20:59 ` Reinette Chatre
2026-09-16 23:13 ` [PATCH v12 25/25] x86,fs/resctrl: Document telemetry mount timing caveat Tony Luck
2026-09-24 21:00 ` Reinette Chatre
2026-09-17 16:32 ` [PATCH v12 00/25] Allow AET to use PMT as loadable module Luck, Tony
2026-09-17 21:23 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df261239-7197-4abf-b203-1a81b345e7ab@intel.com \
--to=reinette.chatre@intel.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=david.e.box@intel.com \
--cc=dfustini@baylibre.com \
--cc=fenghuay@nvidia.com \
--cc=hch@infradead.org \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=patches@lists.linux.dev \
--cc=peternewman@google.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®