Re: [PATCH net v2 2/3] net: phy: allow drivers to disable polling via get_next_update_time()

[Andrew Lunn <andrew@lunn.ch>]

>  	/* Only re-schedule a PHY state machine change if we are polling the
> -	 * PHY, if PHY_MAC_INTERRUPT is set, then we will be moving
> -	 * between states from phy_mac_interrupt().
> +	 * PHY. If PHY_MAC_INTERRUPT is set or get_next_update_time() returns
> +	 * PHY_STATE_IRQ, then we rely on interrupts for state changes.
>  	 *
>  	 * In state PHY_HALTED the PHY gets suspended, so rescheduling the
>  	 * state machine would be pointless and possibly error prone when
>  	 * called from phy_disconnect() synchronously.
>  	 */
> -	if (phy_polling_mode(phydev) && phy_is_started(phydev))
> -		phy_queue_state_machine(phydev,
> -					phy_get_next_update_time(phydev));
> +	if (phy_polling_mode(phydev) && phy_is_started(phydev)) {
> +		unsigned int next_time = phy_get_next_update_time(phydev);
> +
> +		/* Drivers returning PHY_STATE_IRQ opt out of polling.
> +		 * Use IRQ-only mode by not re-queuing the state machine.
> +		 */
> +		if (next_time != PHY_STATE_IRQ)
> +			phy_queue_state_machine(phydev, next_time);
> +	}

How does this interact with update_stats()?

phy_polling_mode() returns true because the update_stats() op is
implemented. phy_get_next_update_time() returns PHY_STATE_IRQ, because
the PHY is in a state where interrupts works, and then the statistics
overflow.

It seems like this code needs to be somehow made part of
phy_polling_mode(), so that it has the full picture of why polling is
being used.

    Andrew

---
pw-bot: cr