From: "J, KEERTHY" <j-keerthy@ti.com>
To: "Kumar, Udit" <u-kumar1@ti.com>, <robh+dt@kernel.org>,
<nm@ti.com>, <vigneshr@ti.com>, <conor+dt@kernel.org>,
<kristo@kernel.org>, <rzysztof.kozlowski+dt@linaro.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/7] arm64: dts: ti: k3-j784s4-main: Add the main domain watchdog instances
Date: Thu, 7 Sep 2023 20:00:16 +0530 [thread overview]
Message-ID: <e0b6ddeb-7129-d76f-0584-112d79e3a1fb@ti.com> (raw)
In-Reply-To: <19f9895f-0975-713e-f2eb-fd5e16d6fb98@ti.com>
WARNING: multiple messages have this Message-ID
From: "J, KEERTHY" <j-keerthy@ti.com>
To: "Kumar, Udit" <u-kumar1@ti.com>, <robh+dt@kernel.org>,
<nm@ti.com>, <vigneshr@ti.com>, <conor+dt@kernel.org>,
<kristo@kernel.org>, <rzysztof.kozlowski+dt@linaro.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/7] arm64: dts: ti: k3-j784s4-main: Add the main domain watchdog instances
Date: Thu, 7 Sep 2023 20:00:16 +0530 [thread overview]
Message-ID: <e0b6ddeb-7129-d76f-0584-112d79e3a1fb@ti.com> (raw)
Message-ID: <20230907143016.0dy1-u1NoGwUpkwFB5rT4z3EtK5ZRgQqFgCMdFV3PKw@z> (raw)
In-Reply-To: <19f9895f-0975-713e-f2eb-fd5e16d6fb98@ti.com>
On 9/7/2023 7:44 PM, Kumar, Udit wrote:
> Thanks Keerthy,
>
> On 9/7/2023 5:22 PM, Keerthy wrote:
>> There are totally 19 instances of watchdog module. One each for the
>> 8 A72 cores, one each for the 4 C7x cores, 1 for the GPU, 1 each
>> for the 6 R5F cores in the main domain. Keeping only the A72 instances
>> enabled and disabling the rest by default.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 182 +++++++++++++++++++++
>> 1 file changed, 182 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
>> b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
>> index 7f7eab348520..66ab947a1081 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
>> @@ -1574,4 +1574,186 @@
>> reg = <0x00 0x700000 0x00 0x1000>;
>> ti,esm-pins = <688>, <689>;
>> };
>> +
>> + watchdog0: watchdog@2200000 {
>> + compatible = "ti,j7-rti-wdt";
>> + reg = <0x00 0x2200000 0x00 0x100>;
>> + clocks = <&k3_clks 348 1>;
>> + power-domains = <&k3_pds 348 TI_SCI_PD_EXCLUSIVE>;
>> + assigned-clocks = <&k3_clks 348 0>;
>> + assigned-clock-parents = <&k3_clks 348 4>;
>> + };
>
> In ESM, patch I see only output of 2 watchdog in cascaded for reset.
>
> if you want to keep enable other wdt, then IMO they should be able to
> reset the core/SOC
>
> on timeout
I can add the other ESM events to the ESM node to enable that. I will
wait if there are more comments. If this is the only one comment i will
post a v3 of the esm patch.
- Keerthy
>
>
>> +
>> + [..]};
next prev parent reply other threads:[~2023-09-07 16:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 11:52 [PATCH v2 0/7]arm64: ti: k3-j7: Add the ESM & main domain watchdog nodes Keerthy
2023-09-07 11:52 ` [PATCH v2 1/7] arm64: dts: ti: k3-j721s2: Add ESM instances Keerthy
2023-09-07 11:52 ` [PATCH v2 2/7] arm64: dts: ti: k3-j784s4: " Keerthy
2023-09-07 11:52 ` [PATCH v2 3/7] arm64: dts: ti: k3-j7200: Add MCU domain ESM instance Keerthy
2023-09-07 11:52 ` [PATCH v2 4/7] arm64: dts: ti: k3-j784s4-main: Add the main domain watchdog instances Keerthy
2023-09-07 14:14 ` Kumar, Udit
2023-09-07 14:14 ` Kumar, Udit
2023-09-07 14:30 ` J, KEERTHY [this message]
2023-09-07 14:30 ` J, KEERTHY
2023-09-07 11:52 ` [PATCH v2 5/7] arm64: dts: ti: k3-j784s4-mcu: " Keerthy
2023-09-07 11:52 ` [PATCH v2 6/7] arm64: dts: ti: k3-j721s2-main: " Keerthy
2023-09-07 11:52 ` [PATCH v2 7/7] arm64: dts: ti: k3-j721s2-mcu: " Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0b6ddeb-7129-d76f-0584-112d79e3a1fb@ti.com \
--to=j-keerthy@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=rzysztof.kozlowski+dt@linaro.org \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®