* [PATCH] arm64: dts: qcom: qcs615-ride: remove redundant gpio header file
@ 2025-07-23 8:43 yuanjie yang
2025-07-23 8:49 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: yuanjie yang @ 2025-07-23 8:43 UTC (permalink / raw)
To: andersson, konradybcio, robh, krzk+dt, conor+dt
Cc: linux-arm-msm, devicetree, linux-kernel, quic_tingweiz,
quic_yuanjiey, kernel
From: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>
Remove redundant gpio header file in QCS615 RIDE DTS.
Signed-off-by: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/qcs615-ride.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
index fdad6388f6f7..55b9a62cafae 100644
--- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts
@@ -6,7 +6,6 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
-#include <dt-bindings/gpio/gpio.h>
#include "sm6150.dtsi"
#include "pm8150.dtsi"
/ {
base-commit: a933d3dc1968fcfb0ab72879ec304b1971ed1b9a
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: qcs615-ride: remove redundant gpio header file
2025-07-23 8:43 [PATCH] arm64: dts: qcom: qcs615-ride: remove redundant gpio header file yuanjie yang
@ 2025-07-23 8:49 ` Krzysztof Kozlowski
2025-07-23 8:55 ` yuanjiey
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-23 8:49 UTC (permalink / raw)
To: yuanjie yang, andersson, konradybcio, robh, krzk+dt, conor+dt
Cc: linux-arm-msm, devicetree, linux-kernel, quic_tingweiz,
quic_yuanjiey, kernel
On 23/07/2025 10:43, yuanjie yang wrote:
> From: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>
>
> Remove redundant gpio header file in QCS615 RIDE DTS.
I do not see it redundant at all. Just look at the file - it is used.
Otherwise provide arguments WHY you claim this is redundant.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcs615-ride: remove redundant gpio header file
2025-07-23 8:49 ` Krzysztof Kozlowski
@ 2025-07-23 8:55 ` yuanjiey
2025-07-23 8:59 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: yuanjiey @ 2025-07-23 8:55 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, linux-arm-msm,
devicetree, linux-kernel, quic_tingweiz, quic_yuanjiey, kernel
On Wed, Jul 23, 2025 at 10:49:10AM +0200, Krzysztof Kozlowski wrote:
> On 23/07/2025 10:43, yuanjie yang wrote:
> > From: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>
> >
> > Remove redundant gpio header file in QCS615 RIDE DTS.
>
> I do not see it redundant at all. Just look at the file - it is used.
qcs615-ride.dts: file
line:
7:#include <dt-bindings/gpio/gpio.h>
8:#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
9:#include <dt-bindings/gpio/gpio.h>
I see line 7 and line 9 include the same <dt-bindings/gpio/gpio.h>,
I think we can remove one header file.
> Otherwise provide arguments WHY you claim this is redundant.
>
> Best regards,
> Krzysztof
Thanks,
Yuanjie
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcs615-ride: remove redundant gpio header file
2025-07-23 8:55 ` yuanjiey
@ 2025-07-23 8:59 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-23 8:59 UTC (permalink / raw)
To: yuanjiey
Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, linux-arm-msm,
devicetree, linux-kernel, quic_tingweiz, quic_yuanjiey, kernel
On 23/07/2025 10:55, yuanjiey wrote:
> On Wed, Jul 23, 2025 at 10:49:10AM +0200, Krzysztof Kozlowski wrote:
>> On 23/07/2025 10:43, yuanjie yang wrote:
>>> From: Yuanjie Yang <yuanjie.yang@oss.qualcomm.com>
>>>
>>> Remove redundant gpio header file in QCS615 RIDE DTS.
>>
>> I do not see it redundant at all. Just look at the file - it is used.
> qcs615-ride.dts: file
>
> line:
> 7:#include <dt-bindings/gpio/gpio.h>
> 8:#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> 9:#include <dt-bindings/gpio/gpio.h>
>
> I see line 7 and line 9 include the same <dt-bindings/gpio/gpio.h>,
> I think we can remove one header file.
>
So say that it is there twice...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-23 8:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-23 8:43 [PATCH] arm64: dts: qcom: qcs615-ride: remove redundant gpio header file yuanjie yang
2025-07-23 8:49 ` Krzysztof Kozlowski
2025-07-23 8:55 ` yuanjiey
2025-07-23 8:59 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®