From: John Garry <john.garry@huawei.com>
To: Hanjun Guo <guohanjun@huawei.com>, <jejb@linux.vnet.ibm.com>,
<martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Hanjun Guo <hanjun.guo@linaro.org>, <aaron.lu@intel.com>
Subject: Re: [PATCH] scsi: remove useless acpi functions in the head file
Date: Tue, 10 Jan 2017 11:44:40 +0000 [thread overview]
Message-ID: <e1478c4b-28eb-a10b-f359-eab1f822271d@huawei.com> (raw)
In-Reply-To: <1484036044-9514-1-git-send-email-guohanjun@huawei.com>
On 10/01/2017 08:14, Hanjun Guo wrote:
> From: Hanjun Guo <hanjun.guo@linaro.org>
>
> commit f1bc1e4c44b1 ("ata: acpi: rework the ata acpi bind support")
> removed scsi_register_acpi_bus_type() and scsi_unregister_acpi_bus_type(),
> but forgot to remove them in the head file, do it now.
>
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> ---
> include/scsi/scsi.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h
> index 8ec7c30..a1e1930 100644
> --- a/include/scsi/scsi.h
> +++ b/include/scsi/scsi.h
> @@ -29,16 +29,6 @@ enum scsi_timeouts {
> */
> #define SCAN_WILD_CARD ~0
>
> -#ifdef CONFIG_ACPI
> -struct acpi_bus_type;
> -
> -extern int
> -scsi_register_acpi_bus_type(struct acpi_bus_type *bus);
> -
> -extern void
> -scsi_unregister_acpi_bus_type(struct acpi_bus_type *bus);
> -#endif
> -
> /** scsi_status_is_good - check the status return.
> *
> * @status: the status passed up from the driver (including host and
>
Looks ok,
Reviewed-by: John Garry <john.garry@huawei.com>
next prev parent reply other threads:[~2017-01-10 11:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 8:14 Hanjun Guo
2017-01-10 11:44 ` John Garry [this message]
2017-01-11 1:50 ` Aaron Lu
2017-01-11 2:15 ` Hanjun Guo
2017-01-11 2:30 ` Aaron Lu
2017-01-10 11:51 ` Johannes Thumshirn
2017-01-10 12:17 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1478c4b-28eb-a10b-f359-eab1f822271d@huawei.com \
--to=john.garry@huawei.com \
--cc=aaron.lu@intel.com \
--cc=guohanjun@huawei.com \
--cc=hanjun.guo@linaro.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®