mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aaron Lu <aaron.lu@intel.com>
To: Hanjun Guo <guohanjun@huawei.com>
Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
	John Garry <john.garry@huawei.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hanjun Guo <hanjun.guo@linaro.org>
Subject: Re: [PATCH] scsi: remove useless acpi functions in the head file
Date: Wed, 11 Jan 2017 10:30:15 +0800	[thread overview]
Message-ID: <fa9e93f8-157e-b012-0e30-c621c505cc99@intel.com> (raw)
In-Reply-To: <58759557.7060405@huawei.com>

On 01/11/2017 10:15 AM, Hanjun Guo wrote:
> On 2017/1/11 9:50, Aaron Lu wrote:
>> On 01/10/2017 07:44 PM, John Garry wrote:
>>> On 10/01/2017 08:14, Hanjun Guo wrote:
>>>> From: Hanjun Guo <hanjun.guo@linaro.org>
>>>>
>>>> commit f1bc1e4c44b1 ("ata: acpi: rework the ata acpi bind support")
>>>> removed scsi_register_acpi_bus_type() and scsi_unregister_acpi_bus_type(),
>>>> but forgot to remove them in the head file, do it now.
>>>>
>>>> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
>> Reviewed-by: Aaron Lu <aaron.lu@intel.com>
>>
>> Just out of curiosity, did you find this by some tool? If so, can you
>> please let me know the tool name so that I can avoid such problems in
>> the future? Thanks.
> 
> No, not found by tool. I was working on a patch set which tried to
> introduce a new acpi bus type [1], so I greped the usage of
> "struct acpi_bus_type" then found this issue :)

I see, thanks for the cleanup.

Regards,
Aaron

  reply	other threads:[~2017-01-11  2:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10  8:14 Hanjun Guo
2017-01-10 11:44 ` John Garry
2017-01-11  1:50   ` Aaron Lu
2017-01-11  2:15     ` Hanjun Guo
2017-01-11  2:30       ` Aaron Lu [this message]
2017-01-10 11:51 ` Johannes Thumshirn
2017-01-10 12:17   ` Hanjun Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa9e93f8-157e-b012-0e30-c621c505cc99@intel.com \
    --to=aaron.lu@intel.com \
    --cc=guohanjun@huawei.com \
    --cc=hanjun.guo@linaro.org \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=john.garry@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®