From: Rustam Adilov <adilov@disroot.org>
To: Linus Walleij <linusw@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
Bartosz Golaszewski <brgl@kernel.org>,
Sander Vanheule <sander@svanheule.net>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] gpio: realtek-otto: make the driver work with SWAP_IO_SPACE
Date: Sat, 10 Oct 2026 14:18:37 +0000 [thread overview]
Message-ID: <e1c0f3ff0c47fc7a2258bbb67f588f57@disroot.org> (raw)
In-Reply-To: <CAD++jLk8gCAy+SbGffttCQ7dM9x6gzVRBwRppCByzwYdm_5kGw@mail.gmail.com>
On 2026-10-01 20:14, Linus Walleij wrote:
> On Mon, Sep 28, 2026 at 11:51 AM Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
>> On Sat, Aug 15, 2026 at 02:44:49PM +0500, Rustam Adilov wrote:
>> > This patch series changes gpio-realtek-otto to be functional around
>> > SWAP_IO_SPACE config.
> (...)
>> Convert the driver to use regmap MMIO and most of the code in this series won't
>> be needed. Also it will give some benefits (like register caching and debugfs
>> monitoring).
>
> Andy is right.
>
> Make an attempt on top of the merged patches to convert this to regmap MMIO
> and see what happens, and if that works consider regmap GPIO as
> well.
>
> Everyone will be happier, because less code.
As far as i remember, i thought of using regmap earlier but got stuck because
the regmap has to not swap in realtek_gpio_update_line_imr() but potentially
swap in other places by bank_read/write.
Maybe i am missing something but i just couldn't figure it out.
Best,
Rustam
next prev parent reply other threads:[~2026-10-10 14:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-15 9:44 Rustam Adilov
2026-08-15 9:44 ` [PATCH v2 1/2] gpio: realtek-otto: use __raw_readl/writel in realtek_gpio_update_line_imr() Rustam Adilov
2026-08-15 9:44 ` [PATCH v2 2/2] gpio: realtek-otto: make bank_read/write overridable by endian property Rustam Adilov
2026-09-01 15:55 ` [PATCH v2 0/2] gpio: realtek-otto: make the driver work with SWAP_IO_SPACE Bartosz Golaszewski
2026-09-28 9:51 ` Andy Shevchenko
2026-10-01 20:14 ` Linus Walleij
2026-10-10 14:18 ` Rustam Adilov [this message]
2026-10-11 20:22 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1c0f3ff0c47fc7a2258bbb67f588f57@disroot.org \
--to=adilov@disroot.org \
--cc=andriy.shevchenko@intel.com \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sander@svanheule.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®