mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sekhar Nori <nsekhar@ti.com>
To: David Lechner <david@lechnology.com>,
	<linux-arm-kernel@lists.infradead.org>
Cc: Kevin Hilman <khilman@kernel.org>, Adam Ford <aford173@gmail.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 6/7] ARM: davinci: convert to common clock framework
Date: Thu, 4 Jan 2018 18:09:31 +0530	[thread overview]
Message-ID: <e36250ba-3f76-71d9-206f-475738d19e36@ti.com> (raw)
In-Reply-To: <1514763588-31560-7-git-send-email-david@lechnology.com>

On Monday 01 January 2018 05:09 AM, David Lechner wrote:
> This converts all of arch/arm/mach-davinci to the common clock framework.
> The clock drivers from clock.c and psc.c have been moved to drivers/clk,
> so these files are removed.
> 
> There is one subtle change in the clock trees. AUX, BPDIV and OSCDIV
> clocks now have "ref_clk" as a parent instead of the PLL clock. These
> clocks are part of the PLL's MMIO block, but they bypass the PLL and
> therefore it makes more sense to have "ref_clk" as their parent since
> "ref_clk" is the input clock of the PLL.
> 
> CONFIG_DAVINCI_RESET_CLOCKS is removed since the common clock frameworks
> takes care of disabling unused clocks.
> 
> Known issue: This breaks CPU frequency scaling on da850.

This functionality needs to be restored as part of this series since we
cannot commit anything with regressions.

> 
> Also, the order of #includes are cleaned up in files while we are touching
> this code.
> 
> Signed-off-by: David Lechner <david@lechnology.com>

This is a pretty huge patch again and I hope it can be broken down.
Ideally one per SoC converted and then the unused code removal.

Thanks,
Sekhar

  reply	other threads:[~2018-01-04 12:40 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-31 23:39 [PATCH v4 0/7] ARM: davinci: convert to common clock framework​ David Lechner
2017-12-31 23:39 ` [PATCH v4 1/7] ARM: davinci: move davinci_clk_init() to init_time David Lechner
2017-12-31 23:39 ` [PATCH v4 2/7] ARM: davinci: don't use static clk_lookup David Lechner
2018-01-04 11:10   ` Sekhar Nori
2018-01-04 17:43     ` David Lechner
2017-12-31 23:39 ` [PATCH v4 3/7] ARM: davinci: fix duplicate clocks David Lechner
2018-01-04 11:12   ` Sekhar Nori
2018-01-04 17:44     ` David Lechner
2017-12-31 23:39 ` [PATCH v4 4/7] ARM: davinci: remove davinci_set_refclk_rate() David Lechner
2017-12-31 23:39 ` [PATCH v4 5/7] clk: Introduce davinci clocks David Lechner
2018-01-01  0:23   ` David Lechner
2018-01-02 21:31   ` David Lechner
2018-01-04 12:28     ` Sekhar Nori
2018-01-04 17:46       ` David Lechner
2018-01-04 12:43   ` Sekhar Nori
2018-01-04 17:47     ` David Lechner
2017-12-31 23:39 ` [PATCH v4 6/7] ARM: davinci: convert to common clock framework David Lechner
2018-01-04 12:39   ` Sekhar Nori [this message]
2018-01-04 17:50     ` David Lechner
2018-01-04 19:26       ` Adam Ford
2018-01-04 21:22         ` David Lechner
2018-01-05  2:59       ` David Lechner
2018-01-05 10:42         ` Sekhar Nori
2018-01-06  1:42           ` David Lechner
2018-01-08  5:36             ` Sekhar Nori
2017-12-31 23:39 ` [PATCH v4 7/7] ARM: davinci_all_defconfig: remove CONFIG_DAVINCI_RESET_CLOCKS David Lechner
2018-01-02 15:10 ` [PATCH v4 0/7] ARM: davinci: convert to common clock framework​ Adam Ford
2018-01-02 17:10   ` David Lechner
2018-01-02 18:31     ` David Lechner
2018-01-03 16:57   ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e36250ba-3f76-71d9-206f-475738d19e36@ti.com \
    --to=nsekhar@ti.com \
    --cc=aford173@gmail.com \
    --cc=david@lechnology.com \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®