* [PATCH] dt-bindings: display: bridge: renesas,dw-hdmi: Fix 'unevaluatedProperties' warnings
@ 2022-08-29 21:58 Lad Prabhakar
2022-08-29 23:08 ` Laurent Pinchart
2022-08-30 9:23 ` Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: Lad Prabhakar @ 2022-08-29 21:58 UTC (permalink / raw)
To: Laurent Pinchart, Kieran Bingham, Andrzej Hajda, Neil Armstrong,
Robert Foss, Jonas Karlman, Jernej Skrabec, David Airlie,
Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Geert Uytterhoeven
Cc: dri-devel, devicetree, linux-renesas-soc, linux-kernel,
Prabhakar, Biju Das, Lad Prabhakar
With 'unevaluatedProperties' support implemented, there's a number of
warnings when running dtbs_check:
arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-rev2-ex-idk-1110wr.dtb: hdmi@fead0000: Unevaluated properties are not allowed ('resets' was unexpected)
From schema: Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml
The main problem is that SoC DTSI's are including resets property, whereas
the renesas,dw-hdmi.yaml has 'unevaluatedProperties: false'. So just add
optional resets property to the binding.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
.../devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml
index 0c9785c8db51..a7e44e249dd3 100644
--- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml
@@ -38,6 +38,9 @@ properties:
clock-names:
maxItems: 2
+ resets:
+ maxItems: 1
+
ports:
$ref: /schemas/graph.yaml#/properties/ports
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: display: bridge: renesas,dw-hdmi: Fix 'unevaluatedProperties' warnings
2022-08-29 21:58 [PATCH] dt-bindings: display: bridge: renesas,dw-hdmi: Fix 'unevaluatedProperties' warnings Lad Prabhakar
@ 2022-08-29 23:08 ` Laurent Pinchart
2022-08-30 9:18 ` Lad, Prabhakar
2022-08-30 9:23 ` Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: Laurent Pinchart @ 2022-08-29 23:08 UTC (permalink / raw)
To: Lad Prabhakar
Cc: Kieran Bingham, Andrzej Hajda, Neil Armstrong, Robert Foss,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Geert Uytterhoeven, dri-devel,
devicetree, linux-renesas-soc, linux-kernel, Prabhakar, Biju Das
Hi Prabhakar,
Thank you for the patch.
On Mon, Aug 29, 2022 at 10:58:16PM +0100, Lad Prabhakar wrote:
> With 'unevaluatedProperties' support implemented, there's a number of
> warnings when running dtbs_check:
>
> arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-rev2-ex-idk-1110wr.dtb: hdmi@fead0000: Unevaluated properties are not allowed ('resets' was unexpected)
> From schema: Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml
>
> The main problem is that SoC DTSI's are including resets property, whereas
> the renesas,dw-hdmi.yaml has 'unevaluatedProperties: false'. So just add
> optional resets property to the binding.
Given that all the DT sources in the kernel specify the resets property,
how about making it mandatory ?
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> .../devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml
> index 0c9785c8db51..a7e44e249dd3 100644
> --- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml
> @@ -38,6 +38,9 @@ properties:
> clock-names:
> maxItems: 2
>
> + resets:
> + maxItems: 1
> +
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: display: bridge: renesas,dw-hdmi: Fix 'unevaluatedProperties' warnings
2022-08-29 23:08 ` Laurent Pinchart
@ 2022-08-30 9:18 ` Lad, Prabhakar
0 siblings, 0 replies; 5+ messages in thread
From: Lad, Prabhakar @ 2022-08-30 9:18 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Lad Prabhakar, Kieran Bingham, Andrzej Hajda, Neil Armstrong,
Robert Foss, Jonas Karlman, Jernej Skrabec, David Airlie,
Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Geert Uytterhoeven, DRI Development,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas, LKML, Biju Das
Hi Laurent,
On Tue, Aug 30, 2022 at 12:08 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Prabhakar,
>
> Thank you for the patch.
>
> On Mon, Aug 29, 2022 at 10:58:16PM +0100, Lad Prabhakar wrote:
> > With 'unevaluatedProperties' support implemented, there's a number of
> > warnings when running dtbs_check:
> >
> > arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-rev2-ex-idk-1110wr.dtb: hdmi@fead0000: Unevaluated properties are not allowed ('resets' was unexpected)
> > From schema: Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml
> >
> > The main problem is that SoC DTSI's are including resets property, whereas
> > the renesas,dw-hdmi.yaml has 'unevaluatedProperties: false'. So just add
> > optional resets property to the binding.
>
> Given that all the DT sources in the kernel specify the resets property,
> how about making it mandatory ?
>
Agreed, will do that and send a v2.
Cheers,
Prabhakar
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: display: bridge: renesas,dw-hdmi: Fix 'unevaluatedProperties' warnings
2022-08-29 21:58 [PATCH] dt-bindings: display: bridge: renesas,dw-hdmi: Fix 'unevaluatedProperties' warnings Lad Prabhakar
2022-08-29 23:08 ` Laurent Pinchart
@ 2022-08-30 9:23 ` Krzysztof Kozlowski
2022-08-30 10:02 ` Lad, Prabhakar
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-30 9:23 UTC (permalink / raw)
To: Lad Prabhakar, Laurent Pinchart, Kieran Bingham, Andrzej Hajda,
Neil Armstrong, Robert Foss, Jonas Karlman, Jernej Skrabec,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Geert Uytterhoeven
Cc: dri-devel, devicetree, linux-renesas-soc, linux-kernel,
Prabhakar, Biju Das
On 30/08/2022 00:58, Lad Prabhakar wrote:
> With 'unevaluatedProperties' support implemented, there's a number of
> warnings when running dtbs_check:
>
> arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-rev2-ex-idk-1110wr.dtb: hdmi@fead0000: Unevaluated properties are not allowed ('resets' was unexpected)
> From schema: Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml
>
> The main problem is that SoC DTSI's are including resets property, whereas
> the renesas,dw-hdmi.yaml has 'unevaluatedProperties: false'. So just add
> optional resets property to the binding.
This is not main problem. I already commented on two of your similar
patches, so same applies here. Please describe real problem.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: display: bridge: renesas,dw-hdmi: Fix 'unevaluatedProperties' warnings
2022-08-30 9:23 ` Krzysztof Kozlowski
@ 2022-08-30 10:02 ` Lad, Prabhakar
0 siblings, 0 replies; 5+ messages in thread
From: Lad, Prabhakar @ 2022-08-30 10:02 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Lad Prabhakar, Laurent Pinchart, Kieran Bingham, Andrzej Hajda,
Neil Armstrong, Robert Foss, Jonas Karlman, Jernej Skrabec,
David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
Geert Uytterhoeven, DRI Development,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas, LKML, Biju Das
Hi Krzysztof,
Thank you for the review.
On Tue, Aug 30, 2022 at 10:23 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 30/08/2022 00:58, Lad Prabhakar wrote:
> > With 'unevaluatedProperties' support implemented, there's a number of
> > warnings when running dtbs_check:
> >
> > arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-rev2-ex-idk-1110wr.dtb: hdmi@fead0000: Unevaluated properties are not allowed ('resets' was unexpected)
> > From schema: Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml
> >
> > The main problem is that SoC DTSI's are including resets property, whereas
> > the renesas,dw-hdmi.yaml has 'unevaluatedProperties: false'. So just add
> > optional resets property to the binding.
>
> This is not main problem. I already commented on two of your similar
> patches, so same applies here. Please describe real problem.
>
Sure will do that and send a v2 (and also for the reset of the patches).
Cheers,
Prabhakar
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-30 10:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-29 21:58 [PATCH] dt-bindings: display: bridge: renesas,dw-hdmi: Fix 'unevaluatedProperties' warnings Lad Prabhakar
2022-08-29 23:08 ` Laurent Pinchart
2022-08-30 9:18 ` Lad, Prabhakar
2022-08-30 9:23 ` Krzysztof Kozlowski
2022-08-30 10:02 ` Lad, Prabhakar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®