* [PATCH] checkpatch.pl: Don't complain about nominal authors if there isn't one
@ 2019-09-12 20:55 Alan Stern
2019-09-12 21:09 ` Joe Perches
0 siblings, 1 reply; 6+ messages in thread
From: Alan Stern @ 2019-09-12 20:55 UTC (permalink / raw)
To: Andy Whitcroft, Joe Perches; +Cc: Kernel development list
checkpatch.pl shouldn't warn about a "Missing Signed-off-by: line by
nominal patch author" if there is no nominal patch author. Without
this change, checkpatch always gives me the following warning:
WARNING: Missing Signed-off-by: line by nominal patch author ''
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: usb-devel/scripts/checkpatch.pl
===================================================================
--- usb-devel.orig/scripts/checkpatch.pl
+++ usb-devel/scripts/checkpatch.pl
@@ -6673,7 +6673,7 @@ sub process {
if ($signoff == 0) {
ERROR("MISSING_SIGN_OFF",
"Missing Signed-off-by: line(s)\n");
- } elsif (!$authorsignoff) {
+ } elsif ($author ne '' && !$authorsignoff) {
WARN("NO_AUTHOR_SIGN_OFF",
"Missing Signed-off-by: line by nominal patch author '$author'\n");
}
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] checkpatch.pl: Don't complain about nominal authors if there isn't one
2019-09-12 20:55 [PATCH] checkpatch.pl: Don't complain about nominal authors if there isn't one Alan Stern
@ 2019-09-12 21:09 ` Joe Perches
2019-09-13 14:22 ` Alan Stern
0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2019-09-12 21:09 UTC (permalink / raw)
To: Alan Stern, Andy Whitcroft; +Cc: Kernel development list
On Thu, 2019-09-12 at 16:55 -0400, Alan Stern wrote:
> checkpatch.pl shouldn't warn about a "Missing Signed-off-by: line by
> nominal patch author" if there is no nominal patch author. Without
> this change, checkpatch always gives me the following warning:
>
> WARNING: Missing Signed-off-by: line by nominal patch author ''
When/how does this occur? Example please.
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
>
> ---
>
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: usb-devel/scripts/checkpatch.pl
> ===================================================================
> --- usb-devel.orig/scripts/checkpatch.pl
> +++ usb-devel/scripts/checkpatch.pl
> @@ -6673,7 +6673,7 @@ sub process {
> if ($signoff == 0) {
> ERROR("MISSING_SIGN_OFF",
> "Missing Signed-off-by: line(s)\n");
> - } elsif (!$authorsignoff) {
> + } elsif ($author ne '' && !$authorsignoff) {
> WARN("NO_AUTHOR_SIGN_OFF",
> "Missing Signed-off-by: line by nominal patch author '$author'\n");
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] checkpatch.pl: Don't complain about nominal authors if there isn't one
2019-09-12 21:09 ` Joe Perches
@ 2019-09-13 14:22 ` Alan Stern
2019-09-13 15:34 ` Joe Perches
0 siblings, 1 reply; 6+ messages in thread
From: Alan Stern @ 2019-09-13 14:22 UTC (permalink / raw)
To: Joe Perches; +Cc: Andy Whitcroft, Kernel development list
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1382 bytes --]
On Thu, 12 Sep 2019, Joe Perches wrote:
> On Thu, 2019-09-12 at 16:55 -0400, Alan Stern wrote:
> > checkpatch.pl shouldn't warn about a "Missing Signed-off-by: line by
> > nominal patch author" if there is no nominal patch author. Without
> > this change, checkpatch always gives me the following warning:
> >
> > WARNING: Missing Signed-off-by: line by nominal patch author ''
>
> When/how does this occur? Example please.
The patch itself is a good example. Attached to this email is the
patch file in the form I keep it (from quilt, not git; note that quilt
doesn't do a good job of handling the "---" line so I leave it out and
insert it when submitting the patch). Try saving the attachment and
running it through checkpatch.pl. Here's what I get:
$ scripts/checkpatch.pl /tmp/checkpatch-author-fix.patch
WARNING: Missing Signed-off-by: line by nominal patch author ''
total: 0 errors, 1 warnings, 8 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/tmp/checkpatch-author-fix.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Would you like me to resubmit the patch with this example added to the
patch description?
Alan Stern
[-- Attachment #2: Type: TEXT/PLAIN, Size: 944 bytes --]
checkpatch.pl shouldn't warn about a "Missing Signed-off-by: line by
nominal patch author" if there is no nominal patch author. Without
this change, checkpatch always gives me the following warning:
WARNING: Missing Signed-off-by: line by nominal patch author ''
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: usb-devel/scripts/checkpatch.pl
===================================================================
--- usb-devel.orig/scripts/checkpatch.pl
+++ usb-devel/scripts/checkpatch.pl
@@ -6673,7 +6673,7 @@ sub process {
if ($signoff == 0) {
ERROR("MISSING_SIGN_OFF",
"Missing Signed-off-by: line(s)\n");
- } elsif (!$authorsignoff) {
+ } elsif ($author ne '' && !$authorsignoff) {
WARN("NO_AUTHOR_SIGN_OFF",
"Missing Signed-off-by: line by nominal patch author '$author'\n");
}
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] checkpatch.pl: Don't complain about nominal authors if there isn't one
2019-09-13 14:22 ` Alan Stern
@ 2019-09-13 15:34 ` Joe Perches
2019-10-15 20:27 ` Alan Stern
2019-10-15 20:55 ` Andrew Morton
0 siblings, 2 replies; 6+ messages in thread
From: Joe Perches @ 2019-09-13 15:34 UTC (permalink / raw)
To: Alan Stern, Andrew Morton; +Cc: Andy Whitcroft, Kernel development list
On Fri, 2019-09-13 at 10:22 -0400, Alan Stern wrote:
> On Thu, 12 Sep 2019, Joe Perches wrote:
>
> > On Thu, 2019-09-12 at 16:55 -0400, Alan Stern wrote:
> > > checkpatch.pl shouldn't warn about a "Missing Signed-off-by: line by
> > > nominal patch author" if there is no nominal patch author. Without
> > > this change, checkpatch always gives me the following warning:
> > >
> > > WARNING: Missing Signed-off-by: line by nominal patch author ''
> >
> > When/how does this occur? Example please.
>
> The patch itself is a good example. Attached to this email is the
> patch file in the form I keep it (from quilt, not git; note that quilt
> doesn't do a good job of handling the "---" line so I leave it out and
> insert it when submitting the patch). Try saving the attachment and
> running it through checkpatch.pl. Here's what I get:
Andrew?
Does checkpatch emit this warning for you on
your quilt content?
If so, how do you handle it?
> $ scripts/checkpatch.pl /tmp/checkpatch-author-fix.patch
> WARNING: Missing Signed-off-by: line by nominal patch author ''
>
> total: 0 errors, 1 warnings, 8 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
> mechanically convert to the typical style using --fix or --fix-inplace.
>
> /tmp/checkpatch-author-fix.patch has style problems, please review.
>
> NOTE: If any of the errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
>
> Would you like me to resubmit the patch with this example added to the
> patch description?
>
> Alan Stern
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] checkpatch.pl: Don't complain about nominal authors if there isn't one
2019-09-13 15:34 ` Joe Perches
@ 2019-10-15 20:27 ` Alan Stern
2019-10-15 20:55 ` Andrew Morton
1 sibling, 0 replies; 6+ messages in thread
From: Alan Stern @ 2019-10-15 20:27 UTC (permalink / raw)
To: Joe Perches; +Cc: Andrew Morton, Andy Whitcroft, Kernel development list
Ping?
Alan Stern
On Fri, 13 Sep 2019, Joe Perches wrote:
> On Fri, 2019-09-13 at 10:22 -0400, Alan Stern wrote:
> > On Thu, 12 Sep 2019, Joe Perches wrote:
> >
> > > On Thu, 2019-09-12 at 16:55 -0400, Alan Stern wrote:
> > > > checkpatch.pl shouldn't warn about a "Missing Signed-off-by: line by
> > > > nominal patch author" if there is no nominal patch author. Without
> > > > this change, checkpatch always gives me the following warning:
> > > >
> > > > WARNING: Missing Signed-off-by: line by nominal patch author ''
> > >
> > > When/how does this occur? Example please.
> >
> > The patch itself is a good example. Attached to this email is the
> > patch file in the form I keep it (from quilt, not git; note that quilt
> > doesn't do a good job of handling the "---" line so I leave it out and
> > insert it when submitting the patch). Try saving the attachment and
> > running it through checkpatch.pl. Here's what I get:
>
> Andrew?
>
> Does checkpatch emit this warning for you on
> your quilt content?
>
> If so, how do you handle it?
>
> > $ scripts/checkpatch.pl /tmp/checkpatch-author-fix.patch
> > WARNING: Missing Signed-off-by: line by nominal patch author ''
> >
> > total: 0 errors, 1 warnings, 8 lines checked
> >
> > NOTE: For some of the reported defects, checkpatch may be able to
> > mechanically convert to the typical style using --fix or --fix-inplace.
> >
> > /tmp/checkpatch-author-fix.patch has style problems, please review.
> >
> > NOTE: If any of the errors are false positives, please report
> > them to the maintainer, see CHECKPATCH in MAINTAINERS.
> >
> >
> > Would you like me to resubmit the patch with this example added to the
> > patch description?
> >
> > Alan Stern
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] checkpatch.pl: Don't complain about nominal authors if there isn't one
2019-09-13 15:34 ` Joe Perches
2019-10-15 20:27 ` Alan Stern
@ 2019-10-15 20:55 ` Andrew Morton
1 sibling, 0 replies; 6+ messages in thread
From: Andrew Morton @ 2019-10-15 20:55 UTC (permalink / raw)
To: Joe Perches; +Cc: Alan Stern, Andy Whitcroft, Kernel development list
On Fri, 13 Sep 2019 08:34:28 -0700 Joe Perches <joe@perches.com> wrote:
> On Fri, 2019-09-13 at 10:22 -0400, Alan Stern wrote:
> > On Thu, 12 Sep 2019, Joe Perches wrote:
> >
> > > On Thu, 2019-09-12 at 16:55 -0400, Alan Stern wrote:
> > > > checkpatch.pl shouldn't warn about a "Missing Signed-off-by: line by
> > > > nominal patch author" if there is no nominal patch author. Without
> > > > this change, checkpatch always gives me the following warning:
> > > >
> > > > WARNING: Missing Signed-off-by: line by nominal patch author ''
> > >
> > > When/how does this occur? Example please.
> >
> > The patch itself is a good example. Attached to this email is the
> > patch file in the form I keep it (from quilt, not git; note that quilt
> > doesn't do a good job of handling the "---" line so I leave it out and
> > insert it when submitting the patch). Try saving the attachment and
> > running it through checkpatch.pl. Here's what I get:
>
> Andrew?
>
> Does checkpatch emit this warning for you on
> your quilt content?
Nope. All my patches always have From: and Subject: at the start of
changelog.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-15 20:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-12 20:55 [PATCH] checkpatch.pl: Don't complain about nominal authors if there isn't one Alan Stern
2019-09-12 21:09 ` Joe Perches
2019-09-13 14:22 ` Alan Stern
2019-09-13 15:34 ` Joe Perches
2019-10-15 20:27 ` Alan Stern
2019-10-15 20:55 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®