mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Zheng Wang <zyytlz.wz@163.com>
Cc: support.opensource@diasemi.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, hackerzheng666@gmail.com,
	1395428693sheep@gmail.com, alex000young@gmail.com
Subject: Re: [PATCH] power: supply: da9150: Fix use after free bug in da9150_charger_remove due to race condition
Date: Fri, 10 Mar 2023 00:39:13 +0100	[thread overview]
Message-ID: <e5b1ee16-796e-43fe-b703-3ce06aed364d@mercury.local> (raw)
In-Reply-To: <20230309181036.262674-1-zyytlz.wz@163.com>

[-- Attachment #1: Type: text/plain, Size: 1815 bytes --]

Hi,

On Fri, Mar 10, 2023 at 02:10:36AM +0800, Zheng Wang wrote:
> In da9150_charger_probe, &charger->otg_work is bound with
> da9150_charger_otg_work. da9150_charger_otg_ncb may be
> called to start the work.
> 
> If we remove the module which will call da9150_charger_remove
>  to make cleanup, there may be a unfinished work. The possible
>   sequence is as follows:
> 
> Fix it by canceling the work before cleanup in the mtk_jpeg_remove

mtk_jpeg_remove?

> 
> CPU0                  CPUc1
> 
>                     |da9150_charger_otg_work
> da9150_charger_remove      |
> power_supply_unregister  |
> device_unregister   |
> power_supply_dev_release|
> kfree(psy)          |
>                     |
>                     | 	power_supply_changed(charger->usb);
>                     |   //use
> Fixes: c1a281e34dae ("power: Add support for DA9150 Charger")
> Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
> ---

Looks correct to me, but the cancel_work_sync should happen after
usb_unregister_notifier(), otherwise there is still a race
condition.

-- Sebastian

>  drivers/power/supply/da9150-charger.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/supply/da9150-charger.c b/drivers/power/supply/da9150-charger.c
> index 14da5c595dd9..41b68f2f6ed8 100644
> --- a/drivers/power/supply/da9150-charger.c
> +++ b/drivers/power/supply/da9150-charger.c
> @@ -642,6 +642,7 @@ static int da9150_charger_remove(struct platform_device *pdev)
>  	struct da9150_charger *charger = platform_get_drvdata(pdev);
>  	int irq;
>  
> +	cancel_work_sync(&charger->otg_work);
>  	/* Make sure IRQs are released before unregistering power supplies */
>  	irq = platform_get_irq_byname(pdev, "CHG_VBUS");
>  	free_irq(irq, charger);
> -- 
> 2.25.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Zheng Wang <zyytlz.wz@163.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	hackerzheng666@gmail.com, 1395428693sheep@gmail.com,
	alex000young@gmail.com
Subject: Re: [PATCH] power: supply: bq24190: Fix use after free bug in bq24190_remove due to race condition
Date: Fri, 10 Mar 2023 00:40:06 +0100	[thread overview]
Message-ID: <e5b1ee16-796e-43fe-b703-3ce06aed364d@mercury.local> (raw)
Message-ID: <20230309234006.E2_qJQzZiFzSJSwgPmgkmJOypemqHwvYGH_8TXRg1UQ@z> (raw)
In-Reply-To: <20230309174728.233732-1-zyytlz.wz@163.com>

[-- Attachment #1: Type: text/plain, Size: 1767 bytes --]

Hi,

On Fri, Mar 10, 2023 at 01:47:28AM +0800, Zheng Wang wrote:
> In bq24190_probe, &bdi->input_current_limit_work is bound
> with bq24190_input_current_limit_work. When external power
> changed, it will call bq24190_charger_external_power_changed
>  to start the work.
> 
> If we remove the module which will call bq24190_remove to make
> cleanup, there may be a unfinished work. The possible
> sequence is as follows:
> 
> CPU0                  CPUc1
> 
>                     |bq24190_input_current_limit_work
> bq24190_remove      |
> power_supply_unregister  |
> device_unregister   |
> power_supply_dev_release|
> kfree(psy)          |
>                     |
>                     | power_supply_get_property_from_supplier
>                     |   //use
> 
> Fix it by finishing the work before cleanup in the bq24190_remove
> 
> Fixes: 97774672573a ("power_supply: Initialize changed_work before calling device_add")
> Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
> ---

Thanks, queued to fixes branch.

-- Sebastian

>  drivers/power/supply/bq24190_charger.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
> index be34b9848450..de67b985f0a9 100644
> --- a/drivers/power/supply/bq24190_charger.c
> +++ b/drivers/power/supply/bq24190_charger.c
> @@ -1906,6 +1906,7 @@ static void bq24190_remove(struct i2c_client *client)
>  	struct bq24190_dev_info *bdi = i2c_get_clientdata(client);
>  	int error;
>  
> +	cancel_delayed_work_sync(&bdi->input_current_limit_work);
>  	error = pm_runtime_resume_and_get(bdi->dev);
>  	if (error < 0)
>  		dev_warn(bdi->dev, "pm_runtime_get failed: %i\n", error);
> -- 
> 2.25.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2023-03-09 23:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09 18:10 Zheng Wang
2023-03-09 23:39 ` Sebastian Reichel [this message]
2023-03-09 23:40   ` [PATCH] power: supply: bq24190: Fix use after free bug in bq24190_remove " Sebastian Reichel
2023-03-10 16:24   ` [PATCH] power: supply: da9150: Fix use after free bug in da9150_charger_remove " Zheng Hacker
2023-03-10 16:25   ` [PATCH] power: supply: bq24190: Fix use after free bug in bq24190_remove " Zheng Hacker
  -- strict thread matches above, loose matches on Subject: below --
2023-03-09 17:47 Zheng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5b1ee16-796e-43fe-b703-3ce06aed364d@mercury.local \
    --to=sebastian.reichel@collabora.com \
    --cc=1395428693sheep@gmail.com \
    --cc=alex000young@gmail.com \
    --cc=hackerzheng666@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=support.opensource@diasemi.com \
    --cc=zyytlz.wz@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®