mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lars Persson <lars.persson@axis.com>
To: Pavel Andrianov <andrianov@ispras.ru>, Lars Persson <larper@axis.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Vaishali Thakkar <vaishali.thakkar@oracle.com>,
	<ldv-project@linuxtesting.org>
Subject: Re: A potential bug in drivers/net/ethernet/synopsys/dwc_eth_qos.ko
Date: Mon, 5 Sep 2016 13:45:28 +0200	[thread overview]
Message-ID: <e72ce0af-c35d-bbf9-e30f-f40f3b9053f0@axis.com> (raw)
In-Reply-To: <1403c768-7ed1-dc5c-38ae-ac91f876a175@ispras.ru>

Hi Pavel,

Thanks for the notification. I agree that we should register the device 
after all initialization has completed. A patch will be sent shortly.

BR,
  Lars


On 09/05/2016 10:26 AM, Pavel Andrianov wrote:
> Hi!
>
> There is a potential bug in
> drivers/net/ethernet/synopsys/dwc_eth_qos.ko. In dwceqos_probe there is
> a registration of net device (line 2879). After that initialization of
> common resources is continued (lines 2918, 2924, 2941), but at the
> moment handlers from net device may be already executed.
>
> Should the registration of net device be at the end of dwceqos_probe?
>

      reply	other threads:[~2016-09-05 11:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-05  8:26 Pavel Andrianov
2016-09-05 11:45 ` Lars Persson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e72ce0af-c35d-bbf9-e30f-f40f3b9053f0@axis.com \
    --to=lars.persson@axis.com \
    --cc=andrianov@ispras.ru \
    --cc=larper@axis.com \
    --cc=ldv-project@linuxtesting.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vaishali.thakkar@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome