mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* A potential bug in drivers/net/ethernet/synopsys/dwc_eth_qos.ko
@ 2016-09-05  8:26 Pavel Andrianov
  2016-09-05 11:45 ` Lars Persson
  0 siblings, 1 reply; 2+ messages in thread
From: Pavel Andrianov @ 2016-09-05  8:26 UTC (permalink / raw)
  To: Lars Persson; +Cc: netdev, linux-kernel, Vaishali Thakkar, ldv-project

Hi!

There is a potential bug in 
drivers/net/ethernet/synopsys/dwc_eth_qos.ko. In dwceqos_probe there is 
a registration of net device (line 2879). After that initialization of 
common resources is continued (lines 2918, 2924, 2941), but at the 
moment handlers from net device may be already executed.

Should the registration of net device be at the end of dwceqos_probe?

-- 
Pavel Andrianov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: andrianov@ispras.ru

^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: A potential bug in drivers/net/ethernet/synopsys/dwc_eth_qos.ko
  2016-09-05  8:26 A potential bug in drivers/net/ethernet/synopsys/dwc_eth_qos.ko Pavel Andrianov
@ 2016-09-05 11:45 ` Lars Persson
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Persson @ 2016-09-05 11:45 UTC (permalink / raw)
  To: Pavel Andrianov, Lars Persson
  Cc: netdev, linux-kernel, Vaishali Thakkar, ldv-project

Hi Pavel,

Thanks for the notification. I agree that we should register the device 
after all initialization has completed. A patch will be sent shortly.

BR,
  Lars


On 09/05/2016 10:26 AM, Pavel Andrianov wrote:
> Hi!
>
> There is a potential bug in
> drivers/net/ethernet/synopsys/dwc_eth_qos.ko. In dwceqos_probe there is
> a registration of net device (line 2879). After that initialization of
> common resources is continued (lines 2918, 2924, 2941), but at the
> moment handlers from net device may be already executed.
>
> Should the registration of net device be at the end of dwceqos_probe?
>

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-05 11:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-05  8:26 A potential bug in drivers/net/ethernet/synopsys/dwc_eth_qos.ko Pavel Andrianov
2016-09-05 11:45 ` Lars Persson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome