mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Palmer Dabbelt <palmer@dabbelt.com>, <akpm@linux-foundation.org>,
	<atishp@atishpatra.org>
Cc: <aou@eecs.berkeley.edu>,
	Palmer Dabbelt <palmerdabbelt@google.com>,
	<linux-kernel@vger.kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	<linux-riscv@lists.infradead.org>, <kernel-team@android.com>
Subject: Re: [PATCH] RISC-V: Make NUMA depend on SMP
Date: Sat, 27 Feb 2021 09:03:53 +0800	[thread overview]
Message-ID: <e76cf929-ba52-6d53-9ac8-ef403f9b1f4f@huawei.com> (raw)
In-Reply-To: <20210226202550.512012-1-palmer@dabbelt.com>


On 2021/2/27 4:25, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmerdabbelt@google.com>
>
> In theory these are orthogonal, but in practice all NUMA systems are
> SMP.  NUMA && !SMP doesn't build, everyone else is coupling them, and I
> don't really see any value in supporting that configuration.
>
> Fixes: 4f0e8eef772e ("riscv: Add numa support for riscv64 platform")
> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> Suggested-by: Atish Patra <atishp@atishpatra.org>
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>

Reported-and-Tested-by:  Kefeng Wang <wangkefeng.wang@huawei.com>


> ---
> This is on fixes.
> ---
>   arch/riscv/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index a998babc1237..85d626b8ce5e 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -314,6 +314,7 @@ endchoice
>   # Common NUMA Features
>   config NUMA
>   	bool "NUMA Memory Allocation and Scheduler Support"
> +	depends on SMP
>   	select GENERIC_ARCH_NUMA
>   	select OF_NUMA
>   	select ARCH_SUPPORTS_NUMA_BALANCING

  reply	other threads:[~2021-02-27  1:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-26 20:25 Palmer Dabbelt
2021-02-27  1:03 ` Kefeng Wang [this message]
2021-02-27  3:07   ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e76cf929-ba52-6d53-9ac8-ef403f9b1f4f@huawei.com \
    --to=wangkefeng.wang@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=atishp@atishpatra.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=palmerdabbelt@google.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®