* [PATCH] RISC-V: Make NUMA depend on SMP
@ 2021-02-26 20:25 Palmer Dabbelt
2021-02-27 1:03 ` Kefeng Wang
0 siblings, 1 reply; 3+ messages in thread
From: Palmer Dabbelt @ 2021-02-26 20:25 UTC (permalink / raw)
To: akpm, atishp
Cc: Paul Walmsley, Palmer Dabbelt, aou, linux-riscv, linux-kernel,
kernel-team, Palmer Dabbelt
From: Palmer Dabbelt <palmerdabbelt@google.com>
In theory these are orthogonal, but in practice all NUMA systems are
SMP. NUMA && !SMP doesn't build, everyone else is coupling them, and I
don't really see any value in supporting that configuration.
Fixes: 4f0e8eef772e ("riscv: Add numa support for riscv64 platform")
Suggested-by: Andrew Morton <akpm@linux-foundation.org>
Suggested-by: Atish Patra <atishp@atishpatra.org>
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
---
This is on fixes.
---
arch/riscv/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
index a998babc1237..85d626b8ce5e 100644
--- a/arch/riscv/Kconfig
+++ b/arch/riscv/Kconfig
@@ -314,6 +314,7 @@ endchoice
# Common NUMA Features
config NUMA
bool "NUMA Memory Allocation and Scheduler Support"
+ depends on SMP
select GENERIC_ARCH_NUMA
select OF_NUMA
select ARCH_SUPPORTS_NUMA_BALANCING
--
2.30.1.766.gb4fecdf3b7-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RISC-V: Make NUMA depend on SMP
2021-02-26 20:25 [PATCH] RISC-V: Make NUMA depend on SMP Palmer Dabbelt
@ 2021-02-27 1:03 ` Kefeng Wang
2021-02-27 3:07 ` Palmer Dabbelt
0 siblings, 1 reply; 3+ messages in thread
From: Kefeng Wang @ 2021-02-27 1:03 UTC (permalink / raw)
To: Palmer Dabbelt, akpm, atishp
Cc: aou, Palmer Dabbelt, linux-kernel, Paul Walmsley, linux-riscv,
kernel-team
On 2021/2/27 4:25, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmerdabbelt@google.com>
>
> In theory these are orthogonal, but in practice all NUMA systems are
> SMP. NUMA && !SMP doesn't build, everyone else is coupling them, and I
> don't really see any value in supporting that configuration.
>
> Fixes: 4f0e8eef772e ("riscv: Add numa support for riscv64 platform")
> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> Suggested-by: Atish Patra <atishp@atishpatra.org>
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
Reported-and-Tested-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> This is on fixes.
> ---
> arch/riscv/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index a998babc1237..85d626b8ce5e 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -314,6 +314,7 @@ endchoice
> # Common NUMA Features
> config NUMA
> bool "NUMA Memory Allocation and Scheduler Support"
> + depends on SMP
> select GENERIC_ARCH_NUMA
> select OF_NUMA
> select ARCH_SUPPORTS_NUMA_BALANCING
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RISC-V: Make NUMA depend on SMP
2021-02-27 1:03 ` Kefeng Wang
@ 2021-02-27 3:07 ` Palmer Dabbelt
0 siblings, 0 replies; 3+ messages in thread
From: Palmer Dabbelt @ 2021-02-27 3:07 UTC (permalink / raw)
To: wangkefeng.wang
Cc: akpm, atishp, aou, linux-kernel, Paul Walmsley, linux-riscv, kernel-team
On Fri, 26 Feb 2021 17:03:53 PST (-0800), wangkefeng.wang@huawei.com wrote:
>
> On 2021/2/27 4:25, Palmer Dabbelt wrote:
>> From: Palmer Dabbelt <palmerdabbelt@google.com>
>>
>> In theory these are orthogonal, but in practice all NUMA systems are
>> SMP. NUMA && !SMP doesn't build, everyone else is coupling them, and I
>> don't really see any value in supporting that configuration.
>>
>> Fixes: 4f0e8eef772e ("riscv: Add numa support for riscv64 platform")
>> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
>> Suggested-by: Atish Patra <atishp@atishpatra.org>
>> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
>
> Reported-and-Tested-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Ah, thanks, I forged I'd said no to this earlier ;)
>
>
>> ---
>> This is on fixes.
>> ---
>> arch/riscv/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
>> index a998babc1237..85d626b8ce5e 100644
>> --- a/arch/riscv/Kconfig
>> +++ b/arch/riscv/Kconfig
>> @@ -314,6 +314,7 @@ endchoice
>> # Common NUMA Features
>> config NUMA
>> bool "NUMA Memory Allocation and Scheduler Support"
>> + depends on SMP
>> select GENERIC_ARCH_NUMA
>> select OF_NUMA
>> select ARCH_SUPPORTS_NUMA_BALANCING
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-27 3:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-26 20:25 [PATCH] RISC-V: Make NUMA depend on SMP Palmer Dabbelt
2021-02-27 1:03 ` Kefeng Wang
2021-02-27 3:07 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®