mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julien Thierry <julien.thierry@arm.com>
To: Xu YiPing <xuyiping@hisilicon.com>,
	catalin.marinas@arm.com, mark.rutland@arm.com,
	will.deacon@arm.com, namhyung@kernel.org, jolsa@redhat.com,
	alexander.shishkin@linux.intel.com, acme@kernel.org,
	mingo@redhat.com, peterz@infradead.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: perf: remove duplicated and unsupported events for Cortex-A73
Date: Tue, 14 Nov 2017 13:27:41 +0000	[thread overview]
Message-ID: <e7909d3c-9e29-a89a-270d-1b6d455ae2a9@arm.com> (raw)
In-Reply-To: <20171114124913.np2rtiyhghxipzzx@ukko.fi.intel.com>

Hi,

On 14/11/17 12:49, Alexander Shishkin wrote:
> On Tue, Nov 14, 2017 at 08:27:59PM +0800, Xu YiPing wrote:
>> bus access read/write events are not supported in A73, and the definition
>> is duplicated, so delete it.
> 
> In the changelog, it would be nice to mention the commit that added these:
> 
> 5561b6c5e9813 ("arm64: perf: add support for Cortex-A73")
> 
> Also it's not clear what is this new statement based on. The original
> commit at least references a TRM document.
> 

I re-checked the TRM for this core and Xu is right, the BUS_ACCESS 
events are not available on Cortex-A73. Plus those entries are 
duplicated, I think something went wrong when I rebased the patch.

So I think this new patch is doing the right thing.

Thanks for catching that.

Cheers,

-- 
Julien Thierry

      parent reply	other threads:[~2017-11-14 13:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-14 12:27 Xu YiPing
     [not found] ` <20171114124913.np2rtiyhghxipzzx@ukko.fi.intel.com>
2017-11-14 13:27   ` Julien Thierry [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7909d3c-9e29-a89a-270d-1b6d455ae2a9@arm.com \
    --to=julien.thierry@arm.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=catalin.marinas@arm.com \
    --cc=jolsa@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=will.deacon@arm.com \
    --cc=xuyiping@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®