* [PATCH] arm64: perf: remove duplicated and unsupported events for Cortex-A73
@ 2017-11-14 12:27 Xu YiPing
[not found] ` <20171114124913.np2rtiyhghxipzzx@ukko.fi.intel.com>
0 siblings, 1 reply; 2+ messages in thread
From: Xu YiPing @ 2017-11-14 12:27 UTC (permalink / raw)
To: xuyiping, catalin.marinas, mark.rutland, will.deacon, namhyung,
jolsa, alexander.shishkin, acme, mingo, peterz, julien.thierry
Cc: linux-kernel, linux-arm-kernel
bus access read/write events are not supported in A73, and the definition
is duplicated, so delete it.
Signed-off-by: Xu YiPing <xuyiping@hisilicon.com>
---
arch/arm64/kernel/perf_event.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
index 9eaef51..3affca3 100644
--- a/arch/arm64/kernel/perf_event.c
+++ b/arch/arm64/kernel/perf_event.c
@@ -262,12 +262,6 @@ static const unsigned armv8_a73_perf_cache_map[PERF_COUNT_HW_CACHE_MAX]
[C(L1D)][C(OP_READ)][C(RESULT_ACCESS)] = ARMV8_IMPDEF_PERFCTR_L1D_CACHE_RD,
[C(L1D)][C(OP_WRITE)][C(RESULT_ACCESS)] = ARMV8_IMPDEF_PERFCTR_L1D_CACHE_WR,
-
- [C(NODE)][C(OP_READ)][C(RESULT_ACCESS)] = ARMV8_IMPDEF_PERFCTR_BUS_ACCESS_RD,
- [C(NODE)][C(OP_WRITE)][C(RESULT_ACCESS)] = ARMV8_IMPDEF_PERFCTR_BUS_ACCESS_WR,
-
- [C(NODE)][C(OP_READ)][C(RESULT_ACCESS)] = ARMV8_IMPDEF_PERFCTR_BUS_ACCESS_RD,
- [C(NODE)][C(OP_WRITE)][C(RESULT_ACCESS)] = ARMV8_IMPDEF_PERFCTR_BUS_ACCESS_WR,
};
static const unsigned armv8_thunder_perf_cache_map[PERF_COUNT_HW_CACHE_MAX]
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: perf: remove duplicated and unsupported events for Cortex-A73
[not found] ` <20171114124913.np2rtiyhghxipzzx@ukko.fi.intel.com>
@ 2017-11-14 13:27 ` Julien Thierry
0 siblings, 0 replies; 2+ messages in thread
From: Julien Thierry @ 2017-11-14 13:27 UTC (permalink / raw)
To: Xu YiPing, catalin.marinas, mark.rutland, will.deacon, namhyung,
jolsa, alexander.shishkin, acme, mingo, peterz, linux-kernel,
linux-arm-kernel
Hi,
On 14/11/17 12:49, Alexander Shishkin wrote:
> On Tue, Nov 14, 2017 at 08:27:59PM +0800, Xu YiPing wrote:
>> bus access read/write events are not supported in A73, and the definition
>> is duplicated, so delete it.
>
> In the changelog, it would be nice to mention the commit that added these:
>
> 5561b6c5e9813 ("arm64: perf: add support for Cortex-A73")
>
> Also it's not clear what is this new statement based on. The original
> commit at least references a TRM document.
>
I re-checked the TRM for this core and Xu is right, the BUS_ACCESS
events are not available on Cortex-A73. Plus those entries are
duplicated, I think something went wrong when I rebased the patch.
So I think this new patch is doing the right thing.
Thanks for catching that.
Cheers,
--
Julien Thierry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-14 13:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-14 12:27 [PATCH] arm64: perf: remove duplicated and unsupported events for Cortex-A73 Xu YiPing
[not found] ` <20171114124913.np2rtiyhghxipzzx@ukko.fi.intel.com>
2017-11-14 13:27 ` Julien Thierry
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®