[PATCH v5] arm64: defconfig: Enable STM protocol and source configs

[PATCH v5] arm64: defconfig: Enable STM protocol and source configs

[Mao Jinlong]

STM is used for logging useful softevens from various entities.
With STM and TMC sink enabled, there will be more buffer size to store
the logs. STM source and STM protocol need to be configured along with
STM device for STM function refer to Documentation/trace/stm.rst.
CONFIG_CORESIGHT_STM is already added as module. Add Coresight STM
source and Protocol configs as module so that STM functions can be
used.

Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
---
Changes in v5:
- Update commit message.

Changes in v4:
- Remove Ftrace config.

Changes in v3:
- update commit message.

Changes in v2:
- select ftrace config explicitly.
 arch/arm64/configs/defconfig | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 5fdbfea7a5b2..ac11cd1a7c06 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1599,6 +1599,11 @@ CONFIG_NVMEM_SNVS_LPGPR=y
 CONFIG_NVMEM_SPMI_SDAM=m
 CONFIG_NVMEM_SUNXI_SID=y
 CONFIG_NVMEM_UNIPHIER_EFUSE=y
+CONFIG_STM_PROTO_BASIC=m
+CONFIG_STM_PROTO_SYS_T=m
+CONFIG_STM_DUMMY=m
+CONFIG_STM_SOURCE_CONSOLE=m
+CONFIG_STM_SOURCE_HEARTBEAT=m
 CONFIG_FPGA=y
 CONFIG_FPGA_MGR_ALTERA_CVP=m
 CONFIG_FPGA_MGR_STRATIX10_SOC=m
-- 
2.17.1

Re: [PATCH v5] arm64: defconfig: Enable STM protocol and source configs

[Jinlong Mao]

On 2024/11/1 16:45, Mao Jinlong wrote:
> STM is used for logging useful softevens from various entities.
> With STM and TMC sink enabled, there will be more buffer size to store
> the logs. STM source and STM protocol need to be configured along with
> STM device for STM function refer to Documentation/trace/stm.rst.
> CONFIG_CORESIGHT_STM is already added as module. Add Coresight STM
> source and Protocol configs as module so that STM functions can be
> used.
> 
> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
> ---
> Changes in v5:
> - Update commit message.
> 
> Changes in v4:
> - Remove Ftrace config.
> 
> Changes in v3:
> - update commit message.
> 
> Changes in v2:
> - select ftrace config explicitly.
>   arch/arm64/configs/defconfig | 5 +++++
>   1 file changed, 5 insertions(+)

Gentle reminder for the review.

> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 5fdbfea7a5b2..ac11cd1a7c06 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1599,6 +1599,11 @@ CONFIG_NVMEM_SNVS_LPGPR=y
>   CONFIG_NVMEM_SPMI_SDAM=m
>   CONFIG_NVMEM_SUNXI_SID=y
>   CONFIG_NVMEM_UNIPHIER_EFUSE=y
> +CONFIG_STM_PROTO_BASIC=m
> +CONFIG_STM_PROTO_SYS_T=m
> +CONFIG_STM_DUMMY=m
> +CONFIG_STM_SOURCE_CONSOLE=m
> +CONFIG_STM_SOURCE_HEARTBEAT=m
>   CONFIG_FPGA=y
>   CONFIG_FPGA_MGR_ALTERA_CVP=m
>   CONFIG_FPGA_MGR_STRATIX10_SOC=m

Re: [PATCH v5] arm64: defconfig: Enable STM protocol and source configs

[Krzysztof Kozlowski]

On 17/12/2024 08:47, Jinlong Mao wrote:
> 
> 
> On 2024/11/1 16:45, Mao Jinlong wrote:
>> STM is used for logging useful softevens from various entities.
>> With STM and TMC sink enabled, there will be more buffer size to store
>> the logs. STM source and STM protocol need to be configured along with
>> STM device for STM function refer to Documentation/trace/stm.rst.
>> CONFIG_CORESIGHT_STM is already added as module. Add Coresight STM
>> source and Protocol configs as module so that STM functions can be
>> used.
>>
>> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
>> ---
>> Changes in v5:
>> - Update commit message.
>>
>> Changes in v4:
>> - Remove Ftrace config.
>>
>> Changes in v3:
>> - update commit message.
>>
>> Changes in v2:
>> - select ftrace config explicitly.
>>   arch/arm64/configs/defconfig | 5 +++++
>>   1 file changed, 5 insertions(+)
> 
> Gentle reminder for the review.
No need to ping for this. It's pending deliberately - on you. If you
want this to be merged, you need to funnel it through SoC maintainer's
tree. get_maintainers.pl (explained also in SoC maintainer profile).

To be clear: I do not object this patch, but I also do not see that many
benefits in having it in defconfig, thus no ack from me.


Best regards,
Krzysztof