* [PATCH] tools/power: Don't make man pages executable
@ 2017-12-19 19:54 Laura Abbott
2017-12-19 23:48 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Laura Abbott @ 2017-12-19 19:54 UTC (permalink / raw)
To: Len Brown, Rafael J. Wysocki; +Cc: Laura Abbott, linux-kernel
rpm-lint flagged these as being executable:
kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/turbostat.8.gz
kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/x86_energy_perf_policy.8.gz
Fix this
Signed-off-by: Laura Abbott <labbott@redhat.com>
---
tools/power/x86/turbostat/Makefile | 2 +-
tools/power/x86/x86_energy_perf_policy/Makefile | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/power/x86/turbostat/Makefile b/tools/power/x86/turbostat/Makefile
index a9bc914a8fe8..2ab25aa38263 100644
--- a/tools/power/x86/turbostat/Makefile
+++ b/tools/power/x86/turbostat/Makefile
@@ -25,4 +25,4 @@ install : turbostat
install -d $(DESTDIR)$(PREFIX)/bin
install $(BUILD_OUTPUT)/turbostat $(DESTDIR)$(PREFIX)/bin/turbostat
install -d $(DESTDIR)$(PREFIX)/share/man/man8
- install turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
+ install -m 644 turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
diff --git a/tools/power/x86/x86_energy_perf_policy/Makefile b/tools/power/x86/x86_energy_perf_policy/Makefile
index 2447b1bbaacf..f4534fb8b951 100644
--- a/tools/power/x86/x86_energy_perf_policy/Makefile
+++ b/tools/power/x86/x86_energy_perf_policy/Makefile
@@ -24,5 +24,5 @@ install : x86_energy_perf_policy
install -d $(DESTDIR)$(PREFIX)/bin
install $(BUILD_OUTPUT)/x86_energy_perf_policy $(DESTDIR)$(PREFIX)/bin/x86_energy_perf_policy
install -d $(DESTDIR)$(PREFIX)/share/man/man8
- install x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8
+ install -m 644 x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8
--
2.14.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/power: Don't make man pages executable
2017-12-19 19:54 [PATCH] tools/power: Don't make man pages executable Laura Abbott
@ 2017-12-19 23:48 ` Rafael J. Wysocki
2017-12-20 0:36 ` Laura Abbott
0 siblings, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2017-12-19 23:48 UTC (permalink / raw)
To: Laura Abbott; +Cc: Len Brown, linux-kernel
On 12/19/2017 8:54 PM, Laura Abbott wrote:
> rpm-lint flagged these as being executable:
>
> kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/turbostat.8.gz
> kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/x86_energy_perf_policy.8.gz
>
> Fix this
>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
Please CC PM stuff to linux-pm (which makes it easier to handle).
> ---
> tools/power/x86/turbostat/Makefile | 2 +-
> tools/power/x86/x86_energy_perf_policy/Makefile | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/power/x86/turbostat/Makefile b/tools/power/x86/turbostat/Makefile
> index a9bc914a8fe8..2ab25aa38263 100644
> --- a/tools/power/x86/turbostat/Makefile
> +++ b/tools/power/x86/turbostat/Makefile
> @@ -25,4 +25,4 @@ install : turbostat
> install -d $(DESTDIR)$(PREFIX)/bin
> install $(BUILD_OUTPUT)/turbostat $(DESTDIR)$(PREFIX)/bin/turbostat
> install -d $(DESTDIR)$(PREFIX)/share/man/man8
> - install turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
> + install -m 644 turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
> diff --git a/tools/power/x86/x86_energy_perf_policy/Makefile b/tools/power/x86/x86_energy_perf_policy/Makefile
> index 2447b1bbaacf..f4534fb8b951 100644
> --- a/tools/power/x86/x86_energy_perf_policy/Makefile
> +++ b/tools/power/x86/x86_energy_perf_policy/Makefile
> @@ -24,5 +24,5 @@ install : x86_energy_perf_policy
> install -d $(DESTDIR)$(PREFIX)/bin
> install $(BUILD_OUTPUT)/x86_energy_perf_policy $(DESTDIR)$(PREFIX)/bin/x86_energy_perf_policy
> install -d $(DESTDIR)$(PREFIX)/share/man/man8
> - install x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8
> + install -m 644 x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8
>
Thanks,
Rafael
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/power: Don't make man pages executable
2017-12-19 23:48 ` Rafael J. Wysocki
@ 2017-12-20 0:36 ` Laura Abbott
2017-12-20 1:36 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Laura Abbott @ 2017-12-20 0:36 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Len Brown, linux-kernel
On 12/19/2017 03:48 PM, Rafael J. Wysocki wrote:
> On 12/19/2017 8:54 PM, Laura Abbott wrote:
>> rpm-lint flagged these as being executable:
>>
>> kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/turbostat.8.gz
>> kernel-tools.x86_64: W: spurious-executable-perm /usr/share/man/man8/x86_energy_perf_policy.8.gz
>>
>> Fix this
>>
>> Signed-off-by: Laura Abbott <labbott@redhat.com>
>
> Please CC PM stuff to linux-pm (which makes it easier to handle).
>
Neither of these are listed in MAINTAINERS so I missed sending to
linux-pm. I'll remember for next time, do you want me to resend
for tracking?
Thanks,
Laura
>> ---
>> tools/power/x86/turbostat/Makefile | 2 +-
>> tools/power/x86/x86_energy_perf_policy/Makefile | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/power/x86/turbostat/Makefile b/tools/power/x86/turbostat/Makefile
>> index a9bc914a8fe8..2ab25aa38263 100644
>> --- a/tools/power/x86/turbostat/Makefile
>> +++ b/tools/power/x86/turbostat/Makefile
>> @@ -25,4 +25,4 @@ install : turbostat
>> install -d $(DESTDIR)$(PREFIX)/bin
>> install $(BUILD_OUTPUT)/turbostat $(DESTDIR)$(PREFIX)/bin/turbostat
>> install -d $(DESTDIR)$(PREFIX)/share/man/man8
>> - install turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
>> + install -m 644 turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
>> diff --git a/tools/power/x86/x86_energy_perf_policy/Makefile b/tools/power/x86/x86_energy_perf_policy/Makefile
>> index 2447b1bbaacf..f4534fb8b951 100644
>> --- a/tools/power/x86/x86_energy_perf_policy/Makefile
>> +++ b/tools/power/x86/x86_energy_perf_policy/Makefile
>> @@ -24,5 +24,5 @@ install : x86_energy_perf_policy
>> install -d $(DESTDIR)$(PREFIX)/bin
>> install $(BUILD_OUTPUT)/x86_energy_perf_policy $(DESTDIR)$(PREFIX)/bin/x86_energy_perf_policy
>> install -d $(DESTDIR)$(PREFIX)/share/man/man8
>> - install x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8
>> + install -m 644 x86_energy_perf_policy.8 $(DESTDIR)$(PREFIX)/share/man/man8
>
>
> Thanks,
>
> Rafael
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/power: Don't make man pages executable
2017-12-20 0:36 ` Laura Abbott
@ 2017-12-20 1:36 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2017-12-20 1:36 UTC (permalink / raw)
To: Laura Abbott; +Cc: Len Brown, linux-kernel
On 12/20/2017 1:36 AM, Laura Abbott wrote:
> On 12/19/2017 03:48 PM, Rafael J. Wysocki wrote:
>> On 12/19/2017 8:54 PM, Laura Abbott wrote:
>>> rpm-lint flagged these as being executable:
>>>
>>> kernel-tools.x86_64: W: spurious-executable-perm
>>> /usr/share/man/man8/turbostat.8.gz
>>> kernel-tools.x86_64: W: spurious-executable-perm
>>> /usr/share/man/man8/x86_energy_perf_policy.8.gz
>>>
>>> Fix this
>>>
>>> Signed-off-by: Laura Abbott <labbott@redhat.com>
>>
>> Please CC PM stuff to linux-pm (which makes it easier to handle).
>>
>
> Neither of these are listed in MAINTAINERS so I missed sending to
> linux-pm. I'll remember for next time, do you want me to resend
> for tracking?
>
Yes, please.
Thanks,
Rafael
>
>>> ---
>>> tools/power/x86/turbostat/Makefile | 2 +-
>>> tools/power/x86/x86_energy_perf_policy/Makefile | 2 +-
>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/tools/power/x86/turbostat/Makefile
>>> b/tools/power/x86/turbostat/Makefile
>>> index a9bc914a8fe8..2ab25aa38263 100644
>>> --- a/tools/power/x86/turbostat/Makefile
>>> +++ b/tools/power/x86/turbostat/Makefile
>>> @@ -25,4 +25,4 @@ install : turbostat
>>> install -d $(DESTDIR)$(PREFIX)/bin
>>> install $(BUILD_OUTPUT)/turbostat
>>> $(DESTDIR)$(PREFIX)/bin/turbostat
>>> install -d $(DESTDIR)$(PREFIX)/share/man/man8
>>> - install turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
>>> + install -m 644 turbostat.8 $(DESTDIR)$(PREFIX)/share/man/man8
>>> diff --git a/tools/power/x86/x86_energy_perf_policy/Makefile
>>> b/tools/power/x86/x86_energy_perf_policy/Makefile
>>> index 2447b1bbaacf..f4534fb8b951 100644
>>> --- a/tools/power/x86/x86_energy_perf_policy/Makefile
>>> +++ b/tools/power/x86/x86_energy_perf_policy/Makefile
>>> @@ -24,5 +24,5 @@ install : x86_energy_perf_policy
>>> install -d $(DESTDIR)$(PREFIX)/bin
>>> install $(BUILD_OUTPUT)/x86_energy_perf_policy
>>> $(DESTDIR)$(PREFIX)/bin/x86_energy_perf_policy
>>> install -d $(DESTDIR)$(PREFIX)/share/man/man8
>>> - install x86_energy_perf_policy.8
>>> $(DESTDIR)$(PREFIX)/share/man/man8
>>> + install -m 644 x86_energy_perf_policy.8
>>> $(DESTDIR)$(PREFIX)/share/man/man8
>>
>>
>> Thanks,
>>
>> Rafael
>>
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-20 1:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-19 19:54 [PATCH] tools/power: Don't make man pages executable Laura Abbott
2017-12-19 23:48 ` Rafael J. Wysocki
2017-12-20 0:36 ` Laura Abbott
2017-12-20 1:36 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome