* [PATCH 0/2] Enable tertiary USB controller in OTG mode
@ 2026-02-06 10:46 Swati Agarwal
2026-02-06 10:46 ` [PATCH 1/2] arm64: dts: qcom: lemans-evk: Enable GPIO expander3 interrupt for Lemans EVK Swati Agarwal
2026-02-06 10:46 ` [PATCH 2/2] arm64: dts: qcom: lemans-evk: Enable the tertiary USB controller Swati Agarwal
0 siblings, 2 replies; 13+ messages in thread
From: Swati Agarwal @ 2026-02-06 10:46 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Swati Agarwal
Enable tertiary USB controller in OTG mode on lemans EVK platform.
This patch depends on:
https://lore.kernel.org/all/20260122092852.887624-1-swati.agarwal@oss.qualcomm.com/
Swati Agarwal (2):
arm64: dts: qcom: lemans-evk: Enable GPIO expander3 interrupt for
Lemans EVK
arm64: dts: qcom: lemans-evk: Enable the tertiary USB controller
arch/arm64/boot/dts/qcom/lemans-evk.dts | 66 +++++++++++++++++++++++++
arch/arm64/boot/dts/qcom/lemans.dtsi | 7 +++
2 files changed, 73 insertions(+)
--
2.34.1
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH 1/2] arm64: dts: qcom: lemans-evk: Enable GPIO expander3 interrupt for Lemans EVK 2026-02-06 10:46 [PATCH 0/2] Enable tertiary USB controller in OTG mode Swati Agarwal @ 2026-02-06 10:46 ` Swati Agarwal 2026-02-06 11:05 ` Konrad Dybcio 2026-02-06 12:12 ` Dmitry Baryshkov 2026-02-06 10:46 ` [PATCH 2/2] arm64: dts: qcom: lemans-evk: Enable the tertiary USB controller Swati Agarwal 1 sibling, 2 replies; 13+ messages in thread From: Swati Agarwal @ 2026-02-06 10:46 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-arm-msm, devicetree, linux-kernel, Swati Agarwal Enable PCA9538 expander3 as interrupt controller on Lemans EVK and configures the corresponding TLMM pins via pinctrl to operate as GPIO inputs with internal pull-ups. Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/lemans-evk.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/lemans-evk.dts b/arch/arm64/boot/dts/qcom/lemans-evk.dts index a549f7fe53a1..473cc2a81670 100644 --- a/arch/arm64/boot/dts/qcom/lemans-evk.dts +++ b/arch/arm64/boot/dts/qcom/lemans-evk.dts @@ -649,6 +649,12 @@ expander3: gpio@3b { reg = <0x3b>; #gpio-cells = <2>; gpio-controller; + #interrupt-cells = <2>; + interrupt-controller; + interrupt-parent = <&tlmm>; + interrupts = <39 IRQ_TYPE_LEVEL_LOW>; + pinctrl-names = "default"; + pinctrl-0 = <&expander3_int>; }; eeprom@50 { @@ -894,6 +900,13 @@ ethernet0_mdio: ethernet0-mdio-pins { }; }; + expander3_int: expander3-int-state { + pins = "gpio39"; + function = "gpio"; + input-enable; + bias-pull-up; + }; + pcie0_default_state: pcie0-default-state { clkreq-pins { pins = "gpio1"; -- 2.34.1 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: lemans-evk: Enable GPIO expander3 interrupt for Lemans EVK 2026-02-06 10:46 ` [PATCH 1/2] arm64: dts: qcom: lemans-evk: Enable GPIO expander3 interrupt for Lemans EVK Swati Agarwal @ 2026-02-06 11:05 ` Konrad Dybcio 2026-02-06 12:12 ` Dmitry Baryshkov 1 sibling, 0 replies; 13+ messages in thread From: Konrad Dybcio @ 2026-02-06 11:05 UTC (permalink / raw) To: Swati Agarwal, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-arm-msm, devicetree, linux-kernel On 2/6/26 11:46 AM, Swati Agarwal wrote: > Enable PCA9538 expander3 as interrupt controller on Lemans EVK and > configures the corresponding TLMM pins via pinctrl to operate as GPIO > inputs with internal pull-ups. > > Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/lemans-evk.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/lemans-evk.dts b/arch/arm64/boot/dts/qcom/lemans-evk.dts > index a549f7fe53a1..473cc2a81670 100644 > --- a/arch/arm64/boot/dts/qcom/lemans-evk.dts > +++ b/arch/arm64/boot/dts/qcom/lemans-evk.dts > @@ -649,6 +649,12 @@ expander3: gpio@3b { > reg = <0x3b>; > #gpio-cells = <2>; > gpio-controller; > + #interrupt-cells = <2>; > + interrupt-controller; > + interrupt-parent = <&tlmm>; > + interrupts = <39 IRQ_TYPE_LEVEL_LOW>; > + pinctrl-names = "default"; > + pinctrl-0 = <&expander3_int>; property-n property-names in this order, please Could you wire up the interrupts from other expanders while at it? > }; > > eeprom@50 { > @@ -894,6 +900,13 @@ ethernet0_mdio: ethernet0-mdio-pins { > }; > }; > > + expander3_int: expander3-int-state { > + pins = "gpio39"; > + function = "gpio"; > + input-enable; input-enable is not allowed for TLMM GPIOs, please make sure to run "make dtbs_check" (or at least make [...] CHECK_DTBS=1 qcom/lemans-evk.dtb) before submitting Konrad ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: lemans-evk: Enable GPIO expander3 interrupt for Lemans EVK 2026-02-06 10:46 ` [PATCH 1/2] arm64: dts: qcom: lemans-evk: Enable GPIO expander3 interrupt for Lemans EVK Swati Agarwal 2026-02-06 11:05 ` Konrad Dybcio @ 2026-02-06 12:12 ` Dmitry Baryshkov 2026-02-06 12:24 ` Konrad Dybcio 1 sibling, 1 reply; 13+ messages in thread From: Dmitry Baryshkov @ 2026-02-06 12:12 UTC (permalink / raw) To: Swati Agarwal Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel On Fri, Feb 06, 2026 at 04:16:41PM +0530, Swati Agarwal wrote: > Enable PCA9538 expander3 as interrupt controller on Lemans EVK and > configures the corresponding TLMM pins via pinctrl to operate as GPIO > inputs with internal pull-ups. > > Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/lemans-evk.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/lemans-evk.dts b/arch/arm64/boot/dts/qcom/lemans-evk.dts > index a549f7fe53a1..473cc2a81670 100644 > --- a/arch/arm64/boot/dts/qcom/lemans-evk.dts > +++ b/arch/arm64/boot/dts/qcom/lemans-evk.dts > @@ -649,6 +649,12 @@ expander3: gpio@3b { > reg = <0x3b>; > #gpio-cells = <2>; > gpio-controller; > + #interrupt-cells = <2>; > + interrupt-controller; > + interrupt-parent = <&tlmm>; > + interrupts = <39 IRQ_TYPE_LEVEL_LOW>; interrupts-extended, please. > + pinctrl-names = "default"; > + pinctrl-0 = <&expander3_int>; > }; > > eeprom@50 { -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: lemans-evk: Enable GPIO expander3 interrupt for Lemans EVK 2026-02-06 12:12 ` Dmitry Baryshkov @ 2026-02-06 12:24 ` Konrad Dybcio 0 siblings, 0 replies; 13+ messages in thread From: Konrad Dybcio @ 2026-02-06 12:24 UTC (permalink / raw) To: Dmitry Baryshkov, Swati Agarwal Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel On 2/6/26 1:12 PM, Dmitry Baryshkov wrote: > On Fri, Feb 06, 2026 at 04:16:41PM +0530, Swati Agarwal wrote: >> Enable PCA9538 expander3 as interrupt controller on Lemans EVK and >> configures the corresponding TLMM pins via pinctrl to operate as GPIO >> inputs with internal pull-ups. >> >> Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com> >> --- >> arch/arm64/boot/dts/qcom/lemans-evk.dts | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/lemans-evk.dts b/arch/arm64/boot/dts/qcom/lemans-evk.dts >> index a549f7fe53a1..473cc2a81670 100644 >> --- a/arch/arm64/boot/dts/qcom/lemans-evk.dts >> +++ b/arch/arm64/boot/dts/qcom/lemans-evk.dts >> @@ -649,6 +649,12 @@ expander3: gpio@3b { >> reg = <0x3b>; >> #gpio-cells = <2>; >> gpio-controller; >> + #interrupt-cells = <2>; >> + interrupt-controller; >> + interrupt-parent = <&tlmm>; >> + interrupts = <39 IRQ_TYPE_LEVEL_LOW>; > > interrupts-extended, please. I think interrupt-parent makes sense for a child that's also an interrupt provider, IDK if interrupt-extended maintains the topology Konrad ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: lemans-evk: Enable the tertiary USB controller 2026-02-06 10:46 [PATCH 0/2] Enable tertiary USB controller in OTG mode Swati Agarwal 2026-02-06 10:46 ` [PATCH 1/2] arm64: dts: qcom: lemans-evk: Enable GPIO expander3 interrupt for Lemans EVK Swati Agarwal @ 2026-02-06 10:46 ` Swati Agarwal 2026-02-06 10:51 ` Krzysztof Kozlowski ` (2 more replies) 1 sibling, 3 replies; 13+ messages in thread From: Swati Agarwal @ 2026-02-06 10:46 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-arm-msm, devicetree, linux-kernel, Swati Agarwal Enable the tertiary usb controller connected to micro usb port in OTG mode on Lemans EVK platform. Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/lemans-evk.dts | 53 +++++++++++++++++++++++++ arch/arm64/boot/dts/qcom/lemans.dtsi | 7 ++++ 2 files changed, 60 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/lemans-evk.dts b/arch/arm64/boot/dts/qcom/lemans-evk.dts index 473cc2a81670..71d1793dac3c 100644 --- a/arch/arm64/boot/dts/qcom/lemans-evk.dts +++ b/arch/arm64/boot/dts/qcom/lemans-evk.dts @@ -107,6 +107,25 @@ usb1_ss_in: endpoint { }; }; + connector-2 { + compatible = "gpio-usb-b-connector", "usb-b-connector"; + label = "micro-USB"; + type = "micro"; + + id-gpios = <&pmm8654au_2_gpios 11 GPIO_ACTIVE_HIGH>; + vbus-gpios = <&expander3 3 GPIO_ACTIVE_HIGH>; + vbus-supply = <&vbus_supply_regulator_2>; + + pinctrl-names = "default"; + pinctrl-0 = <&usb2_id>; + + port { + usb2_con_hs_ep: endpoint { + remote-endpoint = <&usb_2_dwc3_hs>; + }; + }; + }; + edp0-connector { compatible = "dp-connector"; label = "EDP0"; @@ -190,6 +209,16 @@ vbus_supply_regulator_1: regulator-vbus-supply-1 { enable-active-high; }; + vbus_supply_regulator_2: vbus-supply-regulator_2 { + compatible = "regulator-fixed"; + regulator-name = "vbus_supply_2"; + gpio = <&pmm8654au_1_gpios 9 GPIO_ACTIVE_HIGH>; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + regulator-boot-on; + enable-active-high; + }; + vmmc_sdc: regulator-vmmc-sdc { compatible = "regulator-fixed"; @@ -795,6 +824,14 @@ usb1_intr: usb1-intr-state { bias-pull-up; power-source = <0>; }; + + usb2_id: usb2-id-state { + pins = "gpio11"; + function = "normal"; + input-enable; + bias-pull-up; + power-source = <0>; + }; }; &qup_i2c19_default { @@ -1143,6 +1180,22 @@ &usb_1_qmpphy { status = "okay"; }; +&usb_2 { + status = "okay"; +}; + +&usb_2_dwc3_hs { + remote-endpoint = <&usb2_con_hs_ep>; +}; + +&usb_2_hsphy { + vdda-pll-supply = <&vreg_l7a>; + vdda18-supply = <&vreg_l6c>; + vdda33-supply = <&vreg_l9a>; + + status = "okay"; +}; + &xo_board_clk { clock-frequency = <38400000>; }; diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi index 808827b83553..2710927c9172 100644 --- a/arch/arm64/boot/dts/qcom/lemans.dtsi +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi @@ -4270,7 +4270,14 @@ usb_2: usb@a400000 { snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; + usb-role-switch; status = "disabled"; + + port { + usb_2_dwc3_hs: endpoint { + }; + }; + }; tcsr_mutex: hwlock@1f40000 { -- 2.34.1 ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: lemans-evk: Enable the tertiary USB controller 2026-02-06 10:46 ` [PATCH 2/2] arm64: dts: qcom: lemans-evk: Enable the tertiary USB controller Swati Agarwal @ 2026-02-06 10:51 ` Krzysztof Kozlowski 2026-02-06 11:07 ` Konrad Dybcio 2026-02-06 12:14 ` Dmitry Baryshkov 2 siblings, 0 replies; 13+ messages in thread From: Krzysztof Kozlowski @ 2026-02-06 10:51 UTC (permalink / raw) To: Swati Agarwal, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-arm-msm, devicetree, linux-kernel On 06/02/2026 11:46, Swati Agarwal wrote: > + > edp0-connector { > compatible = "dp-connector"; > label = "EDP0"; > @@ -190,6 +209,16 @@ vbus_supply_regulator_1: regulator-vbus-supply-1 { > enable-active-high; > }; > > + vbus_supply_regulator_2: vbus-supply-regulator_2 { Do not introduce your own coding style. How the nodes are called? Please stop posting downstream code to us, but take and work on upstream. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: lemans-evk: Enable the tertiary USB controller 2026-02-06 10:46 ` [PATCH 2/2] arm64: dts: qcom: lemans-evk: Enable the tertiary USB controller Swati Agarwal 2026-02-06 10:51 ` Krzysztof Kozlowski @ 2026-02-06 11:07 ` Konrad Dybcio 2026-02-06 12:14 ` Dmitry Baryshkov 2 siblings, 0 replies; 13+ messages in thread From: Konrad Dybcio @ 2026-02-06 11:07 UTC (permalink / raw) To: Swati Agarwal, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-arm-msm, devicetree, linux-kernel On 2/6/26 11:46 AM, Swati Agarwal wrote: > Enable the tertiary usb controller connected to micro usb port in OTG mode > on Lemans EVK platform. > > Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com> > --- [...] > + vbus_supply_regulator_2: vbus-supply-regulator_2 { > + compatible = "regulator-fixed"; > + regulator-name = "vbus_supply_2"; > + gpio = <&pmm8654au_1_gpios 9 GPIO_ACTIVE_HIGH>; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + regulator-boot-on; Are you sure it's boot-on? vbus_supply_regulator_0 isn't marked as such, or maybe is that one wrong? [...] > diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi > index 808827b83553..2710927c9172 100644 > --- a/arch/arm64/boot/dts/qcom/lemans.dtsi > +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi > @@ -4270,7 +4270,14 @@ usb_2: usb@a400000 { > snps,dis-u1-entry-quirk; > snps,dis-u2-entry-quirk; > > + usb-role-switch; > status = "disabled"; Please leave a \n above 'status' Konrad ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: lemans-evk: Enable the tertiary USB controller 2026-02-06 10:46 ` [PATCH 2/2] arm64: dts: qcom: lemans-evk: Enable the tertiary USB controller Swati Agarwal 2026-02-06 10:51 ` Krzysztof Kozlowski 2026-02-06 11:07 ` Konrad Dybcio @ 2026-02-06 12:14 ` Dmitry Baryshkov 2026-02-10 14:59 ` Swati Agarwal 2 siblings, 1 reply; 13+ messages in thread From: Dmitry Baryshkov @ 2026-02-06 12:14 UTC (permalink / raw) To: Swati Agarwal Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel On Fri, Feb 06, 2026 at 04:16:42PM +0530, Swati Agarwal wrote: > Enable the tertiary usb controller connected to micro usb port in OTG mode > on Lemans EVK platform. > > Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/lemans-evk.dts | 53 +++++++++++++++++++++++++ > arch/arm64/boot/dts/qcom/lemans.dtsi | 7 ++++ > 2 files changed, 60 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi > index 808827b83553..2710927c9172 100644 > --- a/arch/arm64/boot/dts/qcom/lemans.dtsi > +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi > @@ -4270,7 +4270,14 @@ usb_2: usb@a400000 { > snps,dis-u1-entry-quirk; > snps,dis-u2-entry-quirk; > > + usb-role-switch; > status = "disabled"; > + > + port { > + usb_2_dwc3_hs: endpoint { > + }; Is it USB-2 only? If not, please define both ports. > + }; > + > }; > > tcsr_mutex: hwlock@1f40000 { > -- > 2.34.1 > -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: lemans-evk: Enable the tertiary USB controller 2026-02-06 12:14 ` Dmitry Baryshkov @ 2026-02-10 14:59 ` Swati Agarwal 2026-02-10 21:08 ` Dmitry Baryshkov 0 siblings, 1 reply; 13+ messages in thread From: Swati Agarwal @ 2026-02-10 14:59 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel On Fri, Feb 6, 2026 at 5:44 PM Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> wrote: > > On Fri, Feb 06, 2026 at 04:16:42PM +0530, Swati Agarwal wrote: > > Enable the tertiary usb controller connected to micro usb port in OTG mode > > on Lemans EVK platform. > > > > Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com> > > --- > > arch/arm64/boot/dts/qcom/lemans-evk.dts | 53 +++++++++++++++++++++++++ > > arch/arm64/boot/dts/qcom/lemans.dtsi | 7 ++++ > > 2 files changed, 60 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi > > index 808827b83553..2710927c9172 100644 > > --- a/arch/arm64/boot/dts/qcom/lemans.dtsi > > +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi > > @@ -4270,7 +4270,14 @@ usb_2: usb@a400000 { > > snps,dis-u1-entry-quirk; > > snps,dis-u2-entry-quirk; > > > > + usb-role-switch; > > status = "disabled"; > > + > > + port { > > + usb_2_dwc3_hs: endpoint { > > + }; > > Is it USB-2 only? If not, please define both ports. Hi Dmitry, USB-2 is micro USB having only HS-PHY so only one port is needed. Regards, Swati > > > + }; > > + > > }; > > > > tcsr_mutex: hwlock@1f40000 { > > -- > > 2.34.1 > > > > -- > With best wishes > Dmitry ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: lemans-evk: Enable the tertiary USB controller 2026-02-10 14:59 ` Swati Agarwal @ 2026-02-10 21:08 ` Dmitry Baryshkov 2026-02-11 0:23 ` Krishna Kurapati PSSNV 0 siblings, 1 reply; 13+ messages in thread From: Dmitry Baryshkov @ 2026-02-10 21:08 UTC (permalink / raw) To: Swati Agarwal Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel On Tue, Feb 10, 2026 at 08:29:50PM +0530, Swati Agarwal wrote: > On Fri, Feb 6, 2026 at 5:44 PM Dmitry Baryshkov > <dmitry.baryshkov@oss.qualcomm.com> wrote: > > > > On Fri, Feb 06, 2026 at 04:16:42PM +0530, Swati Agarwal wrote: > > > Enable the tertiary usb controller connected to micro usb port in OTG mode > > > on Lemans EVK platform. > > > > > > Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com> > > > --- > > > arch/arm64/boot/dts/qcom/lemans-evk.dts | 53 +++++++++++++++++++++++++ > > > arch/arm64/boot/dts/qcom/lemans.dtsi | 7 ++++ > > > 2 files changed, 60 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi > > > index 808827b83553..2710927c9172 100644 > > > --- a/arch/arm64/boot/dts/qcom/lemans.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi > > > @@ -4270,7 +4270,14 @@ usb_2: usb@a400000 { > > > snps,dis-u1-entry-quirk; > > > snps,dis-u2-entry-quirk; > > > > > > + usb-role-switch; > > > status = "disabled"; > > > + > > > + port { > > > + usb_2_dwc3_hs: endpoint { > > > + }; > > > > Is it USB-2 only? If not, please define both ports. > Hi Dmitry, > USB-2 is micro USB having only HS-PHY so only one port is needed. micro USB is on the connector side. Here you are describing the USB controller. Is it also HS-only? If the controller supports HS and SS, you need to have two ports here. > > Regards, > Swati > > > > > + }; > > > + > > > }; > > > > > > tcsr_mutex: hwlock@1f40000 { > > > -- > > > 2.34.1 > > > > > > > -- > > With best wishes > > Dmitry -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: lemans-evk: Enable the tertiary USB controller 2026-02-10 21:08 ` Dmitry Baryshkov @ 2026-02-11 0:23 ` Krishna Kurapati PSSNV 2026-02-11 1:47 ` Dmitry Baryshkov 0 siblings, 1 reply; 13+ messages in thread From: Krishna Kurapati PSSNV @ 2026-02-11 0:23 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Swati Agarwal, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel On Wed, Feb 11, 2026 at 2:39 AM Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> wrote: > > On Tue, Feb 10, 2026 at 08:29:50PM +0530, Swati Agarwal wrote: > > On Fri, Feb 6, 2026 at 5:44 PM Dmitry Baryshkov > > <dmitry.baryshkov@oss.qualcomm.com> wrote: > > > > > > On Fri, Feb 06, 2026 at 04:16:42PM +0530, Swati Agarwal wrote: > > > > Enable the tertiary usb controller connected to micro usb port in OTG mode > > > > on Lemans EVK platform. > > > > > > > > Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com> > > > > --- > > > > arch/arm64/boot/dts/qcom/lemans-evk.dts | 53 +++++++++++++++++++++++++ > > > > arch/arm64/boot/dts/qcom/lemans.dtsi | 7 ++++ > > > > 2 files changed, 60 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi > > > > index 808827b83553..2710927c9172 100644 > > > > --- a/arch/arm64/boot/dts/qcom/lemans.dtsi > > > > +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi > > > > @@ -4270,7 +4270,14 @@ usb_2: usb@a400000 { > > > > snps,dis-u1-entry-quirk; > > > > snps,dis-u2-entry-quirk; > > > > > > > > + usb-role-switch; > > > > status = "disabled"; > > > > + > > > > + port { > > > > + usb_2_dwc3_hs: endpoint { > > > > + }; > > > > > > Is it USB-2 only? If not, please define both ports. > > Hi Dmitry, > > USB-2 is micro USB having only HS-PHY so only one port is needed. > > micro USB is on the connector side. Here you are describing the USB > controller. Is it also HS-only? If the controller supports HS and SS, > you need to have two ports here. > Yes. Tertiary controller on lemans is HS only controller. Regards, Krishna, ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: lemans-evk: Enable the tertiary USB controller 2026-02-11 0:23 ` Krishna Kurapati PSSNV @ 2026-02-11 1:47 ` Dmitry Baryshkov 0 siblings, 0 replies; 13+ messages in thread From: Dmitry Baryshkov @ 2026-02-11 1:47 UTC (permalink / raw) To: Krishna Kurapati PSSNV Cc: Swati Agarwal, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel On Wed, 11 Feb 2026 at 02:23, Krishna Kurapati PSSNV <krishna.kurapati@oss.qualcomm.com> wrote: > > On Wed, Feb 11, 2026 at 2:39 AM Dmitry Baryshkov > <dmitry.baryshkov@oss.qualcomm.com> wrote: > > > > On Tue, Feb 10, 2026 at 08:29:50PM +0530, Swati Agarwal wrote: > > > On Fri, Feb 6, 2026 at 5:44 PM Dmitry Baryshkov > > > <dmitry.baryshkov@oss.qualcomm.com> wrote: > > > > > > > > On Fri, Feb 06, 2026 at 04:16:42PM +0530, Swati Agarwal wrote: > > > > > Enable the tertiary usb controller connected to micro usb port in OTG mode > > > > > on Lemans EVK platform. > > > > > > > > > > Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com> > > > > > --- > > > > > arch/arm64/boot/dts/qcom/lemans-evk.dts | 53 +++++++++++++++++++++++++ > > > > > arch/arm64/boot/dts/qcom/lemans.dtsi | 7 ++++ > > > > > 2 files changed, 60 insertions(+) > > > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi > > > > > index 808827b83553..2710927c9172 100644 > > > > > --- a/arch/arm64/boot/dts/qcom/lemans.dtsi > > > > > +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi > > > > > @@ -4270,7 +4270,14 @@ usb_2: usb@a400000 { > > > > > snps,dis-u1-entry-quirk; > > > > > snps,dis-u2-entry-quirk; > > > > > > > > > > + usb-role-switch; > > > > > status = "disabled"; > > > > > + > > > > > + port { > > > > > + usb_2_dwc3_hs: endpoint { > > > > > + }; > > > > > > > > Is it USB-2 only? If not, please define both ports. > > > Hi Dmitry, > > > USB-2 is micro USB having only HS-PHY so only one port is needed. > > > > micro USB is on the connector side. Here you are describing the USB > > controller. Is it also HS-only? If the controller supports HS and SS, > > you need to have two ports here. > > > > > Yes. Tertiary controller on lemans is HS only controller. Great! Is it written in the commit message? No. > > Regards, > Krishna, -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2026-02-11 1:47 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2026-02-06 10:46 [PATCH 0/2] Enable tertiary USB controller in OTG mode Swati Agarwal 2026-02-06 10:46 ` [PATCH 1/2] arm64: dts: qcom: lemans-evk: Enable GPIO expander3 interrupt for Lemans EVK Swati Agarwal 2026-02-06 11:05 ` Konrad Dybcio 2026-02-06 12:12 ` Dmitry Baryshkov 2026-02-06 12:24 ` Konrad Dybcio 2026-02-06 10:46 ` [PATCH 2/2] arm64: dts: qcom: lemans-evk: Enable the tertiary USB controller Swati Agarwal 2026-02-06 10:51 ` Krzysztof Kozlowski 2026-02-06 11:07 ` Konrad Dybcio 2026-02-06 12:14 ` Dmitry Baryshkov 2026-02-10 14:59 ` Swati Agarwal 2026-02-10 21:08 ` Dmitry Baryshkov 2026-02-11 0:23 ` Krishna Kurapati PSSNV 2026-02-11 1:47 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®