From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Zhan Xusheng <zhanxusheng1024@gmail.com>, <peterz@infradead.org>
Cc: <mingo@redhat.com>, <juri.lelli@redhat.com>,
<vincent.guittot@linaro.org>, <dietmar.eggemann@arm.com>,
<rostedt@goodmis.org>, <bsegall@google.com>, <mgorman@suse.de>,
<vschneid@redhat.com>, <linux-sched@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Zhan Xusheng <zhanxusheng@xiaomi.com>
Subject: Re: [PATCH RESEND] sched/rt: remove empty sched_rt_do_global() helper
Date: Mon, 12 Jan 2026 11:41:58 +0530 [thread overview]
Message-ID: <e9f5eb88-e35e-48b2-9257-62e7073bdfa1@amd.com> (raw)
In-Reply-To: <20260112040241.13346-1-zhanxusheng@xiaomi.com>
Hello Zhan,
On 1/12/2026 9:32 AM, Zhan Xusheng wrote:
> sched_rt_do_global() is an empty helper that has no effect on
> RT bandwidth sysctl handling.
Perhaps you can add small comment indicating its prior function:
sched_rt_do_global() was responsible for managing the RT throttling
parameters before the introduction of the fair server.
Since commit 5f6bd380c7bd ("sched/rt: Remove default bandwidth control")
sched_rt_do_global() turned obsolete but the empty helper was retained.
>
> Remove the unused function and its call site to simplify the
> sysctl update path.
>
> No functional change intended.
>
> Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
Feel free to include:
Reviewed-and-tested-by: K Prateek Nayak <kprateek.nayak@amd.com>
--
Thanks and Regards,
Prateek
next prev parent reply other threads:[~2026-01-12 6:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 7:37 [PATCH] " Zhan Xusheng
2026-01-12 4:02 ` [PATCH RESEND] " Zhan Xusheng
2026-01-12 6:11 ` K Prateek Nayak [this message]
2026-01-12 7:46 ` [PATCH v2] " Zhan Xusheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9f5eb88-e35e-48b2-9257-62e7073bdfa1@amd.com \
--to=kprateek.nayak@amd.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sched@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=zhanxusheng1024@gmail.com \
--cc=zhanxusheng@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®