* [PATCH] sched/rt: remove empty sched_rt_do_global() helper
@ 2025-12-17 7:37 Zhan Xusheng
2026-01-12 4:02 ` [PATCH RESEND] " Zhan Xusheng
0 siblings, 1 reply; 4+ messages in thread
From: Zhan Xusheng @ 2025-12-17 7:37 UTC (permalink / raw)
To: peterz
Cc: mingo, juri.lelli, vincent.guittot, dietmar.eggemann, rostedt,
bsegall, mgorman, vschneid, linux-sched, linux-kernel,
Zhan Xusheng
sched_rt_do_global() is an empty helper that has no effect on
RT bandwidth sysctl handling.
Remove the unused function and its call site to simplify the
sysctl update path.
No functional change intended.
Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
---
kernel/sched/rt.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index f1867fe8e5c5..90f62de52f63 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -2854,10 +2854,6 @@ static int sched_rt_global_validate(void)
return 0;
}
-static void sched_rt_do_global(void)
-{
-}
-
static int sched_rt_handler(const struct ctl_table *table, int write, void *buffer,
size_t *lenp, loff_t *ppos)
{
@@ -2885,7 +2881,6 @@ static int sched_rt_handler(const struct ctl_table *table, int write, void *buff
if (ret)
goto undo;
- sched_rt_do_global();
sched_dl_do_global();
}
if (0) {
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH RESEND] sched/rt: remove empty sched_rt_do_global() helper
2025-12-17 7:37 [PATCH] sched/rt: remove empty sched_rt_do_global() helper Zhan Xusheng
@ 2026-01-12 4:02 ` Zhan Xusheng
2026-01-12 6:11 ` K Prateek Nayak
0 siblings, 1 reply; 4+ messages in thread
From: Zhan Xusheng @ 2026-01-12 4:02 UTC (permalink / raw)
To: peterz
Cc: mingo, juri.lelli, vincent.guittot, dietmar.eggemann, rostedt,
bsegall, mgorman, vschneid, linux-sched, linux-kernel,
Zhan Xusheng
sched_rt_do_global() is an empty helper that has no effect on
RT bandwidth sysctl handling.
Remove the unused function and its call site to simplify the
sysctl update path.
No functional change intended.
Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
---
kernel/sched/rt.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index f1867fe8e5c5..90f62de52f63 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -2854,10 +2854,6 @@ static int sched_rt_global_validate(void)
return 0;
}
-static void sched_rt_do_global(void)
-{
-}
-
static int sched_rt_handler(const struct ctl_table *table, int write, void *buffer,
size_t *lenp, loff_t *ppos)
{
@@ -2885,7 +2881,6 @@ static int sched_rt_handler(const struct ctl_table *table, int write, void *buff
if (ret)
goto undo;
- sched_rt_do_global();
sched_dl_do_global();
}
if (0) {
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH RESEND] sched/rt: remove empty sched_rt_do_global() helper
2026-01-12 4:02 ` [PATCH RESEND] " Zhan Xusheng
@ 2026-01-12 6:11 ` K Prateek Nayak
2026-01-12 7:46 ` [PATCH v2] " Zhan Xusheng
0 siblings, 1 reply; 4+ messages in thread
From: K Prateek Nayak @ 2026-01-12 6:11 UTC (permalink / raw)
To: Zhan Xusheng, peterz
Cc: mingo, juri.lelli, vincent.guittot, dietmar.eggemann, rostedt,
bsegall, mgorman, vschneid, linux-sched, linux-kernel,
Zhan Xusheng
Hello Zhan,
On 1/12/2026 9:32 AM, Zhan Xusheng wrote:
> sched_rt_do_global() is an empty helper that has no effect on
> RT bandwidth sysctl handling.
Perhaps you can add small comment indicating its prior function:
sched_rt_do_global() was responsible for managing the RT throttling
parameters before the introduction of the fair server.
Since commit 5f6bd380c7bd ("sched/rt: Remove default bandwidth control")
sched_rt_do_global() turned obsolete but the empty helper was retained.
>
> Remove the unused function and its call site to simplify the
> sysctl update path.
>
> No functional change intended.
>
> Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
Feel free to include:
Reviewed-and-tested-by: K Prateek Nayak <kprateek.nayak@amd.com>
--
Thanks and Regards,
Prateek
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] sched/rt: remove empty sched_rt_do_global() helper
2026-01-12 6:11 ` K Prateek Nayak
@ 2026-01-12 7:46 ` Zhan Xusheng
0 siblings, 0 replies; 4+ messages in thread
From: Zhan Xusheng @ 2026-01-12 7:46 UTC (permalink / raw)
To: peterz
Cc: mingo, juri.lelli, vincent.guittot, dietmar.eggemann, rostedt,
bsegall, mgorman, vschneid, kprateek.nayak, linux-sched,
linux-kernel, Zhan Xusheng
sched_rt_do_global() is an empty helper that has no effect on
RT bandwidth sysctl handling.
Historically, sched_rt_do_global() was responsible for managing
RT throttling parameters before the introduction of the fair
server. Since commit 5f6bd380c7bd ("sched/rt: Remove default
bandwidth control"), the function became obsolete, but the empty
helper and its call site were retained.
Remove the unused function and its call site to simplify the
sysctl update path.
No functional change intended.
Reviewed-and-tested-by: K Prateek Nayak <kprateek.nayak@amd.com>
Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
---
kernel/sched/rt.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index f1867fe8e5c5..90f62de52f63 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -2854,10 +2854,6 @@ static int sched_rt_global_validate(void)
return 0;
}
-static void sched_rt_do_global(void)
-{
-}
-
static int sched_rt_handler(const struct ctl_table *table, int write, void *buffer,
size_t *lenp, loff_t *ppos)
{
@@ -2885,7 +2881,6 @@ static int sched_rt_handler(const struct ctl_table *table, int write, void *buff
if (ret)
goto undo;
- sched_rt_do_global();
sched_dl_do_global();
}
if (0) {
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-01-12 7:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-17 7:37 [PATCH] sched/rt: remove empty sched_rt_do_global() helper Zhan Xusheng
2026-01-12 4:02 ` [PATCH RESEND] " Zhan Xusheng
2026-01-12 6:11 ` K Prateek Nayak
2026-01-12 7:46 ` [PATCH v2] " Zhan Xusheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®