* [PATCH] virt/steal_governor: Remove redundant delay filed
@ 2026-11-18 7:27 Fushuai Wang
2026-11-18 9:04 ` Shrikanth Hegde
0 siblings, 1 reply; 3+ messages in thread
From: Fushuai Wang @ 2026-11-18 7:27 UTC (permalink / raw)
To: sshegde, yury.norov; +Cc: wangfushuai, linux-kernel
From: Fushuai Wang <wangfushuai@baidu.com>
The 'delay' member in struct steal_governor is just a cache for
msecs_to_jiffies(interval_ms). The duplicate state is confusing
and adds no value. Use msecs_to_jiffies() directly at the schedule
site and remove the 'delay' field.
Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
---
drivers/virt/steal_governor.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/virt/steal_governor.c b/drivers/virt/steal_governor.c
index 6e31f9923dea..8af6c02c7e77 100644
--- a/drivers/virt/steal_governor.c
+++ b/drivers/virt/steal_governor.c
@@ -38,7 +38,6 @@
struct steal_governor {
ktime_t time;
u64 steal;
- unsigned long delay;
unsigned int interval_ms;
unsigned int high_threshold;
unsigned int low_threshold;
@@ -252,7 +251,7 @@ static void steal_governor_loop(struct work_struct *work)
}
requeue_work:
- schedule_delayed_work(&sg_ctx.work, sg_ctx.delay);
+ schedule_delayed_work(&sg_ctx.work, msecs_to_jiffies(sg_ctx.interval_ms));
}
static int __init steal_governor_init(void)
@@ -270,11 +269,10 @@ static int __init steal_governor_init(void)
return -EINVAL;
}
- sg_ctx.delay = msecs_to_jiffies(sg_ctx.interval_ms);
INIT_DELAYED_WORK(&sg_ctx.work, steal_governor_loop);
sg_ctx.steal = get_system_steal_time();
sg_ctx.time = ktime_get();
- schedule_delayed_work(&sg_ctx.work, sg_ctx.delay);
+ schedule_delayed_work(&sg_ctx.work, msecs_to_jiffies(sg_ctx.interval_ms));
pr_info("enabled. interval: %ums, high_threshold: %u, low_threshold: %u\n",
sg_ctx.interval_ms, sg_ctx.high_threshold, sg_ctx.low_threshold);
--
2.36.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] virt/steal_governor: Remove redundant delay filed
2026-11-18 7:27 [PATCH] virt/steal_governor: Remove redundant delay filed Fushuai Wang
@ 2026-11-18 9:04 ` Shrikanth Hegde
2026-11-18 9:16 ` fushuai.wang
0 siblings, 1 reply; 3+ messages in thread
From: Shrikanth Hegde @ 2026-11-18 9:04 UTC (permalink / raw)
To: Fushuai Wang, yury.norov; +Cc: wangfushuai, linux-kernel
Hi.
On 11/18/26 12:57 PM, Fushuai Wang wrote:
> From: Fushuai Wang <wangfushuai@baidu.com>
>
> The 'delay' member in struct steal_governor is just a cache for
> msecs_to_jiffies(interval_ms). The duplicate state is confusing
> and adds no value. Use msecs_to_jiffies() directly at the schedule
> site and remove the 'delay' field.
>
I guess you haven't seen the below change which is in tip tree.
https://lore.kernel.org/all/179421651800.2093942.14148413791803216183.tip-bot2@tip-bot2/
With that, we don't need the below change, since there is no more redundant field.
> Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
> ---
> drivers/virt/steal_governor.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/virt/steal_governor.c b/drivers/virt/steal_governor.c
> index 6e31f9923dea..8af6c02c7e77 100644
> --- a/drivers/virt/steal_governor.c
> +++ b/drivers/virt/steal_governor.c
> @@ -38,7 +38,6 @@
> struct steal_governor {
> ktime_t time;
> u64 steal;
> - unsigned long delay;
> unsigned int interval_ms;
> unsigned int high_threshold;
> unsigned int low_threshold;
> @@ -252,7 +251,7 @@ static void steal_governor_loop(struct work_struct *work)
> }
>
> requeue_work:
> - schedule_delayed_work(&sg_ctx.work, sg_ctx.delay);
> + schedule_delayed_work(&sg_ctx.work, msecs_to_jiffies(sg_ctx.interval_ms));
> }
>
> static int __init steal_governor_init(void)
> @@ -270,11 +269,10 @@ static int __init steal_governor_init(void)
> return -EINVAL;
> }
>
> - sg_ctx.delay = msecs_to_jiffies(sg_ctx.interval_ms);
> INIT_DELAYED_WORK(&sg_ctx.work, steal_governor_loop);
> sg_ctx.steal = get_system_steal_time();
> sg_ctx.time = ktime_get();
> - schedule_delayed_work(&sg_ctx.work, sg_ctx.delay);
> + schedule_delayed_work(&sg_ctx.work, msecs_to_jiffies(sg_ctx.interval_ms));
> pr_info("enabled. interval: %ums, high_threshold: %u, low_threshold: %u\n",
> sg_ctx.interval_ms, sg_ctx.high_threshold, sg_ctx.low_threshold);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] virt/steal_governor: Remove redundant delay filed
2026-11-18 9:04 ` Shrikanth Hegde
@ 2026-11-18 9:16 ` fushuai.wang
0 siblings, 0 replies; 3+ messages in thread
From: fushuai.wang @ 2026-11-18 9:16 UTC (permalink / raw)
To: Shrikanth Hegde, yury.norov; +Cc: wangfushuai, linux-kernel
2026年11月18日 17:04, "Shrikanth Hegde" <sshegde@linux.ibm.com mailto:sshegde@linux.ibm.com?to=%22Shrikanth%20Hegde%22%20%3Csshegde%40linux.ibm.com%3E > 写到:
>
> Hi.
>
> On 11/18/26 12:57 PM, Fushuai Wang wrote:
>
> >
> > From: Fushuai Wang <wangfushuai@baidu.com>
> > The 'delay' member in struct steal_governor is just a cache for
> > msecs_to_jiffies(interval_ms). The duplicate state is confusing
> > and adds no value. Use msecs_to_jiffies() directly at the schedule
> > site and remove the 'delay' field.
> >
> I guess you haven't seen the below change which is in tip tree.
> https://lore.kernel.org/all/179421651800.2093942.14148413791803216183.tip-bot2@tip-bot2/
>
> With that, we don't need the below change, since there is no more redundant field.
>
Sorry I missed this, please ignore this mail.
Regards,
Fushuai.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-18 9:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-18 7:27 [PATCH] virt/steal_governor: Remove redundant delay filed Fushuai Wang
2026-11-18 9:04 ` Shrikanth Hegde
2026-11-18 9:16 ` fushuai.wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®