[PATCH] ARM: vexpress/spc: Delete an error message for a failed memory allocation in two functions

[PATCH] ARM: vexpress/spc: Delete an error message for a failed memory allocation in two functions

[SF Markus Elfring]

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 3 Oct 2017 10:30:07 +0200

Omit extra messages for a memory allocation failure in these functions.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 arch/arm/mach-vexpress/spc.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/arch/arm/mach-vexpress/spc.c b/arch/arm/mach-vexpress/spc.c
index fe488523694c..21c064267af5 100644
--- a/arch/arm/mach-vexpress/spc.c
+++ b/arch/arm/mach-vexpress/spc.c
@@ -451,10 +451,8 @@ int __init ve_spc_init(void __iomem *baseaddr, u32 a15_clusid, int irq)
 {
 	int ret;
 	info = kzalloc(sizeof(*info), GFP_KERNEL);
-	if (!info) {
-		pr_err(SPCLOG "unable to allocate mem\n");
+	if (!info)
 		return -ENOMEM;
-	}
 
 	info->baseaddr = baseaddr;
 	info->a15_clusid = a15_clusid;
@@ -535,10 +533,8 @@ static struct clk *ve_spc_clk_register(struct device *cpu_dev)
 	struct clk_spc *spc;
 
 	spc = kzalloc(sizeof(*spc), GFP_KERNEL);
-	if (!spc) {
-		pr_err("could not allocate spc clk\n");
+	if (!spc)
 		return ERR_PTR(-ENOMEM);
-	}
 
 	spc->hw.init = &init;
 	spc->cluster = topology_physical_package_id(cpu_dev->id);
-- 
2.14.2

Re: [PATCH] ARM: vexpress/spc: Delete an error message for a failed memory allocation in two functions

[Sudeep Holla]

Hi,

I am not sure if such trivial patches get merged by someone via
kernel-janitors list with just maintainers ack or not. Please let
me know if you want me to pickup this, for now I am just Ack-ing.

On 03/10/17 09:40, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 3 Oct 2017 10:30:07 +0200
> 
> Omit extra messages for a memory allocation failure in these functions.
> 
> This issue was detected by using the Coccinelle software.
> 

Acked-by: Sudeep Holla <sudeep.holla@arm.com>

-- 
Regards,
Sudeep

Re: [PATCH] ARM: vexpress/spc: Delete an error message for a failed memory allocation in two functions

[Dan Carpenter]

On Tue, Oct 03, 2017 at 03:21:25PM +0100, Sudeep Holla wrote:
> Hi,
> 
> I am not sure if such trivial patches get merged by someone via
> kernel-janitors list with just maintainers ack or not. Please let
> me know if you want me to pickup this, for now I am just Ack-ing.

No.  kernel-janitors doesn't pick up patches.

regards,
dan carpenter

Re: [PATCH] ARM: vexpress/spc: Delete an error message for a failed memory allocation in two functions

[Sudeep Holla]

On 03/10/17 15:27, Dan Carpenter wrote:
> On Tue, Oct 03, 2017 at 03:21:25PM +0100, Sudeep Holla wrote:
>> Hi,
>>
>> I am not sure if such trivial patches get merged by someone via
>> kernel-janitors list with just maintainers ack or not. Please let
>> me know if you want me to pickup this, for now I am just Ack-ing.
> 
> No.  kernel-janitors doesn't pick up patches.
> 

Thanks for the quick response. I will pick this up then.

-- 
Regards,
Sudeep