Re: [PATCH 4/4] media: wave5: release runtime PM reference on encoder close errors

[Brandon Brnich <b-brnich@ti.com>]

Hi Jiale,

Thanks for the patch.

On 10/3/26 03:08, Jiale Yao wrote:
> wave5_vpu_enc_close() acquires a runtime PM reference before taking the
> hardware lock, but three error paths call pm_runtime_resume_and_get()
> again instead of releasing that reference. Each failure therefore
> increments the usage count and can prevent the VPU from suspending.
> 
> Use pm_runtime_put_sync() on the error paths, matching the successful
> path and the decoder close implementation.
These issues have already been addressed and are accepted[0].

Best,
Brandon

[0]: 
https://patchwork.linuxtv.org/project/linux-media/patch/20260717075714.1508938-1-lilinmao@kylinos.cn/

> 
> Fixes: 2092b3833487 ("media: chips-media: wave5: Support runtime suspend/resume")
> Signed-off-by: Jiale Yao <yaojiale02@163.com>
> ---
>   drivers/media/platform/chips-media/wave5/wave5-vpuapi.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpuapi.c b/drivers/media/platform/chips-media/wave5/wave5-vpuapi.c
> index 42bc737c6980..062f0b5c318b 100644
> --- a/drivers/media/platform/chips-media/wave5/wave5-vpuapi.c
> +++ b/drivers/media/platform/chips-media/wave5/wave5-vpuapi.c
> @@ -758,7 +758,7 @@ int wave5_vpu_enc_close(struct vpu_instance *inst, u32 *fail_res)
>   
>   	ret = mutex_lock_interruptible(&vpu_dev->hw_lock);
>   	if (ret) {
> -		pm_runtime_resume_and_get(inst->dev->dev);
> +		pm_runtime_put_sync(inst->dev->dev);
>   		return ret;
>   	}
>   
> @@ -766,14 +766,14 @@ int wave5_vpu_enc_close(struct vpu_instance *inst, u32 *fail_res)
>   		ret = wave5_vpu_enc_finish_seq(inst, fail_res);
>   		if (ret < 0 && *fail_res != WAVE5_SYSERR_VPU_STILL_RUNNING) {
>   			dev_warn(inst->dev->dev, "enc_finish_seq timed out\n");
> -			pm_runtime_resume_and_get(inst->dev->dev);
> +			pm_runtime_put_sync(inst->dev->dev);
>   			mutex_unlock(&vpu_dev->hw_lock);
>   			return ret;
>   		}
>   
>   		if (*fail_res == WAVE5_SYSERR_VPU_STILL_RUNNING &&
>   		    retry++ >= MAX_FIRMWARE_CALL_RETRY) {
> -			pm_runtime_resume_and_get(inst->dev->dev);
> +			pm_runtime_put_sync(inst->dev->dev);
>   			mutex_unlock(&vpu_dev->hw_lock);
>   			return -ETIMEDOUT;
>   		}