mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Bee <knaerzche@gmail.com>
To: Robin Murphy <robin.murphy@arm.com>,
	Christian Hewitt <christianshewitt@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: add SPDIF audio to Beelink A1
Date: Wed, 3 Dec 2025 21:23:12 +0100	[thread overview]
Message-ID: <f0df035f-3c3d-4649-9f48-3e8e2e69d17b@gmail.com> (raw)
In-Reply-To: <66ae20b3-3316-4ec2-9c51-8414c053dc32@arm.com>

Hi Robin,

Am 03.12.25 um 17:21 schrieb Robin Murphy:
> [ Just noticed this... ]
>
> On 2025-08-28 5:43 pm, Christian Hewitt wrote:
>> From: Alex Bee <knaerzche@gmail.com>
>>
>> Add the required nodes to enable SPDIF audio output on
>> the Beelink A1 set-top-box.
>
> But the A1 doesn't have S/PDIF? Only HDMI plus a 3.5mm jack connected 
> to the analog audio codec (and possibly the composite TV out) :/
>
Yeah, sorry - this patch wasn't supposed to be submitted upstream.

Regards,

Alex

> Thanks,
> Robin.
>
>> Signed-off-by: Alex Bee <knaerzche@gmail.com>
>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>> ---
>>   arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 23 ++++++++++++++++++++++
>>   1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts 
>> b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>> index f7c4578865c5..b276a29bdd85 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>> @@ -58,6 +58,24 @@ ir-receiver {
>>           gpios = <&gpio2 RK_PA2 GPIO_ACTIVE_LOW>;
>>           linux,rc-map-name = "rc-beelink-gs1";
>>       };
>> +
>> +    spdif_sound: spdif-sound {
>> +        compatible = "simple-audio-card";
>> +        simple-audio-card,name = "SPDIF";
>> +
>> +        simple-audio-card,cpu {
>> +            sound-dai = <&spdif>;
>> +        };
>> +
>> +        simple-audio-card,codec {
>> +            sound-dai = <&spdif_dit>;
>> +        };
>> +    };
>> +
>> +    spdif_dit: spdif-dit {
>> +        compatible = "linux,spdif-dit";
>> +        #sound-dai-cells = <0>;
>> +    };
>>   };
>>     &analog_sound {
>> @@ -325,6 +343,11 @@ &sdmmc {
>>       status = "okay";
>>   };
>>   +&spdif {
>> +    pinctrl-0 = <&spdifm0_tx>;
>> +    status = "okay";
>> +};
>> +
>>   &tsadc {
>>       rockchip,hw-tshut-mode = <0>;
>>       rockchip,hw-tshut-polarity = <0>;

  reply	other threads:[~2025-12-03 20:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28 16:43 Christian Hewitt
2025-08-30 12:57 ` Heiko Stuebner
2025-12-03 16:21 ` Robin Murphy
2025-12-03 20:23   ` Alex Bee [this message]
2025-12-04 14:13     ` Christian Hewitt
2025-12-04 14:33       ` Robin Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0df035f-3c3d-4649-9f48-3e8e2e69d17b@gmail.com \
    --to=knaerzche@gmail.com \
    --cc=christianshewitt@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®