* [PATCH] arm64: dts: rockchip: add SPDIF audio to Beelink A1
@ 2025-08-28 16:43 Christian Hewitt
2025-08-30 12:57 ` Heiko Stuebner
2025-12-03 16:21 ` Robin Murphy
0 siblings, 2 replies; 6+ messages in thread
From: Christian Hewitt @ 2025-08-28 16:43 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Cc: Alex Bee
From: Alex Bee <knaerzche@gmail.com>
Add the required nodes to enable SPDIF audio output on
the Beelink A1 set-top-box.
Signed-off-by: Alex Bee <knaerzche@gmail.com>
Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 23 ++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
index f7c4578865c5..b276a29bdd85 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
@@ -58,6 +58,24 @@ ir-receiver {
gpios = <&gpio2 RK_PA2 GPIO_ACTIVE_LOW>;
linux,rc-map-name = "rc-beelink-gs1";
};
+
+ spdif_sound: spdif-sound {
+ compatible = "simple-audio-card";
+ simple-audio-card,name = "SPDIF";
+
+ simple-audio-card,cpu {
+ sound-dai = <&spdif>;
+ };
+
+ simple-audio-card,codec {
+ sound-dai = <&spdif_dit>;
+ };
+ };
+
+ spdif_dit: spdif-dit {
+ compatible = "linux,spdif-dit";
+ #sound-dai-cells = <0>;
+ };
};
&analog_sound {
@@ -325,6 +343,11 @@ &sdmmc {
status = "okay";
};
+&spdif {
+ pinctrl-0 = <&spdifm0_tx>;
+ status = "okay";
+};
+
&tsadc {
rockchip,hw-tshut-mode = <0>;
rockchip,hw-tshut-polarity = <0>;
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: add SPDIF audio to Beelink A1
2025-08-28 16:43 [PATCH] arm64: dts: rockchip: add SPDIF audio to Beelink A1 Christian Hewitt
@ 2025-08-30 12:57 ` Heiko Stuebner
2025-12-03 16:21 ` Robin Murphy
1 sibling, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2025-08-30 12:57 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel, Christian Hewitt
Cc: Heiko Stuebner, Alex Bee
On Thu, 28 Aug 2025 16:43:00 +0000, Christian Hewitt wrote:
> Add the required nodes to enable SPDIF audio output on
> the Beelink A1 set-top-box.
>
>
Applied, thanks!
[1/1] arm64: dts: rockchip: add SPDIF audio to Beelink A1
commit: 8a449a728cce86183f93a3d1812c94509359719c
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: add SPDIF audio to Beelink A1
2025-08-28 16:43 [PATCH] arm64: dts: rockchip: add SPDIF audio to Beelink A1 Christian Hewitt
2025-08-30 12:57 ` Heiko Stuebner
@ 2025-12-03 16:21 ` Robin Murphy
2025-12-03 20:23 ` Alex Bee
1 sibling, 1 reply; 6+ messages in thread
From: Robin Murphy @ 2025-12-03 16:21 UTC (permalink / raw)
To: Christian Hewitt, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel
Cc: Alex Bee
[ Just noticed this... ]
On 2025-08-28 5:43 pm, Christian Hewitt wrote:
> From: Alex Bee <knaerzche@gmail.com>
>
> Add the required nodes to enable SPDIF audio output on
> the Beelink A1 set-top-box.
But the A1 doesn't have S/PDIF? Only HDMI plus a 3.5mm jack connected to
the analog audio codec (and possibly the composite TV out) :/
Thanks,
Robin.
> Signed-off-by: Alex Bee <knaerzche@gmail.com>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 23 ++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
> index f7c4578865c5..b276a29bdd85 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
> @@ -58,6 +58,24 @@ ir-receiver {
> gpios = <&gpio2 RK_PA2 GPIO_ACTIVE_LOW>;
> linux,rc-map-name = "rc-beelink-gs1";
> };
> +
> + spdif_sound: spdif-sound {
> + compatible = "simple-audio-card";
> + simple-audio-card,name = "SPDIF";
> +
> + simple-audio-card,cpu {
> + sound-dai = <&spdif>;
> + };
> +
> + simple-audio-card,codec {
> + sound-dai = <&spdif_dit>;
> + };
> + };
> +
> + spdif_dit: spdif-dit {
> + compatible = "linux,spdif-dit";
> + #sound-dai-cells = <0>;
> + };
> };
>
> &analog_sound {
> @@ -325,6 +343,11 @@ &sdmmc {
> status = "okay";
> };
>
> +&spdif {
> + pinctrl-0 = <&spdifm0_tx>;
> + status = "okay";
> +};
> +
> &tsadc {
> rockchip,hw-tshut-mode = <0>;
> rockchip,hw-tshut-polarity = <0>;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: add SPDIF audio to Beelink A1
2025-12-03 16:21 ` Robin Murphy
@ 2025-12-03 20:23 ` Alex Bee
2025-12-04 14:13 ` Christian Hewitt
0 siblings, 1 reply; 6+ messages in thread
From: Alex Bee @ 2025-12-03 20:23 UTC (permalink / raw)
To: Robin Murphy, Christian Hewitt, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Heiko Stuebner, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel
Hi Robin,
Am 03.12.25 um 17:21 schrieb Robin Murphy:
> [ Just noticed this... ]
>
> On 2025-08-28 5:43 pm, Christian Hewitt wrote:
>> From: Alex Bee <knaerzche@gmail.com>
>>
>> Add the required nodes to enable SPDIF audio output on
>> the Beelink A1 set-top-box.
>
> But the A1 doesn't have S/PDIF? Only HDMI plus a 3.5mm jack connected
> to the analog audio codec (and possibly the composite TV out) :/
>
Yeah, sorry - this patch wasn't supposed to be submitted upstream.
Regards,
Alex
> Thanks,
> Robin.
>
>> Signed-off-by: Alex Bee <knaerzche@gmail.com>
>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>> ---
>> arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 23 ++++++++++++++++++++++
>> 1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>> b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>> index f7c4578865c5..b276a29bdd85 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>> @@ -58,6 +58,24 @@ ir-receiver {
>> gpios = <&gpio2 RK_PA2 GPIO_ACTIVE_LOW>;
>> linux,rc-map-name = "rc-beelink-gs1";
>> };
>> +
>> + spdif_sound: spdif-sound {
>> + compatible = "simple-audio-card";
>> + simple-audio-card,name = "SPDIF";
>> +
>> + simple-audio-card,cpu {
>> + sound-dai = <&spdif>;
>> + };
>> +
>> + simple-audio-card,codec {
>> + sound-dai = <&spdif_dit>;
>> + };
>> + };
>> +
>> + spdif_dit: spdif-dit {
>> + compatible = "linux,spdif-dit";
>> + #sound-dai-cells = <0>;
>> + };
>> };
>> &analog_sound {
>> @@ -325,6 +343,11 @@ &sdmmc {
>> status = "okay";
>> };
>> +&spdif {
>> + pinctrl-0 = <&spdifm0_tx>;
>> + status = "okay";
>> +};
>> +
>> &tsadc {
>> rockchip,hw-tshut-mode = <0>;
>> rockchip,hw-tshut-polarity = <0>;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: add SPDIF audio to Beelink A1
2025-12-03 20:23 ` Alex Bee
@ 2025-12-04 14:13 ` Christian Hewitt
2025-12-04 14:33 ` Robin Murphy
0 siblings, 1 reply; 6+ messages in thread
From: Christian Hewitt @ 2025-12-04 14:13 UTC (permalink / raw)
To: Alex Bee, Robin Murphy, Heiko Stuebner
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
> On 4 Dec 2025, at 12:23 am, Alex Bee <knaerzche@gmail.com> wrote:
>
> Hi Robin,
>
> Am 03.12.25 um 17:21 schrieb Robin Murphy:
>> [ Just noticed this... ]
>>
>> On 2025-08-28 5:43 pm, Christian Hewitt wrote:
>>> From: Alex Bee <knaerzche@gmail.com>
>>>
>>> Add the required nodes to enable SPDIF audio output on
>>> the Beelink A1 set-top-box.
>>
>> But the A1 doesn't have S/PDIF? Only HDMI plus a 3.5mm jack connected to the analog audio codec (and possibly the composite TV out) :/
>>
> Yeah, sorry - this patch wasn't supposed to be submitted upstream.
Apologies, this is my enthusiasm for trying to clear out the patch
collection LibreELEC has been hoarding by sending things upstream
on behalf of the original authors (and hoarders).
Would you like me to send a revert patch?
Christian
> Regards,
>
> Alex
>
>> Thanks,
>> Robin.
>>
>>> Signed-off-by: Alex Bee <knaerzche@gmail.com>
>>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>>> ---
>>> arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 23 ++++++++++++++++++++++
>>> 1 file changed, 23 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>>> index f7c4578865c5..b276a29bdd85 100644
>>> --- a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>>> +++ b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>>> @@ -58,6 +58,24 @@ ir-receiver {
>>> gpios = <&gpio2 RK_PA2 GPIO_ACTIVE_LOW>;
>>> linux,rc-map-name = "rc-beelink-gs1";
>>> };
>>> +
>>> + spdif_sound: spdif-sound {
>>> + compatible = "simple-audio-card";
>>> + simple-audio-card,name = "SPDIF";
>>> +
>>> + simple-audio-card,cpu {
>>> + sound-dai = <&spdif>;
>>> + };
>>> +
>>> + simple-audio-card,codec {
>>> + sound-dai = <&spdif_dit>;
>>> + };
>>> + };
>>> +
>>> + spdif_dit: spdif-dit {
>>> + compatible = "linux,spdif-dit";
>>> + #sound-dai-cells = <0>;
>>> + };
>>> };
>>> &analog_sound {
>>> @@ -325,6 +343,11 @@ &sdmmc {
>>> status = "okay";
>>> };
>>> +&spdif {
>>> + pinctrl-0 = <&spdifm0_tx>;
>>> + status = "okay";
>>> +};
>>> +
>>> &tsadc {
>>> rockchip,hw-tshut-mode = <0>;
>>> rockchip,hw-tshut-polarity = <0>;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: add SPDIF audio to Beelink A1
2025-12-04 14:13 ` Christian Hewitt
@ 2025-12-04 14:33 ` Robin Murphy
0 siblings, 0 replies; 6+ messages in thread
From: Robin Murphy @ 2025-12-04 14:33 UTC (permalink / raw)
To: Christian Hewitt, Alex Bee, Heiko Stuebner
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
On 2025-12-04 2:13 pm, Christian Hewitt wrote:
>> On 4 Dec 2025, at 12:23 am, Alex Bee <knaerzche@gmail.com> wrote:
>>
>> Hi Robin,
>>
>> Am 03.12.25 um 17:21 schrieb Robin Murphy:
>>> [ Just noticed this... ]
>>>
>>> On 2025-08-28 5:43 pm, Christian Hewitt wrote:
>>>> From: Alex Bee <knaerzche@gmail.com>
>>>>
>>>> Add the required nodes to enable SPDIF audio output on
>>>> the Beelink A1 set-top-box.
>>>
>>> But the A1 doesn't have S/PDIF? Only HDMI plus a 3.5mm jack connected to the analog audio codec (and possibly the composite TV out) :/
>>>
>> Yeah, sorry - this patch wasn't supposed to be submitted upstream.
>
> Apologies, this is my enthusiasm for trying to clear out the patch
> collection LibreELEC has been hoarding by sending things upstream
> on behalf of the original authors (and hoarders).
No worries :)
> Would you like me to send a revert patch?
Since I'm the only one complaining, and I'm liable to have a couple more
Rockchip DT patches to send soon anyway, feel free to leave it with me
unless you're particularly keen.
Cheers,
Robin.
>
> Christian
>
>> Regards,
>>
>> Alex
>>
>>> Thanks,
>>> Robin.
>>>
>>>> Signed-off-by: Alex Bee <knaerzche@gmail.com>
>>>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>>>> ---
>>>> arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 23 ++++++++++++++++++++++
>>>> 1 file changed, 23 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>>>> index f7c4578865c5..b276a29bdd85 100644
>>>> --- a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>>>> +++ b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
>>>> @@ -58,6 +58,24 @@ ir-receiver {
>>>> gpios = <&gpio2 RK_PA2 GPIO_ACTIVE_LOW>;
>>>> linux,rc-map-name = "rc-beelink-gs1";
>>>> };
>>>> +
>>>> + spdif_sound: spdif-sound {
>>>> + compatible = "simple-audio-card";
>>>> + simple-audio-card,name = "SPDIF";
>>>> +
>>>> + simple-audio-card,cpu {
>>>> + sound-dai = <&spdif>;
>>>> + };
>>>> +
>>>> + simple-audio-card,codec {
>>>> + sound-dai = <&spdif_dit>;
>>>> + };
>>>> + };
>>>> +
>>>> + spdif_dit: spdif-dit {
>>>> + compatible = "linux,spdif-dit";
>>>> + #sound-dai-cells = <0>;
>>>> + };
>>>> };
>>>> &analog_sound {
>>>> @@ -325,6 +343,11 @@ &sdmmc {
>>>> status = "okay";
>>>> };
>>>> +&spdif {
>>>> + pinctrl-0 = <&spdifm0_tx>;
>>>> + status = "okay";
>>>> +};
>>>> +
>>>> &tsadc {
>>>> rockchip,hw-tshut-mode = <0>;
>>>> rockchip,hw-tshut-polarity = <0>;
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-12-04 14:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-28 16:43 [PATCH] arm64: dts: rockchip: add SPDIF audio to Beelink A1 Christian Hewitt
2025-08-30 12:57 ` Heiko Stuebner
2025-12-03 16:21 ` Robin Murphy
2025-12-03 20:23 ` Alex Bee
2025-12-04 14:13 ` Christian Hewitt
2025-12-04 14:33 ` Robin Murphy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®