mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Miao <eric.y.miao@gmail.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Liam Girdwood <lrg@slimlogic.co.uk>,
	Mike Rapoport <mike@compulab.co.il>,
	Eric Miao <eric.miao@marvell.com>
Subject: Re: [PATCH] regulator: da903x: add missing __devexit_p()
Date: Mon, 18 May 2009 16:12:36 +0800	[thread overview]
Message-ID: <f17812d70905180112h6fdff033h2235919ca2f29987@mail.gmail.com> (raw)
In-Reply-To: <1242413433-26688-1-git-send-email-vapier@gentoo.org>

On Sat, May 16, 2009 at 2:50 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> The remove function uses __devexit, so the .remove assignment needs
> __devexit_p() to fix a build error with hotplug disabled.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> CC: Liam Girdwood <lrg@slimlogic.co.uk>
> CC: Mike Rapoport <mike@compulab.co.il>
> CC: Eric Miao <eric.miao@marvell.com>

Yes, Acked.

> ---
>  drivers/regulator/da903x.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/regulator/da903x.c b/drivers/regulator/da903x.c
> index 72b1549..c6628f5 100644
> --- a/drivers/regulator/da903x.c
> +++ b/drivers/regulator/da903x.c
> @@ -497,7 +497,7 @@ static struct platform_driver da903x_regulator_driver = {
>                .owner  = THIS_MODULE,
>        },
>        .probe          = da903x_regulator_probe,
> -       .remove         = da903x_regulator_remove,
> +       .remove         = __devexit_p(da903x_regulator_remove),
>  };
>
>  static int __init da903x_regulator_init(void)
> --
> 1.6.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

  reply	other threads:[~2009-05-18  8:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-15 18:50 Mike Frysinger
2009-05-18  8:12 ` Eric Miao [this message]
2009-05-18 10:29 ` Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f17812d70905180112h6fdff033h2235919ca2f29987@mail.gmail.com \
    --to=eric.y.miao@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=eric.miao@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=mike@compulab.co.il \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®