* [PATCH] regulator: da903x: add missing __devexit_p()
@ 2009-05-15 18:50 Mike Frysinger
2009-05-18 8:12 ` Eric Miao
2009-05-18 10:29 ` Liam Girdwood
0 siblings, 2 replies; 3+ messages in thread
From: Mike Frysinger @ 2009-05-15 18:50 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrew Morton, Liam Girdwood, Mike Rapoport, Eric Miao
The remove function uses __devexit, so the .remove assignment needs
__devexit_p() to fix a build error with hotplug disabled.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
CC: Liam Girdwood <lrg@slimlogic.co.uk>
CC: Mike Rapoport <mike@compulab.co.il>
CC: Eric Miao <eric.miao@marvell.com>
---
drivers/regulator/da903x.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/da903x.c b/drivers/regulator/da903x.c
index 72b1549..c6628f5 100644
--- a/drivers/regulator/da903x.c
+++ b/drivers/regulator/da903x.c
@@ -497,7 +497,7 @@ static struct platform_driver da903x_regulator_driver = {
.owner = THIS_MODULE,
},
.probe = da903x_regulator_probe,
- .remove = da903x_regulator_remove,
+ .remove = __devexit_p(da903x_regulator_remove),
};
static int __init da903x_regulator_init(void)
--
1.6.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] regulator: da903x: add missing __devexit_p()
2009-05-15 18:50 [PATCH] regulator: da903x: add missing __devexit_p() Mike Frysinger
@ 2009-05-18 8:12 ` Eric Miao
2009-05-18 10:29 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Eric Miao @ 2009-05-18 8:12 UTC (permalink / raw)
To: Mike Frysinger
Cc: linux-kernel, Andrew Morton, Liam Girdwood, Mike Rapoport, Eric Miao
On Sat, May 16, 2009 at 2:50 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> The remove function uses __devexit, so the .remove assignment needs
> __devexit_p() to fix a build error with hotplug disabled.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> CC: Liam Girdwood <lrg@slimlogic.co.uk>
> CC: Mike Rapoport <mike@compulab.co.il>
> CC: Eric Miao <eric.miao@marvell.com>
Yes, Acked.
> ---
> drivers/regulator/da903x.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/regulator/da903x.c b/drivers/regulator/da903x.c
> index 72b1549..c6628f5 100644
> --- a/drivers/regulator/da903x.c
> +++ b/drivers/regulator/da903x.c
> @@ -497,7 +497,7 @@ static struct platform_driver da903x_regulator_driver = {
> .owner = THIS_MODULE,
> },
> .probe = da903x_regulator_probe,
> - .remove = da903x_regulator_remove,
> + .remove = __devexit_p(da903x_regulator_remove),
> };
>
> static int __init da903x_regulator_init(void)
> --
> 1.6.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] regulator: da903x: add missing __devexit_p()
2009-05-15 18:50 [PATCH] regulator: da903x: add missing __devexit_p() Mike Frysinger
2009-05-18 8:12 ` Eric Miao
@ 2009-05-18 10:29 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2009-05-18 10:29 UTC (permalink / raw)
To: Mike Frysinger; +Cc: linux-kernel, Andrew Morton, Mike Rapoport, Eric Miao
On Fri, 2009-05-15 at 14:50 -0400, Mike Frysinger wrote:
> The remove function uses __devexit, so the .remove assignment needs
> __devexit_p() to fix a build error with hotplug disabled.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> CC: Liam Girdwood <lrg@slimlogic.co.uk>
> CC: Mike Rapoport <mike@compulab.co.il>
> CC: Eric Miao <eric.miao@marvell.com>
> ---
> drivers/regulator/da903x.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
Applied.
Thanks
Liam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-05-18 10:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-15 18:50 [PATCH] regulator: da903x: add missing __devexit_p() Mike Frysinger
2009-05-18 8:12 ` Eric Miao
2009-05-18 10:29 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®