[PATCH] regulator: da903x: add missing __devexit_p()

[PATCH] regulator: da903x: add missing __devexit_p()

[Mike Frysinger]

The remove function uses __devexit, so the .remove assignment needs
__devexit_p() to fix a build error with hotplug disabled.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
CC: Liam Girdwood <lrg@slimlogic.co.uk>
CC: Mike Rapoport <mike@compulab.co.il>
CC: Eric Miao <eric.miao@marvell.com>
---
 drivers/regulator/da903x.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/regulator/da903x.c b/drivers/regulator/da903x.c
index 72b1549..c6628f5 100644
--- a/drivers/regulator/da903x.c
+++ b/drivers/regulator/da903x.c
@@ -497,7 +497,7 @@ static struct platform_driver da903x_regulator_driver = {
 		.owner	= THIS_MODULE,
 	},
 	.probe		= da903x_regulator_probe,
-	.remove		= da903x_regulator_remove,
+	.remove		= __devexit_p(da903x_regulator_remove),
 };
 
 static int __init da903x_regulator_init(void)
-- 
1.6.3

Re: [PATCH] regulator: da903x: add missing __devexit_p()

[Eric Miao]

On Sat, May 16, 2009 at 2:50 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> The remove function uses __devexit, so the .remove assignment needs
> __devexit_p() to fix a build error with hotplug disabled.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> CC: Liam Girdwood <lrg@slimlogic.co.uk>
> CC: Mike Rapoport <mike@compulab.co.il>
> CC: Eric Miao <eric.miao@marvell.com>

Yes, Acked.

> ---
>  drivers/regulator/da903x.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/regulator/da903x.c b/drivers/regulator/da903x.c
> index 72b1549..c6628f5 100644
> --- a/drivers/regulator/da903x.c
> +++ b/drivers/regulator/da903x.c
> @@ -497,7 +497,7 @@ static struct platform_driver da903x_regulator_driver = {
>                .owner  = THIS_MODULE,
>        },
>        .probe          = da903x_regulator_probe,
> -       .remove         = da903x_regulator_remove,
> +       .remove         = __devexit_p(da903x_regulator_remove),
>  };
>
>  static int __init da903x_regulator_init(void)
> --
> 1.6.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Re: [PATCH] regulator: da903x: add missing __devexit_p()

[Liam Girdwood]

On Fri, 2009-05-15 at 14:50 -0400, Mike Frysinger wrote:
> The remove function uses __devexit, so the .remove assignment needs
> __devexit_p() to fix a build error with hotplug disabled.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> CC: Liam Girdwood <lrg@slimlogic.co.uk>
> CC: Mike Rapoport <mike@compulab.co.il>
> CC: Eric Miao <eric.miao@marvell.com>
> ---
>  drivers/regulator/da903x.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 

Applied.

Thanks

Liam