From: "Alexey Zaytsev" <alexey.zaytsev@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Stephen Rothwell" <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"Nick Piggin" <nickpiggin@yahoo.com.au>
Subject: Re: linux-next: Tree for December 11
Date: Wed, 17 Dec 2008 01:21:29 +0300 [thread overview]
Message-ID: <f19298770812161421r77a10575ia956e59a52d7efb2@mail.gmail.com> (raw)
In-Reply-To: <20081216210834.GM14787@elte.hu>
On Wed, Dec 17, 2008 at 00:08, Ingo Molnar <mingo@elte.hu> wrote:
>>
>> The warning can also be reproduced in qemu, so it was easy to bisect.
>>
>> commit 7317d7b87edb41a9135e30be1ec3f7ef817c53dd
>> Author: Nick Piggin <nickpiggin@yahoo.com.au>
>> Date: Tue Sep 30 20:50:27 2008 +1000
>>
>> sched: improve preempt debugging
>>
>> This patch helped me out with a problem I recently had....
>>
>> Basically, when the kernel lock is held, then preempt_count
>> underflow does not
>> get detected until it is released which may be a long time (and arbitrarily,
>> eg at different points it may be rescheduled). If the bkl is released at
>> schedule, the resulting output is actually fairly cryptic...
>>
>> With any other lock that elevates preempt_count, it is illegal to schedule
>> under it (which would get found pretty quickly). bkl allows scheduling with
>> preempt_count elevated, which makes underflows hard to debug.
>>
>> Signed-off-by: Ingo Molnar <mingo@elte.hu>
>>
>> I understand that not this particular commit is buggy, but at least
>> I've got someone to add to the CC. ;)
>>
>> Also the author's e-mail looks suspicious.
>
> Suspicious in what way?
Does not appear in signed-off-by.
>
> Ingo
>
next prev parent reply other threads:[~2008-12-16 22:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 9:04 Stephen Rothwell
2008-12-11 12:40 ` Alexey Zaytsev
2008-12-14 14:34 ` Alexey Zaytsev
2008-12-16 21:08 ` Ingo Molnar
2008-12-16 22:21 ` Alexey Zaytsev [this message]
2008-12-16 22:23 ` Ingo Molnar
2009-01-07 16:30 ` Alexey Zaytsev
2009-01-07 16:50 ` Linus Torvalds
2009-01-07 17:17 ` Ingo Molnar
2009-01-07 17:35 ` Alexey Zaytsev
2009-01-07 18:47 ` Ingo Molnar
2009-01-07 19:10 ` Alexey Zaytsev
2009-12-11 5:01 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f19298770812161421r77a10575ia956e59a52d7efb2@mail.gmail.com \
--to=alexey.zaytsev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®