mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Claudiu Beznea <claudiu.beznea@tuxon.dev>
To: Brian Masney <bmasney@redhat.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Maxime Ripard <mripard@kernel.org>,
	Conor Dooley <conor@kernel.org>,
	Dan Carpenter <dan.carpenter@linaro.org>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v3 2/4] clk: microchip: core: correct return value on *_get_parent()
Date: Sat, 6 Dec 2025 16:31:03 +0200	[thread overview]
Message-ID: <f2d88272-2465-4fcf-b89d-b515a1fbee7f@tuxon.dev> (raw)
In-Reply-To: <20251205-clk-microchip-fixes-v3-2-a02190705e47@redhat.com>



On 12/5/25 21:46, Brian Masney wrote:
> roclk_get_parent() and sclk_get_parent() has the possibility of
> returning -EINVAL, however the framework expects this call to always
> succeed since the return value is unsigned.
> 
> If there is no parent map defined, then the current value programmed in
> the hardware is used. Let's use that same value in the case where
> -EINVAL is currently returned.
> 
> This index is only used by clk_core_get_parent_by_index(), and it
> validates that it doesn't overflow the number of available parents.
> 
> Reported-by: kernel test robot <lkp@intel.com>

I'm getting this from checkpatch:

Applying: clk: microchip: core: correct return value on *_get_parent()
[Checking commit] 910546c58dc2 clk: microchip: core: correct return value
on *_get_parent()
[Checkpatch]      WARNING: Reported-by: should be immediately followed by
Closes: with a URL to the report
#17:
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>


> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/202512050233.R9hAWsJN-lkp@intel.com/
> Signed-off-by: Brian Masney <bmasney@redhat.com>

Other than the above:
Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>

  reply	other threads:[~2025-12-06 14:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-05 19:46 [PATCH v3 0/4] clk: microchip: core: fix issue with round_rate conversion and allow compile test Brian Masney
2025-12-05 19:46 ` [PATCH v3 1/4] clk: microchip: core: remove duplicate determine_rate on pic32_sclk_ops Brian Masney
2025-12-06 14:30   ` Claudiu Beznea
2025-12-05 19:46 ` [PATCH v3 2/4] clk: microchip: core: correct return value on *_get_parent() Brian Masney
2025-12-06 14:31   ` Claudiu Beznea [this message]
2025-12-06 22:38     ` Brian Masney
2025-12-05 19:46 ` [PATCH v3 3/4] clk: microchip: core: remove unused include asm/traps.h Brian Masney
2025-12-05 19:46 ` [PATCH v3 4/4] clk: microchip: core: allow driver to be compiled with COMPILE_TEST Brian Masney
2025-12-06 14:28   ` Claudiu Beznea
2025-12-19 19:32     ` Brian Masney
2026-01-09  7:13       ` claudiu beznea
2026-01-08 23:15 ` [PATCH v3 0/4] clk: microchip: core: fix issue with round_rate conversion and allow compile test Brian Masney
2026-01-09  7:16   ` claudiu beznea
2026-01-09 11:30     ` Brian Masney
2026-01-09 16:45       ` Brian Masney
2026-01-10 14:59 ` Claudiu Beznea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2d88272-2465-4fcf-b89d-b515a1fbee7f@tuxon.dev \
    --to=claudiu.beznea@tuxon.dev \
    --cc=bmasney@redhat.com \
    --cc=conor@kernel.org \
    --cc=dan.carpenter@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mripard@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®