* Re: [PATCH -next] x86/sev: Mark boot_ghcb_page and boot_ghcb static
2023-07-26 17:06 [PATCH -next] x86/sev: Mark boot_ghcb_page and boot_ghcb static Li Zetao
@ 2023-07-26 9:20 ` Nikunj A. Dadhania
2023-07-26 13:22 ` Tom Lendacky
1 sibling, 0 replies; 3+ messages in thread
From: Nikunj A. Dadhania @ 2023-07-26 9:20 UTC (permalink / raw)
To: Li Zetao, tglx, mingo, bp
Cc: x86, hpa, thomas.lendacky, rppt, kirill.shutemov, michael.roth,
linux-kernel
On 7/26/2023 10:36 PM, Li Zetao wrote:
> This patch fixes the following sprse warning:
s/sprse/sparse
>
> arch/x86/boot/compressed/sev.c:28:13: warning:
> symbol boot_ghcb_page was not declared. Should it be static?
> arch/x86/boot/compressed/sev.c:29:13: warning:
> symbol boot_ghcb was not declared. Should it be static?
>
> No functional change intended.
>
> Signed-off-by: Li Zetao <lizetao1@huawei.com>
With the above nit fixed
Reviewed-by: Nikunj A Dadhania <nikunj@amd.com>
> ---
> arch/x86/boot/compressed/sev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
> index 09dc8c187b3c..323f6298a6b2 100644
> --- a/arch/x86/boot/compressed/sev.c
> +++ b/arch/x86/boot/compressed/sev.c
> @@ -25,8 +25,8 @@
> #include "error.h"
> #include "../msr.h"
>
> -struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
> -struct ghcb *boot_ghcb;
> +static struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
> +static struct ghcb *boot_ghcb;
>
> /*
> * Copy a version of this function here - insn-eval.c can't be used in
Regards,
Nikunj
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] x86/sev: Mark boot_ghcb_page and boot_ghcb static
2023-07-26 17:06 [PATCH -next] x86/sev: Mark boot_ghcb_page and boot_ghcb static Li Zetao
2023-07-26 9:20 ` Nikunj A. Dadhania
@ 2023-07-26 13:22 ` Tom Lendacky
1 sibling, 0 replies; 3+ messages in thread
From: Tom Lendacky @ 2023-07-26 13:22 UTC (permalink / raw)
To: Li Zetao, tglx, mingo, bp
Cc: x86, hpa, rppt, kirill.shutemov, michael.roth, nikunj, linux-kernel
On 7/26/23 12:06, Li Zetao wrote:
> This patch fixes the following sprse warning:
>
> arch/x86/boot/compressed/sev.c:28:13: warning:
> symbol boot_ghcb_page was not declared. Should it be static?
> arch/x86/boot/compressed/sev.c:29:13: warning:
> symbol boot_ghcb was not declared. Should it be static?
>
> No functional change intended.
>
> Signed-off-by: Li Zetao <lizetao1@huawei.com>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> arch/x86/boot/compressed/sev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
> index 09dc8c187b3c..323f6298a6b2 100644
> --- a/arch/x86/boot/compressed/sev.c
> +++ b/arch/x86/boot/compressed/sev.c
> @@ -25,8 +25,8 @@
> #include "error.h"
> #include "../msr.h"
>
> -struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
> -struct ghcb *boot_ghcb;
> +static struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
> +static struct ghcb *boot_ghcb;
>
> /*
> * Copy a version of this function here - insn-eval.c can't be used in
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH -next] x86/sev: Mark boot_ghcb_page and boot_ghcb static
@ 2023-07-26 17:06 Li Zetao
2023-07-26 9:20 ` Nikunj A. Dadhania
2023-07-26 13:22 ` Tom Lendacky
0 siblings, 2 replies; 3+ messages in thread
From: Li Zetao @ 2023-07-26 17:06 UTC (permalink / raw)
To: tglx, mingo, bp
Cc: lizetao1, x86, hpa, thomas.lendacky, rppt, kirill.shutemov,
michael.roth, nikunj, linux-kernel
This patch fixes the following sprse warning:
arch/x86/boot/compressed/sev.c:28:13: warning:
symbol boot_ghcb_page was not declared. Should it be static?
arch/x86/boot/compressed/sev.c:29:13: warning:
symbol boot_ghcb was not declared. Should it be static?
No functional change intended.
Signed-off-by: Li Zetao <lizetao1@huawei.com>
---
arch/x86/boot/compressed/sev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/boot/compressed/sev.c b/arch/x86/boot/compressed/sev.c
index 09dc8c187b3c..323f6298a6b2 100644
--- a/arch/x86/boot/compressed/sev.c
+++ b/arch/x86/boot/compressed/sev.c
@@ -25,8 +25,8 @@
#include "error.h"
#include "../msr.h"
-struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
-struct ghcb *boot_ghcb;
+static struct ghcb boot_ghcb_page __aligned(PAGE_SIZE);
+static struct ghcb *boot_ghcb;
/*
* Copy a version of this function here - insn-eval.c can't be used in
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-26 13:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-26 17:06 [PATCH -next] x86/sev: Mark boot_ghcb_page and boot_ghcb static Li Zetao
2023-07-26 9:20 ` Nikunj A. Dadhania
2023-07-26 13:22 ` Tom Lendacky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®