From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Zhifeng Tang <zhifeng.tang@unisoc.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Orson Zhai <orsonzhai@gmail.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Cixi Geng <cixi.geng1@unisoc.com>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhifeng Tang <zhifeng.tang23@gmail.com>,
Wenming Wu <wenming.wu@unisoc.com>
Subject: Re: [PATCH] clk: sprd: Fix thm_parents incorrect configuration
Date: Thu, 24 Aug 2023 10:29:40 +0800 [thread overview]
Message-ID: <f663c2cc-4a4d-7f89-748e-559cd21ff0a4@linux.alibaba.com> (raw)
In-Reply-To: <20230805064820.30305-1-zhifeng.tang@unisoc.com>
On 8/5/2023 2:48 PM, Zhifeng Tang wrote:
> The thm*_clk have two clock sources 32k and 250k,excluding 32m.
>
> Signed-off-by: Zhifeng Tang <zhifeng.tang@unisoc.com>
Please add a Fixes tag. With that, you can add:
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> drivers/clk/sprd/ums512-clk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/sprd/ums512-clk.c b/drivers/clk/sprd/ums512-clk.c
> index fc25bdd85e4e..f43bb10bd5ae 100644
> --- a/drivers/clk/sprd/ums512-clk.c
> +++ b/drivers/clk/sprd/ums512-clk.c
> @@ -800,7 +800,7 @@ static SPRD_MUX_CLK_DATA(uart1_clk, "uart1-clk", uart_parents,
> 0x250, 0, 3, UMS512_MUX_FLAG);
>
> static const struct clk_parent_data thm_parents[] = {
> - { .fw_name = "ext-32m" },
> + { .fw_name = "ext-32k" },
> { .hw = &clk_250k.hw },
> };
> static SPRD_MUX_CLK_DATA(thm0_clk, "thm0-clk", thm_parents,
prev parent reply other threads:[~2023-08-24 2:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-05 6:48 Zhifeng Tang
2023-08-24 2:02 ` Chunyan Zhang
2023-08-24 2:29 ` Baolin Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f663c2cc-4a4d-7f89-748e-559cd21ff0a4@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=cixi.geng1@unisoc.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=orsonzhai@gmail.com \
--cc=sboyd@kernel.org \
--cc=wenming.wu@unisoc.com \
--cc=zhang.lyra@gmail.com \
--cc=zhifeng.tang23@gmail.com \
--cc=zhifeng.tang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®