mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] clk: sprd: Fix thm_parents incorrect configuration
@ 2023-08-05  6:48 Zhifeng Tang
  2023-08-24  2:02 ` Chunyan Zhang
  2023-08-24  2:29 ` Baolin Wang
  0 siblings, 2 replies; 3+ messages in thread
From: Zhifeng Tang @ 2023-08-05  6:48 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd, Orson Zhai, Baolin Wang,
	Chunyan Zhang, Zhifeng Tang, Cixi Geng
  Cc: linux-clk, linux-kernel, Zhifeng Tang, Wenming Wu

The thm*_clk have two clock sources 32k and 250k,excluding 32m.

Signed-off-by: Zhifeng Tang <zhifeng.tang@unisoc.com>
---
 drivers/clk/sprd/ums512-clk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/sprd/ums512-clk.c b/drivers/clk/sprd/ums512-clk.c
index fc25bdd85e4e..f43bb10bd5ae 100644
--- a/drivers/clk/sprd/ums512-clk.c
+++ b/drivers/clk/sprd/ums512-clk.c
@@ -800,7 +800,7 @@ static SPRD_MUX_CLK_DATA(uart1_clk, "uart1-clk", uart_parents,
 			 0x250, 0, 3, UMS512_MUX_FLAG);
 
 static const struct clk_parent_data thm_parents[] = {
-	{ .fw_name = "ext-32m" },
+	{ .fw_name = "ext-32k" },
 	{ .hw = &clk_250k.hw  },
 };
 static SPRD_MUX_CLK_DATA(thm0_clk, "thm0-clk", thm_parents,
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: sprd: Fix thm_parents incorrect configuration
  2023-08-05  6:48 [PATCH] clk: sprd: Fix thm_parents incorrect configuration Zhifeng Tang
@ 2023-08-24  2:02 ` Chunyan Zhang
  2023-08-24  2:29 ` Baolin Wang
  1 sibling, 0 replies; 3+ messages in thread
From: Chunyan Zhang @ 2023-08-24  2:02 UTC (permalink / raw)
  To: Zhifeng Tang, Stephen Boyd
  Cc: Michael Turquette, Orson Zhai, Baolin Wang, Cixi Geng, linux-clk,
	linux-kernel, Zhifeng Tang, Wenming Wu

On Sat, 5 Aug 2023 at 14:48, Zhifeng Tang <zhifeng.tang@unisoc.com> wrote:
>
> The thm*_clk have two clock sources 32k and 250k,excluding 32m.
>
> Signed-off-by: Zhifeng Tang <zhifeng.tang@unisoc.com>

Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>

Thanks,
Chunyan

> ---
>  drivers/clk/sprd/ums512-clk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/sprd/ums512-clk.c b/drivers/clk/sprd/ums512-clk.c
> index fc25bdd85e4e..f43bb10bd5ae 100644
> --- a/drivers/clk/sprd/ums512-clk.c
> +++ b/drivers/clk/sprd/ums512-clk.c
> @@ -800,7 +800,7 @@ static SPRD_MUX_CLK_DATA(uart1_clk, "uart1-clk", uart_parents,
>                          0x250, 0, 3, UMS512_MUX_FLAG);
>
>  static const struct clk_parent_data thm_parents[] = {
> -       { .fw_name = "ext-32m" },
> +       { .fw_name = "ext-32k" },
>         { .hw = &clk_250k.hw  },
>  };
>  static SPRD_MUX_CLK_DATA(thm0_clk, "thm0-clk", thm_parents,
> --
> 2.17.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] clk: sprd: Fix thm_parents incorrect configuration
  2023-08-05  6:48 [PATCH] clk: sprd: Fix thm_parents incorrect configuration Zhifeng Tang
  2023-08-24  2:02 ` Chunyan Zhang
@ 2023-08-24  2:29 ` Baolin Wang
  1 sibling, 0 replies; 3+ messages in thread
From: Baolin Wang @ 2023-08-24  2:29 UTC (permalink / raw)
  To: Zhifeng Tang, Michael Turquette, Stephen Boyd, Orson Zhai,
	Chunyan Zhang, Cixi Geng
  Cc: linux-clk, linux-kernel, Zhifeng Tang, Wenming Wu



On 8/5/2023 2:48 PM, Zhifeng Tang wrote:
> The thm*_clk have two clock sources 32k and 250k,excluding 32m.
> 
> Signed-off-by: Zhifeng Tang <zhifeng.tang@unisoc.com>

Please add a Fixes tag. With that, you can add:
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>

> ---
>   drivers/clk/sprd/ums512-clk.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/sprd/ums512-clk.c b/drivers/clk/sprd/ums512-clk.c
> index fc25bdd85e4e..f43bb10bd5ae 100644
> --- a/drivers/clk/sprd/ums512-clk.c
> +++ b/drivers/clk/sprd/ums512-clk.c
> @@ -800,7 +800,7 @@ static SPRD_MUX_CLK_DATA(uart1_clk, "uart1-clk", uart_parents,
>   			 0x250, 0, 3, UMS512_MUX_FLAG);
>   
>   static const struct clk_parent_data thm_parents[] = {
> -	{ .fw_name = "ext-32m" },
> +	{ .fw_name = "ext-32k" },
>   	{ .hw = &clk_250k.hw  },
>   };
>   static SPRD_MUX_CLK_DATA(thm0_clk, "thm0-clk", thm_parents,

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-08-24  2:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-05  6:48 [PATCH] clk: sprd: Fix thm_parents incorrect configuration Zhifeng Tang
2023-08-24  2:02 ` Chunyan Zhang
2023-08-24  2:29 ` Baolin Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®