mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt
@ 2023-07-24 16:21 qaz6750
  2023-07-24 16:29 ` Konrad Dybcio
  0 siblings, 1 reply; 13+ messages in thread
From: qaz6750 @ 2023-07-24 16:21 UTC (permalink / raw)
  To: andersson, agross
  Cc: konrad.dybcio, robh+dt, krzysztof.kozlowski+dt, conor+dt,
	linux-arm-msm, devicetree, linux-kernel, qaz6750

I2C6 and I2C7 use the same interrupts, which is incorrect.
In the downstream kernel, I2C7 has interrupts of 608 instead of 607.

Signed-off-by: qaz6750 <qaz6750@outlook.com>
---
 arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 18c822abd..214f6e028 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -1231,7 +1231,7 @@ i2c7: i2c@89c000 {
 				dma-names = "tx", "rx";
 				pinctrl-names = "default";
 				pinctrl-0 = <&qup_i2c7_default>;
-				interrupts = <GIC_SPI 607 IRQ_TYPE_LEVEL_HIGH>;
+				interrupts = <GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>;
 				#address-cells = <1>;
 				#size-cells = <0>;
 				status = "disabled";
-- 
2.34.1


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt
  2023-07-24 16:21 [PATCH] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt qaz6750
@ 2023-07-24 16:29 ` Konrad Dybcio
  2023-07-24 16:52   ` Krzysztof Kozlowski
  0 siblings, 1 reply; 13+ messages in thread
From: Konrad Dybcio @ 2023-07-24 16:29 UTC (permalink / raw)
  To: qaz6750, andersson, agross
  Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-arm-msm,
	devicetree, linux-kernel

On 24.07.2023 18:21, qaz6750 wrote:
> I2C6 and I2C7 use the same interrupts, which is incorrect.
> In the downstream kernel, I2C7 has interrupts of 608 instead of 607.
> 
> Signed-off-by: qaz6750 <qaz6750@outlook.com>
> ---
Fixes: 81bee6953b58 ("arm64: dts: qcom: sm8150: add i2c nodes")
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index 18c822abd..214f6e028 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -1231,7 +1231,7 @@ i2c7: i2c@89c000 {
>  				dma-names = "tx", "rx";
>  				pinctrl-names = "default";
>  				pinctrl-0 = <&qup_i2c7_default>;
> -				interrupts = <GIC_SPI 607 IRQ_TYPE_LEVEL_HIGH>;
> +				interrupts = <GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>;
>  				#address-cells = <1>;
>  				#size-cells = <0>;
>  				status = "disabled";

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt
  2023-07-24 16:29 ` Konrad Dybcio
@ 2023-07-24 16:52   ` Krzysztof Kozlowski
  2023-07-24 16:53     ` Konrad Dybcio
  0 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-24 16:52 UTC (permalink / raw)
  To: Konrad Dybcio, qaz6750, andersson, agross
  Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-arm-msm,
	devicetree, linux-kernel

On 24/07/2023 18:29, Konrad Dybcio wrote:
> On 24.07.2023 18:21, qaz6750 wrote:
>> I2C6 and I2C7 use the same interrupts, which is incorrect.
>> In the downstream kernel, I2C7 has interrupts of 608 instead of 607.
>>
>> Signed-off-by: qaz6750 <qaz6750@outlook.com>
>> ---
> Fixes: 81bee6953b58 ("arm64: dts: qcom: sm8150: add i2c nodes")
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

But we also need full name or known identity, not anonymous contribution.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt
  2023-07-24 16:52   ` Krzysztof Kozlowski
@ 2023-07-24 16:53     ` Konrad Dybcio
  2023-07-25  1:46       ` qaz6750
  0 siblings, 1 reply; 13+ messages in thread
From: Konrad Dybcio @ 2023-07-24 16:53 UTC (permalink / raw)
  To: Krzysztof Kozlowski, qaz6750, andersson, agross
  Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-arm-msm,
	devicetree, linux-kernel

On 24.07.2023 18:52, Krzysztof Kozlowski wrote:
> On 24/07/2023 18:29, Konrad Dybcio wrote:
>> On 24.07.2023 18:21, qaz6750 wrote:
>>> I2C6 and I2C7 use the same interrupts, which is incorrect.
>>> In the downstream kernel, I2C7 has interrupts of 608 instead of 607.
>>>
>>> Signed-off-by: qaz6750 <qaz6750@outlook.com>
>>> ---
>> Fixes: 81bee6953b58 ("arm64: dts: qcom: sm8150: add i2c nodes")
>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> 
> But we also need full name or known identity, not anonymous contribution.
Ack, I overlooked that.

Konrad

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt
  2023-07-24 16:53     ` Konrad Dybcio
@ 2023-07-25  1:46       ` qaz6750
  2023-07-25  2:33         ` [PATCH v2] " qaz6750 lzy
  0 siblings, 1 reply; 13+ messages in thread
From: qaz6750 @ 2023-07-25  1:46 UTC (permalink / raw)
  To: konrad.dybcio, agross, andersson
  Cc: conor+dt, devicetree, krzysztof.kozlowski+dt,
	krzysztof.kozlowski, linux-arm-msm, linux-kernel, robh+dt

On 25.07.2023 9:44, qaz6750 wrote:
>On 24.07.2023 18:52, Krzysztof Kozlowski wrote:
>> On 24/07/2023 18:29, Konrad Dybcio wrote:
>>> On 24.07.2023 18:21, qaz6750 wrote:
>>>> I2C6 and I2C7 use the same interrupts, which is incorrect.
>>>> In the downstream kernel, I2C7 has interrupts of 608 instead of 607.
>>>>
>>>> Signed-off-by: qaz6750 <qaz6750@outlook.com>
>>>> ---
>>> Fixes: 81bee6953b58 ("arm64: dts: qcom: sm8150: add i2c nodes")
>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> 
>> But we also need full name or known identity, not anonymous contribution.
>Ack, I overlooked that.

Is it to modify my "Signed-off-by"? I'm sorry I didn't use full name according to the regulations.
I think my full name is zeyan li


Thanks,
qaz6750

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v2] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt
  2023-07-25  1:46       ` qaz6750
@ 2023-07-25  2:33         ` qaz6750 lzy
  2023-07-25  5:30           ` Krzysztof Kozlowski
  0 siblings, 1 reply; 13+ messages in thread
From: qaz6750 lzy @ 2023-07-25  2:33 UTC (permalink / raw)
  To: konrad.dybcio, agross, andersson
  Cc: conor+dt, devicetree, krzysztof.kozlowski+dt,
	krzysztof.kozlowski, linux-arm-msm, linux-kernel, robh+dt,
	qaz6750 lzy

I2C6 and I2C7 use the same interrupts, which is incorrect.
In the downstream kernel, I2C7 has interrupts of 608 instead of 607.

Signed-off-by: qaz6750 lzy <qaz6750@outlook.com>
---
 arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 18c822abd..214f6e028 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -1231,7 +1231,7 @@ i2c7: i2c@89c000 {
 				dma-names = "tx", "rx";
 				pinctrl-names = "default";
 				pinctrl-0 = <&qup_i2c7_default>;
-				interrupts = <GIC_SPI 607 IRQ_TYPE_LEVEL_HIGH>;
+				interrupts = <GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>;
 				#address-cells = <1>;
 				#size-cells = <0>;
 				status = "disabled";
-- 
2.34.1


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt
  2023-07-25  2:33         ` [PATCH v2] " qaz6750 lzy
@ 2023-07-25  5:30           ` Krzysztof Kozlowski
  2023-07-25  5:55             ` qaz6750 lzy
  0 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-25  5:30 UTC (permalink / raw)
  To: qaz6750 lzy, konrad.dybcio, agross, andersson
  Cc: conor+dt, devicetree, krzysztof.kozlowski+dt, linux-arm-msm,
	linux-kernel, robh+dt

On 25/07/2023 04:33, qaz6750 lzy wrote:
> I2C6 and I2C7 use the same interrupts, which is incorrect.
> In the downstream kernel, I2C7 has interrupts of 608 instead of 607.
> 
> Signed-off-by: qaz6750 lzy <qaz6750@outlook.com>

Neither From field nor Signed-off-by have the full name you mentioned
before.

Also: Do not attach (thread) your patchsets to some other threads
(unrelated or older versions). This buries them deep in the mailbox and
might interfere with applying entire sets.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt
  2023-07-25  5:30           ` Krzysztof Kozlowski
@ 2023-07-25  5:55             ` qaz6750 lzy
  2023-07-25  7:42               ` Konrad Dybcio
  0 siblings, 1 reply; 13+ messages in thread
From: qaz6750 lzy @ 2023-07-25  5:55 UTC (permalink / raw)
  To: konrad.dybcio, agross, andersson
  Cc: conor+dt, devicetree, krzysztof.kozlowski+dt,
	krzysztof.kozlowski, linux-arm-msm, linux-kernel, robh+dt

On 25/07/2023 13:50, qaz6750 lzy wrote:
>On 25/07/2023 04:33, qaz6750 lzy wrote:
>> I2C6 and I2C7 use the same interrupts, which is incorrect.
>> In the downstream kernel, I2C7 has interrupts of 608 instead of 607.
>> 
>> Signed-off-by: qaz6750 lzy <qaz6750@outlook.com>
>
>Neither From field nor Signed-off-by have the full name you mentioned
before.
>
>Also: Do not attach (thread) your patchsets to some other threads
>(unrelated or older versions). This buries them deep in the mailbox and
>might interfere with applying entire sets.

I'm sorry, this is my problem. As this is my first time submitting a patch,
I made some mistakes. So, what else do I need to do now? Thank you

I appreciate all your help,
qaz6750 lzy

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v2] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt
  2023-07-25  5:55             ` qaz6750 lzy
@ 2023-07-25  7:42               ` Konrad Dybcio
  0 siblings, 0 replies; 13+ messages in thread
From: Konrad Dybcio @ 2023-07-25  7:42 UTC (permalink / raw)
  To: qaz6750 lzy, agross, andersson
  Cc: conor+dt, devicetree, krzysztof.kozlowski+dt,
	krzysztof.kozlowski, linux-arm-msm, linux-kernel, robh+dt

On 25.07.2023 07:55, qaz6750 lzy wrote:
> On 25/07/2023 13:50, qaz6750 lzy wrote:
>> On 25/07/2023 04:33, qaz6750 lzy wrote:
>>> I2C6 and I2C7 use the same interrupts, which is incorrect.
>>> In the downstream kernel, I2C7 has interrupts of 608 instead of 607.
>>>
>>> Signed-off-by: qaz6750 lzy <qaz6750@outlook.com>
>>
>> Neither From field nor Signed-off-by have the full name you mentioned
> before.
>>
>> Also: Do not attach (thread) your patchsets to some other threads
>> (unrelated or older versions). This buries them deep in the mailbox and
>> might interfere with applying entire sets.
> 
> I'm sorry, this is my problem. As this is my first time submitting a patch,
> I made some mistakes. So, what else do I need to do now? Thank you
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Konrad

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH V2] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt
  2023-07-26 18:46   ` Konrad Dybcio
@ 2023-07-26 20:10     ` Dmitry Baryshkov
  0 siblings, 0 replies; 13+ messages in thread
From: Dmitry Baryshkov @ 2023-07-26 20:10 UTC (permalink / raw)
  To: Konrad Dybcio
  Cc: Krzysztof Kozlowski, qaz6750 lzy, andersson, agross, robh+dt,
	krzysztof.kozlowski+dt, conor+dt, linux-arm-msm, devicetree,
	linux-kernel

On Wed, 26 Jul 2023 at 21:47, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> On 26.07.2023 20:46, Krzysztof Kozlowski wrote:
> > On 25/07/2023 10:42, qaz6750 lzy wrote:
> >> I2C6 and I2C7 use the same interrupts, which is incorrect.
> >> In the downstream kernel, I2C7 has interrupts of 608 instead of 607.
> >>
> >> Fixes: 81bee6953b58 ("arm64: dts: qcom: sm8150: add i2c nodes")
> >> Signed-off-by: qaz6750 lzy <qaz6750@outlook.com>
> >> ---
> >>  [v2] Fixed issue of not using full name
> >
> > You mentioned your full name as a bit different, so I am not sure what
> > improved here.
> To be clear: "real name" usually means "the name that is present on your
> government-issued ID card.

Or at least some kind of a 'full name', not the nickname or a random
set of characters. The same name should be a part of the 'From' and
'Signed-off-by' tags.

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH V2] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt
  2023-07-26 18:46 ` Krzysztof Kozlowski
@ 2023-07-26 18:46   ` Konrad Dybcio
  2023-07-26 20:10     ` Dmitry Baryshkov
  0 siblings, 1 reply; 13+ messages in thread
From: Konrad Dybcio @ 2023-07-26 18:46 UTC (permalink / raw)
  To: Krzysztof Kozlowski, qaz6750 lzy, andersson, agross, robh+dt,
	krzysztof.kozlowski+dt, conor+dt
  Cc: linux-arm-msm, devicetree, linux-kernel

On 26.07.2023 20:46, Krzysztof Kozlowski wrote:
> On 25/07/2023 10:42, qaz6750 lzy wrote:
>> I2C6 and I2C7 use the same interrupts, which is incorrect.
>> In the downstream kernel, I2C7 has interrupts of 608 instead of 607.
>>
>> Fixes: 81bee6953b58 ("arm64: dts: qcom: sm8150: add i2c nodes")
>> Signed-off-by: qaz6750 lzy <qaz6750@outlook.com>
>> ---
>>  [v2] Fixed issue of not using full name
> 
> You mentioned your full name as a bit different, so I am not sure what
> improved here.
To be clear: "real name" usually means "the name that is present on your
government-issued ID card.

Konrad

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH V2] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt
  2023-07-25  8:42 [PATCH V2] " qaz6750 lzy
@ 2023-07-26 18:46 ` Krzysztof Kozlowski
  2023-07-26 18:46   ` Konrad Dybcio
  0 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-26 18:46 UTC (permalink / raw)
  To: qaz6750 lzy, andersson, agross, konrad.dybcio, robh+dt,
	krzysztof.kozlowski+dt, conor+dt
  Cc: linux-arm-msm, devicetree, linux-kernel

On 25/07/2023 10:42, qaz6750 lzy wrote:
> I2C6 and I2C7 use the same interrupts, which is incorrect.
> In the downstream kernel, I2C7 has interrupts of 608 instead of 607.
> 
> Fixes: 81bee6953b58 ("arm64: dts: qcom: sm8150: add i2c nodes")
> Signed-off-by: qaz6750 lzy <qaz6750@outlook.com>
> ---
>  [v2] Fixed issue of not using full name

You mentioned your full name as a bit different, so I am not sure what
improved here.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH V2] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt
@ 2023-07-25  8:42 qaz6750 lzy
  2023-07-26 18:46 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 13+ messages in thread
From: qaz6750 lzy @ 2023-07-25  8:42 UTC (permalink / raw)
  To: andersson, agross, konrad.dybcio, robh+dt,
	krzysztof.kozlowski+dt, conor+dt
  Cc: linux-arm-msm, devicetree, linux-kernel, qaz6750 lzy

I2C6 and I2C7 use the same interrupts, which is incorrect.
In the downstream kernel, I2C7 has interrupts of 608 instead of 607.

Fixes: 81bee6953b58 ("arm64: dts: qcom: sm8150: add i2c nodes")
Signed-off-by: qaz6750 lzy <qaz6750@outlook.com>
---
 [v2] Fixed issue of not using full name

 arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 837bdb574743..560b758b0a06 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -1231,7 +1231,7 @@ i2c7: i2c@89c000 {
 				dma-names = "tx", "rx";
 				pinctrl-names = "default";
 				pinctrl-0 = <&qup_i2c7_default>;
-				interrupts = <GIC_SPI 607 IRQ_TYPE_LEVEL_HIGH>;
+				interrupts = <GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>;
 				#address-cells = <1>;
 				#size-cells = <0>;
 				status = "disabled";
-- 
2.34.1


^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2023-07-26 20:11 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-24 16:21 [PATCH] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt qaz6750
2023-07-24 16:29 ` Konrad Dybcio
2023-07-24 16:52   ` Krzysztof Kozlowski
2023-07-24 16:53     ` Konrad Dybcio
2023-07-25  1:46       ` qaz6750
2023-07-25  2:33         ` [PATCH v2] " qaz6750 lzy
2023-07-25  5:30           ` Krzysztof Kozlowski
2023-07-25  5:55             ` qaz6750 lzy
2023-07-25  7:42               ` Konrad Dybcio
2023-07-25  8:42 [PATCH V2] " qaz6750 lzy
2023-07-26 18:46 ` Krzysztof Kozlowski
2023-07-26 18:46   ` Konrad Dybcio
2023-07-26 20:10     ` Dmitry Baryshkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®