* [PATCH][next] blktrace: remove redundant assignment to ret
@ 2019-06-04 14:27 Colin King
2019-06-04 15:43 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2019-06-04 14:27 UTC (permalink / raw)
To: Jens Axboe, Steven Rostedt, Ingo Molnar, linux-block
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variable ret is being assigned a value that is never read, hence
the assignment is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
kernel/trace/blktrace.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 2d6e93ab0478..ae7c63d6782c 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -507,8 +507,6 @@ static int do_blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
if (!bt->msg_data)
goto err;
- ret = -ENOENT;
-
dir = debugfs_lookup(buts->name, blk_debugfs_root);
if (!dir)
bt->dir = dir = debugfs_create_dir(buts->name, blk_debugfs_root);
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][next] blktrace: remove redundant assignment to ret
2019-06-04 14:27 [PATCH][next] blktrace: remove redundant assignment to ret Colin King
@ 2019-06-04 15:43 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2019-06-04 15:43 UTC (permalink / raw)
To: Colin King, Steven Rostedt, Ingo Molnar, linux-block
Cc: kernel-janitors, linux-kernel
On 6/4/19 8:27 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable ret is being assigned a value that is never read, hence
> the assignment is redundant and can be removed.
This doesn't look correct to me, here's the full code:
ret = -ENOENT;
dir = debugfs_lookup(buts->name, blk_debugfs_root);
if (!dir)
bt->dir = dir = debugfs_create_dir(buts->name, blk_debugfs_root);
if (!dir)
goto err;
[...]
err:
[...]
return ret;
The main issue here, to me, looks like we're not dealing with ERR_PTR
returns from debugfs_create_dir(), just checking for NULL.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-04 15:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-04 14:27 [PATCH][next] blktrace: remove redundant assignment to ret Colin King
2019-06-04 15:43 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®