* [PATCH] jfs: jump to error_out when filemap_{fdatawait, write_and_wait} fails
@ 2016-08-26 14:40 Quorum Laval
2016-08-29 20:53 ` Dave Kleikamp
0 siblings, 1 reply; 2+ messages in thread
From: Quorum Laval @ 2016-08-26 14:40 UTC (permalink / raw)
To: shaggy; +Cc: jfs-discussion, linux-kernel, quorum.laval
filemap_fdatawait/filemap_write_and_wait may fail, so check the return
value and jump to error_out in the case of error.
Signed-off-by: Quorum Laval <quorum.laval@gmail.com>
---
fs/jfs/resize.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/fs/jfs/resize.c b/fs/jfs/resize.c
index 90b3bc2..bd9b641 100644
--- a/fs/jfs/resize.c
+++ b/fs/jfs/resize.c
@@ -379,8 +379,14 @@ int jfs_extendfs(struct super_block *sb, s64 newLVSize, int newLogSize)
* cached in meta-data cache, and not written out
* by txCommit();
*/
- filemap_fdatawait(ipbmap->i_mapping);
- filemap_write_and_wait(ipbmap->i_mapping);
+ rc = filemap_fdatawait(ipbmap->i_mapping);
+ if (rc)
+ goto error_out;
+
+ rc = filemap_write_and_wait(ipbmap->i_mapping);
+ if (rc)
+ goto error_out;
+
diWriteSpecial(ipbmap, 0);
newPage = nPages; /* first new page number */
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] jfs: jump to error_out when filemap_{fdatawait, write_and_wait} fails
2016-08-26 14:40 [PATCH] jfs: jump to error_out when filemap_{fdatawait, write_and_wait} fails Quorum Laval
@ 2016-08-29 20:53 ` Dave Kleikamp
0 siblings, 0 replies; 2+ messages in thread
From: Dave Kleikamp @ 2016-08-29 20:53 UTC (permalink / raw)
To: Quorum Laval; +Cc: jfs-discussion, linux-kernel
On 08/26/2016 09:40 AM, Quorum Laval wrote:
> filemap_fdatawait/filemap_write_and_wait may fail, so check the return
> value and jump to error_out in the case of error.
>
> Signed-off-by: Quorum Laval <quorum.laval@gmail.com>
This looks good. I'll push it upstream.
Thanks,
Dave
> ---
> fs/jfs/resize.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/fs/jfs/resize.c b/fs/jfs/resize.c
> index 90b3bc2..bd9b641 100644
> --- a/fs/jfs/resize.c
> +++ b/fs/jfs/resize.c
> @@ -379,8 +379,14 @@ int jfs_extendfs(struct super_block *sb, s64 newLVSize, int newLogSize)
> * cached in meta-data cache, and not written out
> * by txCommit();
> */
> - filemap_fdatawait(ipbmap->i_mapping);
> - filemap_write_and_wait(ipbmap->i_mapping);
> + rc = filemap_fdatawait(ipbmap->i_mapping);
> + if (rc)
> + goto error_out;
> +
> + rc = filemap_write_and_wait(ipbmap->i_mapping);
> + if (rc)
> + goto error_out;
> +
> diWriteSpecial(ipbmap, 0);
>
> newPage = nPages; /* first new page number */
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-29 20:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-26 14:40 [PATCH] jfs: jump to error_out when filemap_{fdatawait, write_and_wait} fails Quorum Laval
2016-08-29 20:53 ` Dave Kleikamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome