* [PATCH] iio: adc: ti-ads1119: Drop redundant error message
@ 2026-03-02 17:07 Felix Gu
2026-03-02 17:15 ` Andy Shevchenko
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Felix Gu @ 2026-03-02 17:07 UTC (permalink / raw)
To: Francesco Dolcini, João Paulo Gonçalves,
Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko
Cc: linux-iio, linux-kernel, Andy Shevchenko, Felix Gu
devm_request_threaded_irq already prints an error message when failure,
so the error message is redundant, drop it.
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
drivers/iio/adc/ti-ads1119.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iio/adc/ti-ads1119.c b/drivers/iio/adc/ti-ads1119.c
index c9cedc59cdcd..1157e606bc64 100644
--- a/drivers/iio/adc/ti-ads1119.c
+++ b/drivers/iio/adc/ti-ads1119.c
@@ -740,8 +740,7 @@ static int ads1119_probe(struct i2c_client *client)
NULL, IRQF_ONESHOT,
"ads1119", indio_dev);
if (ret)
- return dev_err_probe(dev, ret,
- "Failed to allocate irq\n");
+ return ret;
st->trig = devm_iio_trigger_alloc(dev, "%s-dev%d",
indio_dev->name,
---
base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31
change-id: 20260303-ti-ads1119-2-73294fc211a7
Best regards,
--
Felix Gu <ustc.gu@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: adc: ti-ads1119: Drop redundant error message
2026-03-02 17:07 [PATCH] iio: adc: ti-ads1119: Drop redundant error message Felix Gu
@ 2026-03-02 17:15 ` Andy Shevchenko
2026-03-02 19:50 ` Jonathan Cameron
2026-03-03 8:43 ` Markus Elfring
2026-03-07 13:25 ` Jonathan Cameron
2 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2026-03-02 17:15 UTC (permalink / raw)
To: Felix Gu
Cc: Francesco Dolcini, João Paulo Gonçalves,
Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, linux-iio, linux-kernel
On Tue, Mar 03, 2026 at 01:07:29AM +0800, Felix Gu wrote:
> devm_request_threaded_irq already prints an error message when failure,
> so the error message is redundant, drop it.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: adc: ti-ads1119: Drop redundant error message
2026-03-02 17:15 ` Andy Shevchenko
@ 2026-03-02 19:50 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2026-03-02 19:50 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Felix Gu, Francesco Dolcini, João Paulo Gonçalves,
David Lechner, Nuno Sá,
Andy Shevchenko, linux-iio, linux-kernel
On Mon, 2 Mar 2026 19:15:14 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Tue, Mar 03, 2026 at 01:07:29AM +0800, Felix Gu wrote:
> > devm_request_threaded_irq already prints an error message when failure,
> > so the error message is redundant, drop it.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
Applied to the testing branch of iio.git.
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: adc: ti-ads1119: Drop redundant error message
2026-03-02 17:07 [PATCH] iio: adc: ti-ads1119: Drop redundant error message Felix Gu
2026-03-02 17:15 ` Andy Shevchenko
@ 2026-03-03 8:43 ` Markus Elfring
2026-03-07 13:25 ` Jonathan Cameron
2 siblings, 0 replies; 5+ messages in thread
From: Markus Elfring @ 2026-03-03 8:43 UTC (permalink / raw)
To: Felix Gu, linux-iio, Andy Shevchenko, David Lechner,
Francesco Dolcini, João Paulo Gonçalves,
Jonathan Cameron, Nuno Sá
Cc: LKML, Andy Shevchenko
> devm_request_threaded_irq already prints an error message when failure,
() on execution failure.?
> so the error message is redundant, drop it.
Regards,
Markus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: adc: ti-ads1119: Drop redundant error message
2026-03-02 17:07 [PATCH] iio: adc: ti-ads1119: Drop redundant error message Felix Gu
2026-03-02 17:15 ` Andy Shevchenko
2026-03-03 8:43 ` Markus Elfring
@ 2026-03-07 13:25 ` Jonathan Cameron
2 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2026-03-07 13:25 UTC (permalink / raw)
To: Felix Gu
Cc: Francesco Dolcini, João Paulo Gonçalves, David Lechner,
Nuno Sá,
Andy Shevchenko, linux-iio, linux-kernel, Andy Shevchenko
On Tue, 03 Mar 2026 01:07:29 +0800
Felix Gu <ustc.gu@gmail.com> wrote:
> devm_request_threaded_irq already prints an error message when failure,
> so the error message is redundant, drop it.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Hmm. I applied this already and for some reason didn't reply to say so.
So applied.
J
> ---
> drivers/iio/adc/ti-ads1119.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/ti-ads1119.c b/drivers/iio/adc/ti-ads1119.c
> index c9cedc59cdcd..1157e606bc64 100644
> --- a/drivers/iio/adc/ti-ads1119.c
> +++ b/drivers/iio/adc/ti-ads1119.c
> @@ -740,8 +740,7 @@ static int ads1119_probe(struct i2c_client *client)
> NULL, IRQF_ONESHOT,
> "ads1119", indio_dev);
> if (ret)
> - return dev_err_probe(dev, ret,
> - "Failed to allocate irq\n");
> + return ret;
>
> st->trig = devm_iio_trigger_alloc(dev, "%s-dev%d",
> indio_dev->name,
>
> ---
> base-commit: 3fa5e5702a82d259897bd7e209469bc06368bf31
> change-id: 20260303-ti-ads1119-2-73294fc211a7
>
> Best regards,
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-04-02 0:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-02 17:07 [PATCH] iio: adc: ti-ads1119: Drop redundant error message Felix Gu
2026-03-02 17:15 ` Andy Shevchenko
2026-03-02 19:50 ` Jonathan Cameron
2026-03-03 8:43 ` Markus Elfring
2026-03-07 13:25 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®