[PATCH] ARM: davinci: fix kconfig dependency warning when !PINCTRL

[PATCH] ARM: davinci: fix kconfig dependency warning when !PINCTRL

[Necip Fazil Yildiran]

When ARCH_DAVINCI is enabled and PINCTRL is disabled, it results
in the following Kbuild warning:

WARNING: unmet direct dependencies detected for PINCTRL_SINGLE
  Depends on [n]: PINCTRL [=n] && OF [=y] && HAS_IOMEM [=y]
  Selected by [y]:
  - ARCH_DAVINCI [=y] && ARCH_MULTI_V5 [=y]

The reason is that ARCH_DAVINCI selects PINCTRL_SINGLE without depending on
or selecting PINCTRL while PINCTRL_SINGLE is subordinate to PINCTRL.

Honor the kconfig menu hierarchy to remove kconfig dependency warnings.

Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
---
 arch/arm/mach-davinci/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index f56ff8c24043..e0cbcda6f087 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -11,6 +11,7 @@ menuconfig ARCH_DAVINCI
 	select REGMAP_MMIO
 	select RESET_CONTROLLER
 	select HAVE_IDE
+	select PINCTRL
 	select PINCTRL_SINGLE
 
 if ARCH_DAVINCI
-- 
2.25.1

Re: [PATCH] ARM: davinci: fix kconfig dependency warning when !PINCTRL

[Sekhar Nori]

Hi Necip,

On 14/09/20 6:08 PM, Necip Fazil Yildiran wrote:
> When ARCH_DAVINCI is enabled and PINCTRL is disabled, it results
> in the following Kbuild warning:
> 
> WARNING: unmet direct dependencies detected for PINCTRL_SINGLE
>   Depends on [n]: PINCTRL [=n] && OF [=y] && HAS_IOMEM [=y]
>   Selected by [y]:
>   - ARCH_DAVINCI [=y] && ARCH_MULTI_V5 [=y]
> 
> The reason is that ARCH_DAVINCI selects PINCTRL_SINGLE without depending on
> or selecting PINCTRL while PINCTRL_SINGLE is subordinate to PINCTRL.
> 
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
> 
> Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>

I think its better to fix this by changing the "select PINCTRL_SINGLE"
to "imply PINCTRL_SINGLE". It should be valid to build a DaVinci kernel
without pinctrl support if bootloader is taking care of the pin muxing.

I would not recommend it, but its not illegal either.

While at it, I would drop the other "select PINCTRL" line under "config
MACH_DA8XX_DT". It should not be needed since ARCH_DAVINCI will imply
PINCTRL_SINGLE

Thanks,
Sekhar