From: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
To: Andi Shyti <andi.shyti@kernel.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>
Cc: Robert Foss <rfoss@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Luca Weiss <luca@lucaweiss.eu>,
linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Revert "i2c: qcom-cci: Remove unused struct member cci_clk_rate"
Date: Sat, 25 Jul 2026 11:40:25 +0300 [thread overview]
Message-ID: <fae7e3f6-2d9e-4972-a091-749295f2cc3c@linaro.org> (raw)
In-Reply-To: <amPtXU_RkseFbpKm@zenone.zhora.eu>
Hi Andi,
On 7/25/26 01:57, Andi Shyti wrote:
> Hi Loic,
>
> On Tue, Jul 21, 2026 at 04:58:19PM +0200, Loic Poulain wrote:
>> This reverts commit b641af684fc28a07bee9c808eb6c433f9d9bcec6.
>>
>> The cci_clk_rate field is needed to enforce the correct CCI clock rate
>> at probe time. The hw_params timing values are in clock ticks and were
>> calibrated for a specific frequency per hardware variant, so running at
>> the wrong rate would violate I2C timing specifications.
>>
>> Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
>
> Does this revert need a Fixes tag? I haven't seen very often
> reverts with Fixes tag, but it makes sense if they need to be
> backported.
>
> I'm going to take patch 1 and 2 already while we discuss patch 3
> separately, but please let me know first if you agree adding the
> Fixes tag.
>
please put all commits from this series on hold due to my last finding:
https://lore.kernel.org/linux-arm-msm/8d20f3ab-696e-40a4-a05a-688779299071@linaro.org
--
Best wishes,
Vladimir
next prev parent reply other threads:[~2026-07-25 8:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 14:58 [PATCH 0/3] i2c: qcom-cci: Fix CCI clock rate enforcement Loic Poulain
2026-07-21 14:58 ` [PATCH 1/3] Revert "i2c: qcom-cci: Remove unused struct member cci_clk_rate" Loic Poulain
2026-07-24 22:57 ` Andi Shyti
2026-07-25 5:41 ` Vladimir Zapolskiy
2026-07-25 8:40 ` Vladimir Zapolskiy [this message]
2026-07-26 15:08 ` Andi Shyti
2026-07-21 14:58 ` [PATCH 2/3] i2c: qcom-cci: Add missing cci_clk_rate for msm8953 Loic Poulain
2026-07-25 6:42 ` Vladimir Zapolskiy
2026-07-25 8:36 ` Vladimir Zapolskiy
2026-07-25 13:06 ` Loic Poulain
2026-07-25 14:19 ` Vladimir Zapolskiy
2026-07-21 14:58 ` [PATCH 3/3] i2c: qcom-cci: Fix CCI clock rate enforcement Loic Poulain
2026-07-21 15:07 ` Konrad Dybcio
2026-07-21 15:41 ` Loic Poulain
2026-07-21 17:01 ` Konrad Dybcio
2026-07-23 3:04 ` [PATCH 0/3] " Wenmeng Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fae7e3f6-2d9e-4972-a091-749295f2cc3c@linaro.org \
--to=vladimir.zapolskiy@linaro.org \
--cc=andi.shyti@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=luca@lucaweiss.eu \
--cc=rfoss@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®