mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: ipq9574: add reset to SDHC
@ 2026-09-25 19:16 Robert Marko
  2026-09-27 14:01 ` Kathiravan Thirumoorthy
  2026-09-29  3:15 ` Bjorn Andersson
  0 siblings, 2 replies; 3+ messages in thread
From: Robert Marko @ 2026-09-25 19:16 UTC (permalink / raw)
  To: andersson, konradybcio, abelvesa, robh, krzk+dt, conor+dt,
	linux-arm-msm, devicetree, linux-kernel
  Cc: luka.perkov, Robert Marko

Add reset to SDHCI controller so it can be reset to avoid timeout issues
after software reset due to bootloader set configuration.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
 arch/arm64/boot/dts/qcom/ipq9574.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
index 5a5bda5f21a11..ecafd4cda6e7a 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
@@ -471,6 +471,7 @@ sdhc_1: mmc@7804000 {
 				 <&xo_board_clk>,
 				 <&gcc GCC_SDCC1_ICE_CORE_CLK>;
 			clock-names = "iface", "core", "xo", "ice";
+			resets = <&gcc GCC_SDCC_BCR>;
 			non-removable;
 			supports-cqe;
 			pinctrl-0 = <&sdc_default_state>;
-- 
2.55.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: ipq9574: add reset to SDHC
  2026-09-25 19:16 [PATCH] arm64: dts: qcom: ipq9574: add reset to SDHC Robert Marko
@ 2026-09-27 14:01 ` Kathiravan Thirumoorthy
  2026-09-29  3:15 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Kathiravan Thirumoorthy @ 2026-09-27 14:01 UTC (permalink / raw)
  To: Robert Marko, andersson, konradybcio, abelvesa, robh, krzk+dt,
	conor+dt, linux-arm-msm, devicetree, linux-kernel
  Cc: luka.perkov


On 9/26/2026 12:46 AM, Robert Marko wrote:
> Add reset to SDHCI controller so it can be reset to avoid timeout issues
> after software reset due to bootloader set configuration.
>
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>

Reviewed-by: Kathiravan Thirumoorthy 
<kathiravan.thirumoorthy@oss.qualcomm.com>

Thanks for submitting this. Similar change is needed for other IPQ SoCs 
which is in my TODO list. I will submit those changes in the coming weeks.

> ---
>   arch/arm64/boot/dts/qcom/ipq9574.dtsi | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> index 5a5bda5f21a11..ecafd4cda6e7a 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> @@ -471,6 +471,7 @@ sdhc_1: mmc@7804000 {
>   				 <&xo_board_clk>,
>   				 <&gcc GCC_SDCC1_ICE_CORE_CLK>;
>   			clock-names = "iface", "core", "xo", "ice";
> +			resets = <&gcc GCC_SDCC_BCR>;
>   			non-removable;
>   			supports-cqe;
>   			pinctrl-0 = <&sdc_default_state>;

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: ipq9574: add reset to SDHC
  2026-09-25 19:16 [PATCH] arm64: dts: qcom: ipq9574: add reset to SDHC Robert Marko
  2026-09-27 14:01 ` Kathiravan Thirumoorthy
@ 2026-09-29  3:15 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2026-09-29  3:15 UTC (permalink / raw)
  To: konradybcio, abelvesa, robh, krzk+dt, conor+dt, linux-arm-msm,
	devicetree, linux-kernel, Robert Marko
  Cc: luka.perkov


On Fri, 25 Sep 2026 21:16:34 +0200, Robert Marko wrote:
> Add reset to SDHCI controller so it can be reset to avoid timeout issues
> after software reset due to bootloader set configuration.

Applied, thanks!

[1/1] arm64: dts: qcom: ipq9574: add reset to SDHC
      commit: 8a8e78e4667264fa680b37c1b6ae6caa75bb735c

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-29  3:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-25 19:16 [PATCH] arm64: dts: qcom: ipq9574: add reset to SDHC Robert Marko
2026-09-27 14:01 ` Kathiravan Thirumoorthy
2026-09-29  3:15 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®