Re: [PATCH] drm/panel-edp: Add BOE NV140FHM-N4Z panel entry

[Thomas Zimmermann <tzimmermann@suse.de>]

Hi


Am 14.01.25 um 17:44 schrieb Doug Anderson:
>
> FWIW it's good that Thomas replied to your patch, since that was the
> only thing that showed up in my inbox. Your initial patch showed up as
> spam for me. :( Not sure why, though...

FTR, my R-b was for the code itself. I did not verify if the values are 
meaningful/correct.

Best regards
Thomas

>
>
>>>> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
>>>> index 94a46241dece..a3402b76aa3e 100644
>>>> --- a/drivers/gpu/drm/panel/panel-edp.c
>>>> +++ b/drivers/gpu/drm/panel/panel-edp.c
>>>> @@ -1909,6 +1909,7 @@ static const struct edp_panel_entry edp_panels[] = {
>>>>       EDP_PANEL_ENTRY('B', 'O', 'E', 0x0ac5, &delay_200_500_e50, "NV116WHM-N4C"),
>>>>       EDP_PANEL_ENTRY('B', 'O', 'E', 0x0ae8, &delay_200_500_e50_p2e80, "NV140WUM-N41"),
>>>>       EDP_PANEL_ENTRY('B', 'O', 'E', 0x0b34, &delay_200_500_e80, "NV122WUM-N41"),
>>>> +     EDP_PANEL_ENTRY('B', 'O', 'E', 0x0b09, &delay_200_500_e50_p2e200, "NV140FHM-NZ"),
>>>>       EDP_PANEL_ENTRY('B', 'O', 'E', 0x0b43, &delay_200_500_e200, "NV140FHM-T09"),
> This is mis-sorted. 0xb09 should be _before_ 0x0b34. I'll often fix
> this up when applying (though it's more work for me), but since I had
> a question above about delay_200_500_e50_p2e200 vs.
> delay_200_500_e50_p2e80 maybe you can answer and also send a v2 with
> the sort order fixed.
>
> -Doug

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)