* [PATCH] m68k: Fix two occurrences of the checkpatch.pl error: [not found] <20230721075949.5632-1-xujianghui@cdjrlc.com> @ 2023-07-21 8:00 ` sunran001 2023-07-24 8:50 ` Geert Uytterhoeven 0 siblings, 1 reply; 2+ messages in thread From: sunran001 @ 2023-07-21 8:00 UTC (permalink / raw) To: geert; +Cc: linux-m68k, linux-kernel ERROR: that open brace { should be on the previous line ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Ran Sun <sunran001@208suo.com> --- arch/m68k/q40/config.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/m68k/q40/config.c b/arch/m68k/q40/config.c index c78ee709b458..62ed3634c0a4 100644 --- a/arch/m68k/q40/config.c +++ b/arch/m68k/q40/config.c @@ -146,9 +146,8 @@ static void q40_get_model(char *model) sprintf(model, "Q40"); } -static unsigned int serports[] = -{ - 0x3f8,0x2f8,0x3e8,0x2e8,0 +static unsigned int serports[] = { + 0x3f8, 0x2f8, 0x3e8, 0x2e8, 0 }; static void __init q40_disable_irqs(void) ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] m68k: Fix two occurrences of the checkpatch.pl error: 2023-07-21 8:00 ` [PATCH] m68k: Fix two occurrences of the checkpatch.pl error: sunran001 @ 2023-07-24 8:50 ` Geert Uytterhoeven 0 siblings, 0 replies; 2+ messages in thread From: Geert Uytterhoeven @ 2023-07-24 8:50 UTC (permalink / raw) To: sunran001; +Cc: linux-m68k, linux-kernel Hi Ran, On Fri, Jul 21, 2023 at 10:04 AM <sunran001@208suo.com> wrote: > ERROR: that open brace { should be on the previous line > ERROR: space required after that ',' (ctx:VxV) > > Signed-off-by: Ran Sun <sunran001@208suo.com> Thanks for your patch! But obviously you forgot to run scripts/checkpatch.pl on your own patch: WARNING: A patch subject line should describe the change not the tool that found it #2: Subject: [PATCH] m68k: Fix two occurrences of the checkpatch.pl error: WARNING: From:/Signed-off-by: email name mismatch: 'From: sunran001@208suo.com' != 'Signed-off-by: Ran Sun <sunran001@208suo.com>' Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-24 8:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230721075949.5632-1-xujianghui@cdjrlc.com>
2023-07-21 8:00 ` [PATCH] m68k: Fix two occurrences of the checkpatch.pl error: sunran001
2023-07-24 8:50 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®