* [PATCH] staging: greybus: add blank lines after struct definitions in gbphy.h
@ 2026-10-15 22:27 Okhuomon Ajayi
2026-10-16 2:17 ` Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Okhuomon Ajayi @ 2026-10-15 22:27 UTC (permalink / raw)
To: outreachy
Cc: Johan Hovold, Alex Elder, Greg Kroah-Hartman, greybus-dev,
linux-staging, linux-kernel, Okhuomon Ajayi
Add blank lines between the structure definitions and the
to_gbphy_dev() and to_gbphy_driver() macros to improve
readability. This fixes the following checkpatch warning:
CHECK: Please use a blank line after function/struct/union/enum
declarations
Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
---
drivers/staging/greybus/gbphy.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/greybus/gbphy.h b/drivers/staging/greybus/gbphy.h
index d4a225b76338..1de510499480 100644
--- a/drivers/staging/greybus/gbphy.h
+++ b/drivers/staging/greybus/gbphy.h
@@ -15,6 +15,7 @@ struct gbphy_device {
struct list_head list;
struct device dev;
};
+
#define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev)
static inline void *gb_gbphy_get_data(struct gbphy_device *gdev)
@@ -43,6 +44,7 @@ struct gbphy_driver {
struct device_driver driver;
};
+
#define to_gbphy_driver(d) container_of(d, struct gbphy_driver, driver)
int gb_gbphy_register_driver(struct gbphy_driver *driver,
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: greybus: add blank lines after struct definitions in gbphy.h
2026-10-15 22:27 [PATCH] staging: greybus: add blank lines after struct definitions in gbphy.h Okhuomon Ajayi
@ 2026-10-16 2:17 ` Julia Lawall
2026-10-16 4:55 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2026-10-16 2:17 UTC (permalink / raw)
To: Okhuomon Ajayi
Cc: outreachy, Johan Hovold, Alex Elder, Greg Kroah-Hartman,
greybus-dev, linux-staging, linux-kernel
On Thu, 15 Oct 2026, Okhuomon Ajayi wrote:
> Add blank lines between the structure definitions and the
> to_gbphy_dev() and to_gbphy_driver() macros to improve
> readability. This fixes the following checkpatch warning:
Thanks for the patch. But I suspect that the lack of a newline was
intentional, to show that the #define is closely associated with the
previous structure declaration.
julia
>
> CHECK: Please use a blank line after function/struct/union/enum
> declarations
>
> Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
> ---
> drivers/staging/greybus/gbphy.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/greybus/gbphy.h b/drivers/staging/greybus/gbphy.h
> index d4a225b76338..1de510499480 100644
> --- a/drivers/staging/greybus/gbphy.h
> +++ b/drivers/staging/greybus/gbphy.h
> @@ -15,6 +15,7 @@ struct gbphy_device {
> struct list_head list;
> struct device dev;
> };
> +
> #define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev)
>
> static inline void *gb_gbphy_get_data(struct gbphy_device *gdev)
> @@ -43,6 +44,7 @@ struct gbphy_driver {
>
> struct device_driver driver;
> };
> +
> #define to_gbphy_driver(d) container_of(d, struct gbphy_driver, driver)
>
> int gb_gbphy_register_driver(struct gbphy_driver *driver,
> --
> 2.43.0
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: greybus: add blank lines after struct definitions in gbphy.h
2026-10-16 2:17 ` Julia Lawall
@ 2026-10-16 4:55 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2026-10-16 4:55 UTC (permalink / raw)
To: Julia Lawall
Cc: Okhuomon Ajayi, outreachy, Johan Hovold, Alex Elder, greybus-dev,
linux-staging, linux-kernel
On Thu, Oct 15, 2026 at 10:17:35PM -0400, Julia Lawall wrote:
>
>
> On Thu, 15 Oct 2026, Okhuomon Ajayi wrote:
>
> > Add blank lines between the structure definitions and the
> > to_gbphy_dev() and to_gbphy_driver() macros to improve
> > readability. This fixes the following checkpatch warning:
>
> Thanks for the patch. But I suspect that the lack of a newline was
> intentional, to show that the #define is closely associated with the
> previous structure declaration.
That is correct.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-16 4:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-15 22:27 [PATCH] staging: greybus: add blank lines after struct definitions in gbphy.h Okhuomon Ajayi
2026-10-16 2:17 ` Julia Lawall
2026-10-16 4:55 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®